From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Johan Hovold <johan+linaro@kernel.org>, Vinod Koul <vkoul@kernel.org>
Cc: Bard Liao <yung-chuan.liao@linux.intel.com>,
Sanyog Kale <sanyog.r.kale@intel.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] soundwire: bus: suppress probe deferral errors
Date: Tue, 4 Jun 2024 10:30:21 +0200 [thread overview]
Message-ID: <c5ecc0cd-c2ba-4f71-ac2a-9a81793a8f0c@linux.intel.com> (raw)
In-Reply-To: <20240604075213.20815-2-johan+linaro@kernel.org>
On 6/4/24 02:52, Johan Hovold wrote:
> Soundwire driver probe errors are currently being logged both by the bus
> code and driver core:
>
> wsa884x-codec sdw:4:0:0217:0204:00:0: Probe of wsa884x-codec failed: -12
> wsa884x-codec sdw:4:0:0217:0204:00:0: probe with driver wsa884x-codec failed with error -12
>
> Drop the redundant bus error message, which is also incorrectly being
> logged on probe deferral:
It's only redundant in the QCOM case... This would remove all error logs
for other codecs, e.g. see
rt711_sdca_sdw_probe
cs35l56_sdw_probe
wcd9390_probe
Looks like the wsa884x-codec is the chatty driver, others are just fine
with the existing code.
next prev parent reply other threads:[~2024-06-04 8:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 7:52 [PATCH v2 0/4] soundwire: bus: suppress probe deferral errors Johan Hovold
2024-06-04 7:52 ` [PATCH v2 1/4] " Johan Hovold
2024-06-04 8:30 ` Pierre-Louis Bossart [this message]
2024-06-04 9:09 ` Johan Hovold
2024-06-04 13:29 ` Pierre-Louis Bossart
2024-06-04 7:52 ` [PATCH v2 2/4] soundwire: bus: drop unused driver name field Johan Hovold
2024-06-04 7:52 ` [PATCH v2 3/4] soundwire: bus: clean up probe warnings Johan Hovold
2024-06-04 8:33 ` Pierre-Louis Bossart
2024-06-04 9:17 ` Johan Hovold
2024-06-04 13:43 ` Pierre-Louis Bossart
2024-06-04 14:18 ` Johan Hovold
2024-06-04 15:07 ` Pierre-Louis Bossart
2024-06-05 12:11 ` Johan Hovold
2024-06-05 16:15 ` Pierre-Louis Bossart
2024-06-04 7:52 ` [PATCH v2 4/4] soundwire: bus: drop redundant probe debug message Johan Hovold
2024-06-04 8:37 ` Pierre-Louis Bossart
2024-06-04 9:24 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5ecc0cd-c2ba-4f71-ac2a-9a81793a8f0c@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=johan+linaro@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sanyog.r.kale@intel.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox