From: Xing Zhengjun <zhengjun.xing@linux.intel.com>
To: "Liang, Kan" <kan.liang@linux.intel.com>,
John Garry <john.garry@huawei.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@redhat.com,
namhyung@kernel.org, irogers@google.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf pmu: Fix event list for uncore PMUs
Date: Tue, 21 Dec 2021 14:59:02 +0800 [thread overview]
Message-ID: <c63144a6-efd4-d266-a584-11eb34391569@linux.intel.com> (raw)
In-Reply-To: <eb0fc722-5de6-04be-8440-5df6a8236847@linux.intel.com>
On 12/21/2021 12:34 AM, Liang, Kan wrote:
>
>
> On 12/20/2021 3:38 AM, John Garry wrote:
>> On 18/12/2021 01:47, Arnaldo Carvalho de Melo wrote:
>>>> Commit 0e0ae8742207 ("perf list: Display hybrid PMU events with cpu
>>>> type")
>>>> changed the list for uncore PMUs, such that duplicate aliases are now
>>>> listed per PMU (which they should not be), like:
>>>>
>>>> ./perf list
>>>> ...
>>>> unc_cbo_cache_lookup.any_es
>>>> [Unit: uncore_cbox L3 Lookup any request that access cache and found
>>>> line in E or S-state]
>>>> unc_cbo_cache_lookup.any_es
>>>> [Unit: uncore_cbox L3 Lookup any request that access cache and found
>>>> line in E or S-state]
>>>> unc_cbo_cache_lookup.any_i
>>>> [Unit: uncore_cbox L3 Lookup any request that access cache and found
>>>> line in I-state]
>>>> unc_cbo_cache_lookup.any_i
>>>> [Unit: uncore_cbox L3 Lookup any request that access cache and found
>>>> line in I-state]
>>>> ...
>>>>
>>>> Notice how the events are listed twice.
>>> Hi Jin,
>>>
>>> Can I have your acked-by/tested-by?
>>
>> Hi Arnaldo,
>>
>> I assume that address is bouncing for you also.
>>
>
> Yes, Jin Yao has left Intel.
>
>> So if anyone else has one of these hybrid PMU x86 systems then it
>> would be appreciated to check this change.
>>
>
> + Zhengjun
>
> Zhengjun,
>
> Could you please help to verify the change?
>
> Thanks,
> Kan
Tested this patch on one hybrid PMU x86 system, it works OK.
Tested-by: Zhengjun Xing <zhengjun.xing@linux.intel.com>
--
Zhengjun Xing
next prev parent reply other threads:[~2021-12-21 6:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 15:53 [PATCH] perf pmu: Fix event list for uncore PMUs John Garry
2021-12-18 1:47 ` Arnaldo Carvalho de Melo
2021-12-20 8:38 ` John Garry
2021-12-20 16:34 ` Liang, Kan
2021-12-21 6:59 ` Xing Zhengjun [this message]
2021-12-21 7:58 ` Jiri Olsa
2021-12-21 9:10 ` John Garry
2021-12-21 9:35 ` Jiri Olsa
2021-12-21 10:14 ` John Garry
2021-12-21 20:48 ` Arnaldo Carvalho de Melo
2021-12-22 13:08 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c63144a6-efd4-d266-a584-11eb34391569@linux.intel.com \
--to=zhengjun.xing@linux.intel.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox