From: "Rafał Miłecki" <rafal@milecki.pl>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-kernel@vger.kernel.org, Michael Walle <michael@walle.cc>
Subject: Re: [RESEND PATCH 30/37] nvmem: core: fix nvmem_layout_get_match_data()
Date: Mon, 06 Feb 2023 13:09:48 +0100 [thread overview]
Message-ID: <c6394c5daead464df1ddad781829668e@milecki.pl> (raw)
In-Reply-To: <Y+Dst2V9mfJbVrzD@kroah.com>
On 2023-02-06 13:04, Greg KH wrote:
> On Mon, Feb 06, 2023 at 10:27:52AM +0000, Srinivas Kandagatla wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> This function was trying to match wrong OF node (parent device's)
>> against an of_match_table. It was always returning NULL.
>>
>> Make it match layout's OF node against layout's of_match_table.
>>
>> Note: __maybe_unused is needed to avoid:
>> warning: variable 'layout_np' set but not used
>> [-Wunused-but-set-variable]
>> (of_match_node() is no-op without CONFIG_OF).
>>
>> Fixes: 61a093b4a0e0 ("nvmem: core: introduce NVMEM layouts")
>
> Nit, how can you have a git commit id if you are sending me patches to
> be applied to my tree?
>
> That's never going to work, sorry.
That was commit I found in the:
https://git.kernel.org/pub/scm/linux/kernel/git/srini/nvmem.git/log/?h=for-next
With Srinivas sending patches and not merge request, it doesn't make
sense obviously.
Srinivas could you rebase your branch making my patch a fixup for the
commit 61a093b4a0e0?
next prev parent reply other threads:[~2023-02-06 14:37 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 10:27 [RESEND PATCH 00/37] nvmem: patches for 6.3 Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 01/37] nvmem: sunxi_sid: Drop the workaround on A64 Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 02/37] dt-bindings: nvmem: Fix qcom,qfprom compatibles enum ordering Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 03/37] dt-bindings: nvmem: Add compatible for MSM8976 Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 04/37] dt-bindings: nvmem: qfprom: add sdm670 compatible Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 05/37] dt-bindings: nvmem: Add compatible for SM8150 Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 06/37] dt-bindings: nvmem: Add compatible for SM8250 Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 07/37] nvmem: core: remove spurious white space Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 08/37] net: add helper eth_addr_add() Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 09/37] of: base: add of_parse_phandle_with_optional_args() Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 10/37] of: property: make #.*-cells optional for simple props Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 11/37] of: property: add #nvmem-cell-cells property Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 12/37] nvmem: core: add an index parameter to the cell Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 13/37] nvmem: core: move struct nvmem_cell_info to nvmem-provider.h Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 14/37] nvmem: core: drop the removal of the cells in nvmem_add_cells() Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 15/37] nvmem: core: add nvmem_add_one_cell() Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 16/37] nvmem: core: use nvmem_add_one_cell() in nvmem_add_cells_from_of() Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 17/37] nvmem: core: introduce NVMEM layouts Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 18/37] nvmem: core: add per-cell post processing Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 19/37] nvmem: core: allow to modify a cell before adding it Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 20/37] nvmem: imx-ocotp: replace global post processing with layouts Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 21/37] nvmem: cell: drop global cell_post_process Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 22/37] nvmem: core: provide own priv pointer in post process callback Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 23/37] nvmem: layouts: add sl28vpd layout Srinivas Kandagatla
2023-02-06 12:02 ` Greg KH
2023-02-06 10:27 ` [RESEND PATCH 24/37] MAINTAINERS: add myself as sl28vpd nvmem layout driver Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 25/37] nvmem: layouts: Add ONIE tlv " Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 26/37] MAINTAINERS: Add myself as ONIE tlv NVMEM layout maintainer Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 27/37] nvmem: core: return -ENOENT if nvmem cell is not found Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 28/37] nvmem: layouts: Fix spelling mistake "platforn" -> "platform" Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 29/37] dt-bindings: nvmem: " Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 30/37] nvmem: core: fix nvmem_layout_get_match_data() Srinivas Kandagatla
2023-02-06 12:04 ` Greg KH
2023-02-06 12:08 ` Srinivas Kandagatla
2023-02-06 12:39 ` Greg KH
2023-02-06 12:09 ` Rafał Miłecki [this message]
2023-02-06 10:27 ` [RESEND PATCH 31/37] nvmem: stm32: add OP-TEE support for STM32MP13x Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 32/37] nvmem: stm32: detect bsec pta presence for STM32MP15x Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 33/37] nvmem: rave-sp-eeprm: fix kernel-doc bad line warning Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 34/37] of: property: fix #nvmem-cell-cells parsing Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 35/37] nvmem: qcom-spmi-sdam: register at device init time Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 36/37] dt-bindings: nvmem: qfprom: add IPQ8074 compatible Srinivas Kandagatla
2023-02-06 10:27 ` [RESEND PATCH 37/37] nvmem: stm32: fix OPTEE dependency Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6394c5daead464df1ddad781829668e@milecki.pl \
--to=rafal@milecki.pl \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox