From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C61D22AD04 for ; Fri, 13 Jun 2025 05:31:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749792711; cv=none; b=LB6UbFcYSqQ00HnBqonNHhLNxEShlKrQVbm4AkdWXaRqvhpoIJu5G/KolUeJLaaj4czKE7dKD7hCpObIPOJDqSC62yWBU8mzcgy3s59+4uaZIt0HNLi2qQOsE/v3SV5RHGV87NPb0sdAA+Jx1gHxLgdhU9F4FT1GbsinBg5XouI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749792711; c=relaxed/simple; bh=NRB2YHNY6V0/cOywozOMB3mtKlY/Qugj7lYZ5RarsSE=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=q1mpJBjM9wPiVk+D+pmhrAjj1/1erh+8idV5GpMeQpc1MyV/zn8G81T3RFxQFaJ5ypn/PvEsuqvMuJzhyk4PCQtsCL8W/qkUWJ9/4Ayf+L6kfnCanNygEPYTbNf3XgXfQ1bbLfpaofVJM41RM0Nwzn3HtcRzkcPKuRhM1nS1X/8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nYtPnR5G; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nYtPnR5G" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47BF6C4CEED; Fri, 13 Jun 2025 05:31:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749792711; bh=NRB2YHNY6V0/cOywozOMB3mtKlY/Qugj7lYZ5RarsSE=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=nYtPnR5G1vn3Ht0iV6UzuHLZKJDksJQaR0r5V7URS8Ga3gir4t4NZcfC5Ka8Re1be CM1sv9gblBtwphGBYNmCkHhPKS5g1hSIJxy2ZJxDl1FNriNeE5yaqSNHpdlB/twh7v uDYdGEQg23mUMvPVKzJCb6EoeiOWz+YUmKP4JZWPvAaczPoHgZIVMKROrZgew+yMHu LuNW2NWCbregO6XMjrwqVhB+7BbqdIc68emrrFqRlDt7m/cFHJ15SKlM6F5FHM0BL1 GXWjwWgD+QiDsRroUNIW+b7AFnv3LN4qjTVuHO5TMEYJn+146/EkIwydIiqsjfPBwl D1ztMtUr/pbRw== Message-ID: Date: Fri, 13 Jun 2025 13:31:56 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, jaegeuk@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [f2fs-dev] [PATCH] f2fs: introduce reserved_pin_section sysfs entry To: wangzijie , linux-f2fs-devel@lists.sourceforge.net References: <20250612140526.6435-1-chao@kernel.org> <20250613051110.1865186-1-wangzijie1@honor.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20250613051110.1865186-1-wangzijie1@honor.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025/6/13 13:11, wangzijie wrote: >> This patch introduces /sys/fs/f2fs//reserved_pin_section for tuning >> @needed parameter of has_not_enough_free_secs(), if we configure it w/ >> zero, it can avoid f2fs_gc() as much as possible while fallocating on >> pinned file. >> >> Signed-off-by: Chao Yu >> --- >> Documentation/ABI/testing/sysfs-fs-f2fs | 9 +++++++++ >> fs/f2fs/f2fs.h | 3 +++ >> fs/f2fs/file.c | 5 ++--- >> fs/f2fs/super.c | 3 +++ >> fs/f2fs/sysfs.c | 9 +++++++++ >> 5 files changed, 26 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs b/Documentation/ABI/testing/sysfs-fs-f2fs >> index bf03263b9f46..c2a233f2a085 100644 >> --- a/Documentation/ABI/testing/sysfs-fs-f2fs >> +++ b/Documentation/ABI/testing/sysfs-fs-f2fs >> @@ -861,3 +861,12 @@ Description: This is a read-only entry to show the value of sb.s_encoding_flags, >> SB_ENC_STRICT_MODE_FL 0x00000001 >> SB_ENC_NO_COMPAT_FALLBACK_FL 0x00000002 >> ============================ ========== >> + >> +What: /sys/fs/f2fs//reserved_pin_section >> +Date: June 2025 >> +Contact: "Chao Yu" >> +Description: This threshold is used to control triggering garbage collection while >> + fallocating on pinned file, so, it can guarantee there is enough free >> + reserved section before preallocating on pinned file. >> + By default, the value is ovp_sections, especially, for zoned ufs, the >> + value is 1. >> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h >> index 9333a22b9a01..fa27498202a3 100644 >> --- a/fs/f2fs/f2fs.h >> +++ b/fs/f2fs/f2fs.h >> @@ -1724,6 +1724,9 @@ struct f2fs_sb_info { >> /* for skip statistic */ >> unsigned long long skipped_gc_rwsem; /* FG_GC only */ >> >> + /* free sections reserved for pinned file */ >> + unsigned int reserved_pin_section; >> + >> /* threshold for gc trials on pinned files */ >> unsigned short gc_pin_file_threshold; >> struct f2fs_rwsem pin_sem; >> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c >> index 696131e655ed..a909f79db178 100644 >> --- a/fs/f2fs/file.c >> +++ b/fs/f2fs/file.c >> @@ -1887,9 +1887,8 @@ static int f2fs_expand_inode_data(struct inode *inode, loff_t offset, >> } >> } >> >> - if (has_not_enough_free_secs(sbi, 0, f2fs_sb_has_blkzoned(sbi) ? >> - ZONED_PIN_SEC_REQUIRED_COUNT : >> - GET_SEC_FROM_SEG(sbi, overprovision_segments(sbi)))) { >> + if (has_not_enough_free_secs(sbi, 0, >> + sbi->reserved_pin_section)) { >> f2fs_down_write(&sbi->gc_lock); >> stat_inc_gc_call_count(sbi, FOREGROUND); >> err = f2fs_gc(sbi, &gc_control); >> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c >> index 57adeff5ef25..48b97a95fd63 100644 >> --- a/fs/f2fs/super.c >> +++ b/fs/f2fs/super.c >> @@ -4975,6 +4975,9 @@ static int f2fs_fill_super(struct super_block *sb, struct fs_context *fc) >> sbi->last_valid_block_count = sbi->total_valid_block_count; >> sbi->reserved_blocks = 0; >> sbi->current_reserved_blocks = 0; >> + sbi->reserved_pin_section = f2fs_sb_has_blkzoned(sbi) ? >> + ZONED_PIN_SEC_REQUIRED_COUNT : >> + GET_SEC_FROM_SEG(sbi, overprovision_segments(sbi)); >> limit_reserve_root(sbi); >> adjust_unusable_cap_perc(sbi); > > Hi Chao, > It seems like we cannot use overprovision_segments(sbi) directly before f2fs_build_segment_manager(). Oops, ovp_segments is in f2fs_sm_info, I missed that, let me fix in v2. Thanks, > >> diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c >> index 75134d69a0bd..51be7ffb38c5 100644 >> --- a/fs/f2fs/sysfs.c >> +++ b/fs/f2fs/sysfs.c >> @@ -824,6 +824,13 @@ static ssize_t __sbi_store(struct f2fs_attr *a, >> return count; >> } >> >> + if (!strcmp(a->attr.name, "reserved_pin_section")) { >> + if (t > GET_SEC_FROM_SEG(sbi, overprovision_segments(sbi))) >> + return -EINVAL; >> + *ui = (unsigned int)t; >> + return count; >> + } >> + >> *ui = (unsigned int)t; >> >> return count; >> @@ -1130,6 +1137,7 @@ F2FS_SBI_GENERAL_RO_ATTR(unusable_blocks_per_sec); >> F2FS_SBI_GENERAL_RW_ATTR(blkzone_alloc_policy); >> #endif >> F2FS_SBI_GENERAL_RW_ATTR(carve_out); >> +F2FS_SBI_GENERAL_RW_ATTR(reserved_pin_section); >> >> /* STAT_INFO ATTR */ >> #ifdef CONFIG_F2FS_STAT_FS >> @@ -1323,6 +1331,7 @@ static struct attribute *f2fs_attrs[] = { >> ATTR_LIST(last_age_weight), >> ATTR_LIST(max_read_extent_count), >> ATTR_LIST(carve_out), >> + ATTR_LIST(reserved_pin_section), >> NULL, >> }; >> ATTRIBUTE_GROUPS(f2fs); >> -- >> 2.40.1 >> >> >> >> _______________________________________________ >> Linux-f2fs-devel mailing list >> Linux-f2fs-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel >