From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D507A3537D0 for ; Thu, 23 Apr 2026 12:39:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776947952; cv=none; b=EbRl8wlm0J1Ru0P70frKoOZfPg6a1RR2cLXkSmP3maa+9SXaGqmQV4M3w6SMqN5eOVll40tYyo1gwSdZXv0taHTGGCWkA3JnVSCvaH7QrSn03lbdTa7Yw3/PUNt1vstK77NMDDnFIJE+5bvWKB+Q17wwA/HstGhDDvocd0YBcvQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776947952; c=relaxed/simple; bh=+PJtUnUqMtakfpoukgNG6m5r2Kukgd+onZ0KysLCIY4=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=KWzHNpBCtxkGQWt6ac0EMzyTuwarxQj4ibrCh4O1XLF+cyJ+2fj+SV0cg19urdtKm5wAcbiJi6S8GFdZTEnX5Yma8RbimCSIkAWBueZesUcEiAUIuDe/6p0TMZVG4SrNxYqwUiVYE2b/lKZaCxRjfgafRP+d+txY6CW2TCdNrH0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XKtjlTrn; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XKtjlTrn" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2b2429f98d0so38710555ad.2 for ; Thu, 23 Apr 2026 05:39:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776947950; x=1777552750; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=+PJtUnUqMtakfpoukgNG6m5r2Kukgd+onZ0KysLCIY4=; b=XKtjlTrnsNFk9qC8X4h046n56xZMNW8P+PeaXDazHE7N2XtW378qZBn5pzzaDJeDXS 7WL/zR7RGF4LsQenGqK/Q/7rGA2K3DjvmJ1w8qi+3Pipv6K/1Qb9iAHJnjUOArpACmXf gKFlUk0bZSH0S//2GCL/dQ/kI8Ml0FxgitVcFRGNdOcwuEJq/1hzAcOCIA+ouXIDu8ru dL2rq2q6aNIfblVkL3Kn5vmzRvcZq9GYU6TqaVyta9saSDIK8jZJMIdRaKDRlmo6K6pE o3JTHO9k1TlL89Ss3VrcNY7jsfYRbqBbr2cv+fLAoKdXNtB4a3y8mFY7hMRJzE6busAj sM5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776947950; x=1777552750; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+PJtUnUqMtakfpoukgNG6m5r2Kukgd+onZ0KysLCIY4=; b=Ym7tfizlDSEKxd01C11KwTFn9jKQWfikAOy4+1cvfI6G3mrFTpZbA/8XHXqc5CUX0L 2YcR4yIpq9clO5pnGlvReZN1kcXN72B32TjqeMI0pPWfet2VBF6ccCDbtTCiIj4wIK2F 92kPZOqd2a9LZgWS9ptj3Eiu1nOvCymC9YYUoA2i6/PhLHU7C3auK0HwGe43N0/SpLUl nOkCPXVD9DWHgE8dFVrH2mKnNgrq/SJz1OiStj1RXTOj9LnC8/X7GU34tBBNAglpsEIU jg/nUz7q57XZxoGFTaXIIcotb8VnNEomLsfU/lyVyJf0i5rxXCt03N2lyyA8ZXynp9o3 GNdQ== X-Forwarded-Encrypted: i=1; AFNElJ9duUtV3RglC8ocbZ5Cug8ruyxf1RPP11Uttri1zfimi86I2wInxNTwPH+8d3WPN3F1qsnzAUC0nzYpcek=@vger.kernel.org X-Gm-Message-State: AOJu0Yyx9IZ05T9L7EF59i7zj3UAqJn802izd8QgI9FYcKiJkRqL3IWD 05Jzp49vXnLuxGOTs55q7HMFRpL6BfKHlWkR7ofRMlpM/3OZsue3VOp7 X-Gm-Gg: AeBDievV7G4vYtzVsVKflo5rl1JzVx/dhTpvBzbJQFHrjPFp0HuCMK/Ywx9Jt8MEkzP OZtNuEDttDU9GSChQWjo3DdK+obKf5RGpCCecs8qowpOE8YSGBIDd9YxbbquwQy09LRnTl9NCUe 8/ikez1rqrGjNtMmDMLM1NjaplRCn4JzMLFQns7wespMeO+5HEMhStw3vyEEppzjeV5Lgj10/IV Imoktu3Y6jTfKALpyp88qIMQ6WabwefhvqMDt9WWlnsX6yEuXi8Z3uqye1k0kjh24dNrJW2Emkq ltXRR0Za+bSLJF3stkqQQx7+DnJImOdF+UCdYM6j/sN7kh1AZ9YK+Ktafm52o43z0o0es0yk/vw GbM2nC36SjHeI8Q23jz85wf3qeOSl2w0Rb1FxiYWSvfrqvULaV9q1gBCOTMaDy281W85oMOrL8v J+8LF6dF9XWWyFS18qQtBGBff41xsxUPrafjZkeg== X-Received: by 2002:a17:903:17c5:b0:2b7:a08d:9e42 with SMTP id d9443c01a7336-2b7a08d9f73mr34404275ad.32.1776947950067; Thu, 23 Apr 2026 05:39:10 -0700 (PDT) Received: from [192.168.1.12] ([223.185.43.14]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab20c4fsm243138035ad.59.2026.04.23.05.39.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 05:39:08 -0700 (PDT) Message-ID: Subject: Re: [PATCH v2] mptcp: do not drop partial packets From: Shardul Bankar To: Matthieu Baerts , pabeni@redhat.com, martineau@kernel.org Cc: geliang@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, horms@kernel.org, netdev@vger.kernel.org, mptcp@lists.linux.dev, linux-kernel@vger.kernel.org, janak@mpiric.us, kalpan.jani@mpiricsoftware.com Date: Thu, 23 Apr 2026 18:09:03 +0530 In-Reply-To: <88096a1b-0c16-40ae-a03a-0d0d7f1702a4@kernel.org> References: <20260422143931.43281-1-shardul.b@mpiricsoftware.com> <88096a1b-0c16-40ae-a03a-0d0d7f1702a4@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu2.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2026-04-22 at 19:03 +0200, Matthieu Baerts wrote: > Hi Shardul, >=20 > On 22/04/2026 16:39, Shardul Bankar wrote: > >=20 >=20 > Thank you for the v2. >=20 > I didn't review it (yet), but just to let you know that there are > some > rules on Netdev [1] (that usually also applied on MPTCP side), and an > important one is: >=20 > =C2=A0- don't repost your patches within one 24h period >=20 > Each version generates a lot of emails that are sent and need to be > triaged. With the high volume, it is then harder for us to follow, > plus > a lot of shared resources are used, etc. >=20 > One last thing, because this patch is not an urgent fix, do you mind > sending new versions only the to MPTCP ML: to a restricted number of > people for the first versions, there is enough traffic on Netdev. >=20 > [1] https://docs.kernel.org/process/maintainer-netdev.html >=20 > > A previous attempt at this fix (commit 1d2ce718811a ("mptcp: do not > > drop partial packets"), reverted in commit bf39160c4218 ("Revert >=20 > Note: these two commits should not be mentioned here, they have only > been applied to the MPTCP tree, but not upstreamed. Instead, please > use > lore links, e.g. >=20 > https://lore.kernel.org/c9b426a4e163aa3c4fe8b80c79f1a610f47ae7d8.17630750= 56.git.pabeni@redhat.com >=20 > > "mptcp: do not drop partial packets"")) also added a zero-window > > check and changed rcv_wnd_sent initialization, which caused test > > regressions.=C2=A0 This version addresses only the partial packet > > handling > > without modifying receive window accounting. > >=20 > > Fixes: ab174ad8ef76 ("mptcp: move ooo skbs into msk out of order > > queue.") > > Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/600 > > Signed-off-by: Shardul Bankar >=20 > Checkpatch is complaining that the author of the patch is not the > same > as the one who sent the patch; You probably need to run this command > to > fix it: >=20 > =C2=A0 git commit --amend --reset-author >=20 > (when the patch is sent, `git format-patch` will add a second From: > tag) >=20 > Cheers, > Matt Hi Matthieu, Thanks for the pointers. I'll wait for your code review and address the process feedback (recipient list, commit message, email mismatch) along with any code comments together in v3. Regards, Shardul