public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@inria.fr>,
	Wen Yang <wenyang@linux.alibaba.com>,
	cocci@systeme.lip6.fr
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Gilles Muller" <Gilles.Muller@lip6.fr>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Masahiro Yamada" <yamada.masahiro@socionext.com>,
	"Matthias Männich" <maennich@google.com>,
	"Michal Marek" <michal.lkml@markovi.net>,
	"Nicolas Palix" <nicolas.palix@imag.fr>,
	"Thomas Gleixner" <tglx@linutronix.de>
Subject: Re: [v3] coccinelle: semantic patch to check for inappropriate do_div() calls
Date: Sat, 11 Jan 2020 09:03:49 +0100	[thread overview]
Message-ID: <c64b6f61-f523-dc8a-2abc-b0e9a8cd2d98@web.de> (raw)
In-Reply-To: <alpine.DEB.2.21.2001110841140.2965@hadrien>

>> Can the avoidance of duplicate source code (according to SmPL disjunctions)
>> trigger positive effects on run time characteristics and software maintenance?
>
> Markus.  Please stop asking this question.

This will not happen for a while.


> You are bothering people with this advice,

I present just another view.


> why don't _you_ figure out once and for all whether the change
> that you suggest has any "positive effects on the run time characteristics"?
> Hint: it will not.

* How much attention do you give to the software development principle
  "Don't repeat yourself"?

* Can the file size of a SmPL script matter a bit?


> Coccinelle has a pass that propagates disjunctions at the sub-statement level
> to the statement level.

This data processing can probably trigger further development considerations.

Regards,
Markus

  reply	other threads:[~2020-01-11  8:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-10 13:15 [PATCH v3] coccinelle: semantic patch to check for inappropriate do_div() calls Wen Yang
2020-01-10 16:35 ` Markus Elfring
2020-01-11  5:06   ` Wen Yang
2020-01-11  7:30     ` [v3] " Markus Elfring
2020-01-11  7:44       ` Julia Lawall
2020-01-11  8:03         ` Markus Elfring [this message]
2020-01-11 15:36 ` [PATCH v3] " Julia Lawall
2020-01-12  8:30 ` Markus Elfring
2020-01-12  8:42   ` Julia Lawall
2020-01-12  8:49     ` [v3] " Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c64b6f61-f523-dc8a-2abc-b0e9a8cd2d98@web.de \
    --to=markus.elfring@web.de \
    --cc=Gilles.Muller@lip6.fr \
    --cc=cocci@systeme.lip6.fr \
    --cc=gregkh@linuxfoundation.org \
    --cc=julia.lawall@inria.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maennich@google.com \
    --cc=michal.lkml@markovi.net \
    --cc=nicolas.palix@imag.fr \
    --cc=tglx@linutronix.de \
    --cc=wenyang@linux.alibaba.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox