From: Shuah Khan <shuah@kernel.org>
To: Luis de Bethencourt <luisbg@kernel.org>, linux-kernel@vger.kernel.org
Cc: linux-kselftest@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Kate Stewart <kstewart@linuxfoundation.org>,
Joe Perches <joe@perches.com>,
Shuah Khan <shuahkh@osg.samsung.com>,
Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] tools/testing: Fix trailing semicolon
Date: Thu, 11 Jan 2018 10:21:04 -0700 [thread overview]
Message-ID: <c65087f8-d447-d603-be0a-a0577081570b@kernel.org> (raw)
In-Reply-To: <20180111134607.12821-1-luisbg@kernel.org>
On 01/11/2018 06:46 AM, Luis de Bethencourt wrote:
> The trailing semicolon is an empty statement that does no operation.
> Removing it since it doesn't do anything.
>
> Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
> ---
>
> Hi Shuah,
>
> After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
> suggested I fix it treewide [0].
>
> Best regards :)
> Luis
>
>
> [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
> [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
>
> tools/testing/selftests/nsfs/pidns.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/nsfs/pidns.c b/tools/testing/selftests/nsfs/pidns.c
> index 1182d4e437a2..e0d86e1668c0 100644
> --- a/tools/testing/selftests/nsfs/pidns.c
> +++ b/tools/testing/selftests/nsfs/pidns.c
> @@ -70,7 +70,7 @@ int main(int argc, char *argv[])
> return pr_err("NS_GET_PARENT returned a wrong namespace");
>
> if (ioctl(pns, NS_GET_PARENT) >= 0 || errno != EPERM)
> - return pr_err("Don't get EPERM");;
> + return pr_err("Don't get EPERM");
> }
>
> kill(pid, SIGKILL);
>
Thanks for the patch. I will take this in for 4.16-rc1.
thanks,
-- Shuah
next prev parent reply other threads:[~2018-01-11 17:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 13:46 [PATCH] tools/testing: Fix trailing semicolon Luis de Bethencourt
2018-01-11 17:21 ` Shuah Khan [this message]
2018-01-11 18:03 ` Luis de Bethencourt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c65087f8-d447-d603-be0a-a0577081570b@kernel.org \
--to=shuah@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luisbg@kernel.org \
--cc=shuahkh@osg.samsung.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox