From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jammy Huang <jammy_huang@aspeedtech.com>,
eajames@linux.ibm.com, mchehab@kernel.org, joel@jms.id.au,
andrew@aj.id.au, pmenzel@molgen.mpg.de
Cc: linux-media@vger.kernel.org, openbmc@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] ARM: dts: aspeed: Add properties of scu and gfx for video
Date: Wed, 14 Aug 2024 08:07:56 +0200 [thread overview]
Message-ID: <c66a45ca-a526-4865-840e-2fce108eab91@kernel.org> (raw)
In-Reply-To: <20240814005421.3362441-2-jammy_huang@aspeedtech.com>
On 14/08/2024 02:54, Jammy Huang wrote:
> To have video support capture from SoC display(GFX), these properties
> are added to allow video to control related registers.
>
> Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com>
> ---
> arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
NAK, you still keep adding undocumented properties. I commented already
that you did not document the bindings for new properties. I also said
what you need to do, so why doing something entirely else?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-14 6:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 0:54 [PATCH v4 0/2] media: aspeed: Allow to capture from SoC display (GFX) Jammy Huang
2024-08-14 0:54 ` [PATCH v4 1/2] ARM: dts: aspeed: Add properties of scu and gfx for video Jammy Huang
2024-08-14 6:07 ` Krzysztof Kozlowski [this message]
2024-08-14 0:54 ` [PATCH v4 2/2] media: aspeed: Allow to capture from SoC display (GFX) Jammy Huang
2024-08-14 6:09 ` Krzysztof Kozlowski
2024-08-16 2:31 ` Jammy Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c66a45ca-a526-4865-840e-2fce108eab91@kernel.org \
--to=krzk@kernel.org \
--cc=andrew@aj.id.au \
--cc=eajames@linux.ibm.com \
--cc=jammy_huang@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox