linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Zhang, Rui" <rui.zhang@intel.com>
To: "srinivas.pandruvada@linux.intel.com"
	<srinivas.pandruvada@linux.intel.com>,
	"lukasz.luba@arm.com" <lukasz.luba@arm.com>,
	"rafael@kernel.org" <rafael@kernel.org>,
	"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] thermal: intel: int340x: Add performance control for platform temperature control
Date: Fri, 6 Jun 2025 07:34:42 +0000	[thread overview]
Message-ID: <c672a842ba17a69ed1e080549e0066d50303c2cb.camel@intel.com> (raw)
In-Reply-To: <5a0dc3858c802a5d6247424529377c6dbfd450ca.camel@linux.intel.com>

On Thu, 2025-06-05 at 10:25 -0700, srinivas pandruvada wrote:
> On Thu, 2025-06-05 at 03:06 +0000, Zhang, Rui wrote:
> > On Wed, 2025-06-04 at 13:35 -0700, Srinivas Pandruvada wrote:
> > > Add additional attribute to control performance of platform
> > > temperature
> > > control feature. Two attributes are added:
> > > 
> > > gain: 0-7 levels, with 0 being most aggressive.
> > > 	7 – graceful, favors performance at the expense of
> > > temperature
> > > 	overshoots
> > > 	0 – aggressive, favors tight regulation over performance
> > 
> > By reading this, I know that setting "pts_0_control/gain" to a larger
> > value means less aggressive ptc control.
> > 
> > But what does "gain" mean here?
> This is the input to the algorithm on how much performance gain is
> allowed to be in acceptable range for trip violation. May be call
> performance levels instead. I am using the same term as in the spec.

So "graceful" and "aggressive" refers to the temperature control, and
"gain" refers to the performance.

Thanks for clarifying.

-rui

> 
> Thanks,
> Srinivas
> 
> > 
> > May be my English problem, I'm trying hard to understand this, but it
> > is
> > still a bit confusing to me.
> > 
> > thanks,
> > rui


      reply	other threads:[~2025-06-06  7:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-04 20:35 [PATCH 1/2] thermal: intel: int340x: Add performance control for platform temperature control Srinivas Pandruvada
2025-06-04 20:35 ` [PATCH 2/2] thermal: intel: int340x: Allow temperature override Srinivas Pandruvada
2025-06-05  2:18   ` Zhang, Rui
2025-06-05 17:20     ` srinivas pandruvada
2025-06-06  7:22       ` Zhang, Rui
2025-06-06 21:19         ` srinivas pandruvada
2025-06-04 20:55 ` [PATCH 1/2] thermal: intel: int340x: Add performance control for platform temperature control Rafael J. Wysocki
2025-06-04 21:40   ` srinivas pandruvada
2025-06-05  3:06 ` Zhang, Rui
2025-06-05 17:25   ` srinivas pandruvada
2025-06-06  7:34     ` Zhang, Rui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c672a842ba17a69ed1e080549e0066d50303c2cb.camel@intel.com \
    --to=rui.zhang@intel.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=rafael@kernel.org \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).