From: Can Guo <cang@codeaurora.org>
To: daejun7.park@samsung.com
Cc: Greg KH <gregkh@linuxfoundation.org>,
avri.altman@wdc.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, asutoshd@codeaurora.org,
stanley.chu@mediatek.com, bvanassche@acm.org, huobean@gmail.com,
ALIM AKHTAR <alim.akhtar@samsung.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Sung-Jun Park <sungjun07.park@samsung.com>,
yongmyung lee <ymhungry.lee@samsung.com>,
Jinyoung CHOI <j-young.choi@samsung.com>,
Adel Choi <adel.choi@samsung.com>,
BoRam Shin <boram.shin@samsung.com>,
SEUNGUK SHIN <seunguk.shin@samsung.com>
Subject: Re: [PATCH v18 3/3] scsi: ufs: Prepare HPB read for cached sub-region
Date: Thu, 14 Jan 2021 12:09:08 +0800 [thread overview]
Message-ID: <c6a4e4abd856aa03b6b91b619cddbeb7@codeaurora.org> (raw)
In-Reply-To: <20210113013633epcms2p60b9dccaa405ff568a18d28b94089665b@epcms2p6>
Hi Daejun,
On 2021-01-13 09:36, Daejun Park wrote:
> Hi Can Guo,
>
>> > +static void
>> > +ufshpb_set_hpb_read_to_upiu(struct ufshpb_lu *hpb, struct ufshcd_lrb
>> > *lrbp,
>> > + u32 lpn, u64 ppn, unsigned int transfer_len)
>> > +{
>> > + unsigned char *cdb = lrbp->ucd_req_ptr->sc.cdb;
>> > +
>> > + cdb[0] = UFSHPB_READ;
>>
>> You are only replacing opcode in cdb[0], but
>> ufshcd_add_command_trace()
>> is
>> counting on lrbp->cmd->cmnd. This will lead to wrong opcode recorded
>> by
>> UFS ftrace.
>>
> You're comment is good point for improving this patch. But there is no
> "case" for HPB read (0xF8) in ufshcd_add_command_trace().
> So I will add codes to support tracing HPB read command in
> ufshcd_add_command_trace() on next patch.
>
It is not just about ftrace. If HPB READ cmd fails with sense key infos.
When SCSI layer prints the cmd, it still prints the READ(10) CDB, which
is
misleading.
Thanks,
Can Guo.
> Thanks,
> Daejun
next prev parent reply other threads:[~2021-01-14 4:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201222015704epcms2p643f0c5011064a7ce56b08331811a8509@epcms2p6>
2020-12-22 1:57 ` [PATCH v18 0/3] scsi: ufs: Add Host Performance Booster Support Daejun Park
2020-12-22 1:57 ` [PATCH v18 1/3] scsi: ufs: Introduce HPB feature Daejun Park
2020-12-22 1:58 ` [PATCH v18 2/3] scsi: ufs: L2P map management for HPB read Daejun Park
2020-12-22 1:58 ` [PATCH v18 3/3] scsi: ufs: Prepare HPB read for cached sub-region Daejun Park
2021-01-11 4:10 ` Can Guo
2021-01-13 1:36 ` Daejun Park
2021-01-14 4:09 ` Can Guo [this message]
2021-01-15 7:59 ` Daejun Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6a4e4abd856aa03b6b91b619cddbeb7@codeaurora.org \
--to=cang@codeaurora.org \
--cc=adel.choi@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=boram.shin@samsung.com \
--cc=bvanassche@acm.org \
--cc=daejun7.park@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=huobean@gmail.com \
--cc=j-young.choi@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=seunguk.shin@samsung.com \
--cc=stanley.chu@mediatek.com \
--cc=sungjun07.park@samsung.com \
--cc=ymhungry.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox