[PATCH] acpi: Provide decls for standalone compilation of video.h without ACPI

[PATCH] acpi: Provide decls for standalone compilation of video.h without ACPI

[Chris Wilson]

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Len Brown <len.brown@intel.com>
---
 include/acpi/video.h |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/include/acpi/video.h b/include/acpi/video.h
index 551793c..bcb4f00 100644
--- a/include/acpi/video.h
+++ b/include/acpi/video.h
@@ -16,6 +16,10 @@ extern void acpi_video_unregister(void);
 extern int acpi_video_get_edid(struct acpi_device *device, int type,
 			       int device_id, void **edid);
 #else
+
+#include <linux/errno.h> /* for ENODEV */
+struct acpi_device;
+
 static inline int acpi_video_register(void) { return 0; }
 static inline void acpi_video_unregister(void) { return; }
 static inline int acpi_video_get_edid(struct acpi_device *device, int type,
@@ -26,4 +30,3 @@ static inline int acpi_video_get_edid(struct acpi_device *device, int type,
 #endif
 
 #endif
-
-- 
1.7.1

[PATCH] acpi: Provide decls for standalone compilation of video.h without ACPI (v2)

[Chris Wilson]

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Len Brown <len.brown@intel.com>
---
 include/acpi/video.h |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/include/acpi/video.h b/include/acpi/video.h
index 551793c..0e98e67 100644
--- a/include/acpi/video.h
+++ b/include/acpi/video.h
@@ -1,6 +1,10 @@
 #ifndef __ACPI_VIDEO_H
 #define __ACPI_VIDEO_H
 
+#include <linux/errno.h> /* for ENODEV */
+
+struct acpi_device;
+
 #define ACPI_VIDEO_DISPLAY_CRT  1
 #define ACPI_VIDEO_DISPLAY_TV   2
 #define ACPI_VIDEO_DISPLAY_DVI  3
@@ -26,4 +30,3 @@ static inline int acpi_video_get_edid(struct acpi_device *device, int type,
 #endif
 
 #endif
-
-- 
1.7.1

Re: [PATCH] acpi: Provide decls for standalone compilation of video.h without ACPI (v2)

[Chris Wilson]

On Sun,  5 Sep 2010 14:51:49 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matthew Garrett <mjg@redhat.com>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Len Brown <len.brown@intel.com>

Can one of you please pick up this patch and apply to acpi?

Thanks,
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

Re: [PATCH] acpi: Provide decls for standalone compilation of video.h without ACPI (v2)

[Rafael J. Wysocki]

On Wednesday, November 10, 2010, Chris Wilson wrote:
> On Sun,  5 Sep 2010 14:51:49 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Matthew Garrett <mjg@redhat.com>
> > Cc: Zhang Rui <rui.zhang@intel.com>
> > Cc: Len Brown <len.brown@intel.com>
> 
> Can one of you please pick up this patch and apply to acpi?

A link would help I guess.

Thanks,
Rafael

Re: [PATCH] acpi: Provide decls for standalone compilation of video.h without ACPI (v2)

[Zhang Rui]

On Sun, 2010-09-05 at 21:51 +0800, Chris Wilson wrote:
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matthew Garrett <mjg@redhat.com>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Len Brown <len.brown@intel.com>

Acked-by: Zhang Rui <rui.zhang@intel.com>

> ---
>  include/acpi/video.h |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/include/acpi/video.h b/include/acpi/video.h
> index 551793c..0e98e67 100644
> --- a/include/acpi/video.h
> +++ b/include/acpi/video.h
> @@ -1,6 +1,10 @@
>  #ifndef __ACPI_VIDEO_H
>  #define __ACPI_VIDEO_H
>  
> +#include <linux/errno.h> /* for ENODEV */
> +
> +struct acpi_device;
> +
>  #define ACPI_VIDEO_DISPLAY_CRT  1
>  #define ACPI_VIDEO_DISPLAY_TV   2
>  #define ACPI_VIDEO_DISPLAY_DVI  3
> @@ -26,4 +30,3 @@ static inline int acpi_video_get_edid(struct acpi_device *device, int type,
>  #endif
>  
>  #endif
> -

Re: [PATCH] acpi: Provide decls for standalone compilation of video.h without ACPI (v2)

[Zhang Rui]

On Fri, 2010-11-12 at 09:12 +0800, Zhang Rui wrote:
> On Sun, 2010-09-05 at 21:51 +0800, Chris Wilson wrote:
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Matthew Garrett <mjg@redhat.com>
> > Cc: Zhang Rui <rui.zhang@intel.com>
> > Cc: Len Brown <len.brown@intel.com>
> 
> Acked-by: Zhang Rui <rui.zhang@intel.com>
> 
> > ---
> >  include/acpi/video.h |    5 ++++-
> >  1 files changed, 4 insertions(+), 1 deletions(-)
> > 
> > diff --git a/include/acpi/video.h b/include/acpi/video.h
> > index 551793c..0e98e67 100644
> > --- a/include/acpi/video.h
> > +++ b/include/acpi/video.h
> > @@ -1,6 +1,10 @@
> >  #ifndef __ACPI_VIDEO_H
> >  #define __ACPI_VIDEO_H
> >  
> > +#include <linux/errno.h> /* for ENODEV */
> > +
> > +struct acpi_device;
> > +
Oh, btw, this line is actually not needed,
because acpi_video_get_edid is not invoked in any place when CONFIG_ACPI
is cleared.

> >  #define ACPI_VIDEO_DISPLAY_CRT  1
> >  #define ACPI_VIDEO_DISPLAY_TV   2
> >  #define ACPI_VIDEO_DISPLAY_DVI  3
> > @@ -26,4 +30,3 @@ static inline int acpi_video_get_edid(struct acpi_device *device, int type,
> >  #endif
> >  
> >  #endif
> > -
> 

Re: [PATCH] acpi: Provide decls for standalone compilation of video.h without ACPI (v2)

[Len Brown]

applied

thanks,
Len Brown, Intel Open Source Technology Center