* [PATCH] acpi: Provide decls for standalone compilation of video.h without ACPI
@ 2010-09-05 13:35 Chris Wilson
2010-09-05 13:51 ` [PATCH] acpi: Provide decls for standalone compilation of video.h without ACPI (v2) Chris Wilson
0 siblings, 1 reply; 7+ messages in thread
From: Chris Wilson @ 2010-09-05 13:35 UTC (permalink / raw)
To: linux-kernel; +Cc: Chris Wilson, Matthew Garrett, Zhang Rui, Len Brown
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Len Brown <len.brown@intel.com>
---
include/acpi/video.h | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/include/acpi/video.h b/include/acpi/video.h
index 551793c..bcb4f00 100644
--- a/include/acpi/video.h
+++ b/include/acpi/video.h
@@ -16,6 +16,10 @@ extern void acpi_video_unregister(void);
extern int acpi_video_get_edid(struct acpi_device *device, int type,
int device_id, void **edid);
#else
+
+#include <linux/errno.h> /* for ENODEV */
+struct acpi_device;
+
static inline int acpi_video_register(void) { return 0; }
static inline void acpi_video_unregister(void) { return; }
static inline int acpi_video_get_edid(struct acpi_device *device, int type,
@@ -26,4 +30,3 @@ static inline int acpi_video_get_edid(struct acpi_device *device, int type,
#endif
#endif
-
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] acpi: Provide decls for standalone compilation of video.h without ACPI (v2)
2010-09-05 13:35 [PATCH] acpi: Provide decls for standalone compilation of video.h without ACPI Chris Wilson
@ 2010-09-05 13:51 ` Chris Wilson
2010-11-10 12:08 ` Chris Wilson
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Chris Wilson @ 2010-09-05 13:51 UTC (permalink / raw)
To: linux-kernel; +Cc: Chris Wilson, Matthew Garrett, Zhang Rui, Len Brown
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Len Brown <len.brown@intel.com>
---
include/acpi/video.h | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/include/acpi/video.h b/include/acpi/video.h
index 551793c..0e98e67 100644
--- a/include/acpi/video.h
+++ b/include/acpi/video.h
@@ -1,6 +1,10 @@
#ifndef __ACPI_VIDEO_H
#define __ACPI_VIDEO_H
+#include <linux/errno.h> /* for ENODEV */
+
+struct acpi_device;
+
#define ACPI_VIDEO_DISPLAY_CRT 1
#define ACPI_VIDEO_DISPLAY_TV 2
#define ACPI_VIDEO_DISPLAY_DVI 3
@@ -26,4 +30,3 @@ static inline int acpi_video_get_edid(struct acpi_device *device, int type,
#endif
#endif
-
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] acpi: Provide decls for standalone compilation of video.h without ACPI (v2)
2010-09-05 13:51 ` [PATCH] acpi: Provide decls for standalone compilation of video.h without ACPI (v2) Chris Wilson
@ 2010-11-10 12:08 ` Chris Wilson
2010-11-10 20:33 ` Rafael J. Wysocki
2010-11-12 1:12 ` Zhang Rui
2010-11-30 23:52 ` Len Brown
2 siblings, 1 reply; 7+ messages in thread
From: Chris Wilson @ 2010-11-10 12:08 UTC (permalink / raw)
To: linux-kernel; +Cc: Matthew Garrett, Zhang Rui, Len Brown
On Sun, 5 Sep 2010 14:51:49 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matthew Garrett <mjg@redhat.com>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Len Brown <len.brown@intel.com>
Can one of you please pick up this patch and apply to acpi?
Thanks,
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] acpi: Provide decls for standalone compilation of video.h without ACPI (v2)
2010-11-10 12:08 ` Chris Wilson
@ 2010-11-10 20:33 ` Rafael J. Wysocki
0 siblings, 0 replies; 7+ messages in thread
From: Rafael J. Wysocki @ 2010-11-10 20:33 UTC (permalink / raw)
To: Chris Wilson
Cc: linux-kernel, Matthew Garrett, Zhang Rui, Len Brown,
ACPI Devel Maling List, Len Brown
On Wednesday, November 10, 2010, Chris Wilson wrote:
> On Sun, 5 Sep 2010 14:51:49 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Matthew Garrett <mjg@redhat.com>
> > Cc: Zhang Rui <rui.zhang@intel.com>
> > Cc: Len Brown <len.brown@intel.com>
>
> Can one of you please pick up this patch and apply to acpi?
A link would help I guess.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] acpi: Provide decls for standalone compilation of video.h without ACPI (v2)
2010-09-05 13:51 ` [PATCH] acpi: Provide decls for standalone compilation of video.h without ACPI (v2) Chris Wilson
2010-11-10 12:08 ` Chris Wilson
@ 2010-11-12 1:12 ` Zhang Rui
2010-11-12 2:57 ` Zhang Rui
2010-11-30 23:52 ` Len Brown
2 siblings, 1 reply; 7+ messages in thread
From: Zhang Rui @ 2010-11-12 1:12 UTC (permalink / raw)
To: Chris Wilson; +Cc: linux-kernel@vger.kernel.org, Matthew Garrett, Brown, Len
On Sun, 2010-09-05 at 21:51 +0800, Chris Wilson wrote:
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matthew Garrett <mjg@redhat.com>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Len Brown <len.brown@intel.com>
Acked-by: Zhang Rui <rui.zhang@intel.com>
> ---
> include/acpi/video.h | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/include/acpi/video.h b/include/acpi/video.h
> index 551793c..0e98e67 100644
> --- a/include/acpi/video.h
> +++ b/include/acpi/video.h
> @@ -1,6 +1,10 @@
> #ifndef __ACPI_VIDEO_H
> #define __ACPI_VIDEO_H
>
> +#include <linux/errno.h> /* for ENODEV */
> +
> +struct acpi_device;
> +
> #define ACPI_VIDEO_DISPLAY_CRT 1
> #define ACPI_VIDEO_DISPLAY_TV 2
> #define ACPI_VIDEO_DISPLAY_DVI 3
> @@ -26,4 +30,3 @@ static inline int acpi_video_get_edid(struct acpi_device *device, int type,
> #endif
>
> #endif
> -
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] acpi: Provide decls for standalone compilation of video.h without ACPI (v2)
2010-11-12 1:12 ` Zhang Rui
@ 2010-11-12 2:57 ` Zhang Rui
0 siblings, 0 replies; 7+ messages in thread
From: Zhang Rui @ 2010-11-12 2:57 UTC (permalink / raw)
To: Chris Wilson; +Cc: linux-kernel@vger.kernel.org, Matthew Garrett, Brown, Len
On Fri, 2010-11-12 at 09:12 +0800, Zhang Rui wrote:
> On Sun, 2010-09-05 at 21:51 +0800, Chris Wilson wrote:
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Matthew Garrett <mjg@redhat.com>
> > Cc: Zhang Rui <rui.zhang@intel.com>
> > Cc: Len Brown <len.brown@intel.com>
>
> Acked-by: Zhang Rui <rui.zhang@intel.com>
>
> > ---
> > include/acpi/video.h | 5 ++++-
> > 1 files changed, 4 insertions(+), 1 deletions(-)
> >
> > diff --git a/include/acpi/video.h b/include/acpi/video.h
> > index 551793c..0e98e67 100644
> > --- a/include/acpi/video.h
> > +++ b/include/acpi/video.h
> > @@ -1,6 +1,10 @@
> > #ifndef __ACPI_VIDEO_H
> > #define __ACPI_VIDEO_H
> >
> > +#include <linux/errno.h> /* for ENODEV */
> > +
> > +struct acpi_device;
> > +
Oh, btw, this line is actually not needed,
because acpi_video_get_edid is not invoked in any place when CONFIG_ACPI
is cleared.
> > #define ACPI_VIDEO_DISPLAY_CRT 1
> > #define ACPI_VIDEO_DISPLAY_TV 2
> > #define ACPI_VIDEO_DISPLAY_DVI 3
> > @@ -26,4 +30,3 @@ static inline int acpi_video_get_edid(struct acpi_device *device, int type,
> > #endif
> >
> > #endif
> > -
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] acpi: Provide decls for standalone compilation of video.h without ACPI (v2)
2010-09-05 13:51 ` [PATCH] acpi: Provide decls for standalone compilation of video.h without ACPI (v2) Chris Wilson
2010-11-10 12:08 ` Chris Wilson
2010-11-12 1:12 ` Zhang Rui
@ 2010-11-30 23:52 ` Len Brown
2 siblings, 0 replies; 7+ messages in thread
From: Len Brown @ 2010-11-30 23:52 UTC (permalink / raw)
To: Chris Wilson; +Cc: linux-kernel, Matthew Garrett, Zhang Rui
applied
thanks,
Len Brown, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-11-30 23:52 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-05 13:35 [PATCH] acpi: Provide decls for standalone compilation of video.h without ACPI Chris Wilson
2010-09-05 13:51 ` [PATCH] acpi: Provide decls for standalone compilation of video.h without ACPI (v2) Chris Wilson
2010-11-10 12:08 ` Chris Wilson
2010-11-10 20:33 ` Rafael J. Wysocki
2010-11-12 1:12 ` Zhang Rui
2010-11-12 2:57 ` Zhang Rui
2010-11-30 23:52 ` Len Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox