From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 037623DA7F2 for ; Thu, 26 Feb 2026 14:50:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772117421; cv=none; b=oLwc9eocV38K1VoR4uucWv9oDqqaaaPmCwf/5Xw+KsG5RBqXE85+hQHr3IdH/EgzpLkE9xdsCvrNiQtFbP1aJx34z3H7XzpLqgboaUvyjHGnlHWpZideppr5DhL5CW1x0RoS9EnHUg0Oee6SVVZPd5RbugLPCJ/C+oCTEbm2eSA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772117421; c=relaxed/simple; bh=GK0sbKFuo5mAqtUMy66Ge5gunIW0qAF6CCoSBdhwHwk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=foI5AMh9pkXIYPlLaE+uwkaiku6cSJ8MJFhGiguC7Q9RSBJQ3HlFbf934etw52/BfFhFpuBTMQ9e3aYqcqSCqytUQU0AhMYQfhi8S8g6VjgoZnZ8D8BdpdcoMQHOPnMHOOmLfllVx40AGSx1XlIxz89+iMb4gFpJDQG+KUP/ei4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gI8JYFS2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gI8JYFS2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0113C116C6; Thu, 26 Feb 2026 14:50:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772117420; bh=GK0sbKFuo5mAqtUMy66Ge5gunIW0qAF6CCoSBdhwHwk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=gI8JYFS2gzn78RReEOysbVYUdkvhVolNIb88Nz/sQ4k0P+M9Kh0pzoGlrKOEXk0Le qywh9uBW+bX5Ca7aXe10/riYs9S6SARPpvtXzSQtBA7kzp1ITLSkbq3PiS/JOYaAKy ynC2rQ2U3WCOWY3BW+b23nF3kcp/AiGwI4FdImwVU1YtqeBfl/j/sB76MB/UnKHWMR wnrynwk3O1q4xo3AEfUHIP6lW6e0c382ET38WeJe06hqk+RmaHa998Ln/nZuydbmLE ISZITSNfw30nB9NVJoc18eA60gSHZy0J46dQAJM9pqyuUaMOxClG3q5+CQXhHUtSgV rs5V7pQNuWK2w== Message-ID: Date: Thu, 26 Feb 2026 15:50:16 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] slab: distinguish lock and trylock for sheaf_flush_main() Content-Language: en-US To: Harry Yoo Cc: Hao Li , Marcelo Tosatti , Andrew Morton , Christoph Lameter , David Rientjes , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260211-b4-sheaf-flush-v1-1-4e7f492f0055@suse.cz> From: "Vlastimil Babka (SUSE)" In-Reply-To: <20260211-b4-sheaf-flush-v1-1-4e7f492f0055@suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/11/26 10:42, Vlastimil Babka wrote: > sheaf_flush_main() can be called from __pcs_replace_full_main() where > the trylock can in theory fail, and pcs_flush_all() where it's not > expected to and it would be actually a problem if it failed and left the > main sheaf not flushed. Thinking about this more, I now think it's not a theoretical issue because on PREEMPT_RT I think pcs_flush_all() can preempt someone holding the lock (on PREEMPT_RT it doesn't have to be an irq handler preempting a holder), and then fail to flush the main sheaf silently. The impact is probably limited though - if this failure to flush happens in __kmem_cache_shutdown(), it means someone was destroying a cache while using it, so that was already buggy. slab_mem_going_offline_callback() could be where this matters although it's unlikely someone would do memory hotplug together with PREEMPT_RT. But maybe still worth tagging this as Fixes: 2d517aa09bbc ("slab: add opt-in caching layer of percpu sheaves") and Cc stable and sending it as a hotfix. > To make this explicit, split the function into sheaf_flush_main() (using > local_lock()) and sheaf_try_flush_main() (using local_trylock()) where > both call __sheaf_flush_main_batch() to flush a single batch of objects. > This will allow lockdep to verify our assumptions. > > Signed-off-by: Vlastimil Babka > --- > mm/slub.c | 47 +++++++++++++++++++++++++++++++++++++---------- > 1 file changed, 37 insertions(+), 10 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 18c30872d196..12912b29f5bb 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2844,19 +2844,19 @@ static void __kmem_cache_free_bulk(struct kmem_cache *s, size_t size, void **p); > * object pointers are moved to a on-stack array under the lock. To bound the > * stack usage, limit each batch to PCS_BATCH_MAX. > * > - * returns true if at least partially flushed > + * Must be called with s->cpu_sheaves->lock locked, returns with the lock > + * unlocked. > + * > + * Returns how many objects are remaining to be flushed > */ > -static bool sheaf_flush_main(struct kmem_cache *s) > +static unsigned int __sheaf_flush_main_batch(struct kmem_cache *s) > { > struct slub_percpu_sheaves *pcs; > unsigned int batch, remaining; > void *objects[PCS_BATCH_MAX]; > struct slab_sheaf *sheaf; > - bool ret = false; > > -next_batch: > - if (!local_trylock(&s->cpu_sheaves->lock)) > - return ret; > + lockdep_assert_held(this_cpu_ptr(&s->cpu_sheaves->lock)); > > pcs = this_cpu_ptr(s->cpu_sheaves); > sheaf = pcs->main; > @@ -2874,10 +2874,37 @@ static bool sheaf_flush_main(struct kmem_cache *s) > > stat_add(s, SHEAF_FLUSH, batch); > > - ret = true; > + return remaining; > +} > > - if (remaining) > - goto next_batch; > +static void sheaf_flush_main(struct kmem_cache *s) > +{ > + unsigned int remaining; > + > + do { > + local_lock(&s->cpu_sheaves->lock); > + > + remaining = __sheaf_flush_main_batch(s); > + > + } while (remaining); > +} > + > +/* > + * Returns true if the main sheaf was at least partially flushed. > + */ > +static bool sheaf_try_flush_main(struct kmem_cache *s) > +{ > + unsigned int remaining; > + bool ret = false; > + > + do { > + if (!local_trylock(&s->cpu_sheaves->lock)) > + return ret; > + > + ret = true; > + remaining = __sheaf_flush_main_batch(s); > + > + } while (remaining); > > return ret; > } > @@ -5685,7 +5712,7 @@ __pcs_replace_full_main(struct kmem_cache *s, struct slub_percpu_sheaves *pcs, > if (put_fail) > stat(s, BARN_PUT_FAIL); > > - if (!sheaf_flush_main(s)) > + if (!sheaf_try_flush_main(s)) > return NULL; > > if (!local_trylock(&s->cpu_sheaves->lock)) > > --- > base-commit: 27125df9a5d3b4cfd03bce3a8ec405a368cc9aae > change-id: 20260211-b4-sheaf-flush-2eb99a9c8bfb > > Best regards,