From: Marc Zyngier <maz@kernel.org>
To: Zou Cao <zoucao@linux.alibaba.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, tglx@linutronix.de,
jason@lakedaemon.net
Subject: Re: [PATCH] irqchip/gic-v3: change gic_data into gic_v3_data
Date: Thu, 03 Sep 2020 10:55:05 +0100 [thread overview]
Message-ID: <c6eacce9e0990239ee12bfc5826fe2c6@kernel.org> (raw)
In-Reply-To: <1599124088-80231-1-git-send-email-zoucao@linux.alibaba.com>
On 2020-09-03 10:08, Zou Cao wrote:
> There are multiple gic_data symbol between irq_gic.c and irq_gic_v3.c,
> we can see the same symbol name:
>
> cat /proc/kallsyms | grep gic_data
> ------>
> ffff80001138f1d0 d gic_data
> ffff80001138f940 d gic_data
>
> Normally CONFIG_ARM_GIC and CONFIG_ARM_GIC_V3 are all enabled, move
> the gic_data symbol into different name, it will be friend for
> kallsyms_lookup_name to get addr easily.
>
> Signed-off-by: Zou Cao <zoucao@linux.alibaba.com>
I'm sorry, but this kind of change is not acceptable.
It is pure churn, for zero benefit. As an example, give the following
script a go:
awk '{ print $3 }' /proc/kallsyms | sort | uniq -c| awk '$1 > 1
{print}'| sort -n
Are you going to repaint all these symbols?
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2020-09-03 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 9:08 [PATCH] irqchip/gic-v3: change gic_data into gic_v3_data Zou Cao
2020-09-03 9:55 ` Marc Zyngier [this message]
2020-09-03 10:05 ` zc
2020-09-03 10:12 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6eacce9e0990239ee12bfc5826fe2c6@kernel.org \
--to=maz@kernel.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=zoucao@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox