From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932928AbcLTAki (ORCPT ); Mon, 19 Dec 2016 19:40:38 -0500 Received: from mail-wj0-f175.google.com ([209.85.210.175]:35968 "EHLO mail-wj0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752117AbcLTAkg (ORCPT ); Mon, 19 Dec 2016 19:40:36 -0500 Subject: Re: [patch] nvme-fabrics: correct some printk information To: Dan Carpenter References: <20161210090618.GA11680@elgon.mountain> Cc: Keith Busch , Jens Axboe , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org From: James Smart Message-ID: Date: Mon, 19 Dec 2016 16:40:30 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20161210090618.GA11680@elgon.mountain> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dan, Mind if I solve this a different way ? I really don't know why knowing the ptr value is even meaningful -- james On 12/10/2016 1:06 AM, Dan Carpenter wrote: > We really don't care where "ctrl" is on the stack since we're just > returning soon what we want is the actual ctrl pointer itself. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c > index 771e2e761872..e6395ed2f562 100644 > --- a/drivers/nvme/host/fc.c > +++ b/drivers/nvme/host/fc.c > @@ -2402,7 +2402,7 @@ enum blk_eh_timer_return > > dev_info(ctrl->ctrl.device, > "NVME-FC{%d}: new ctrl: NQN \"%s\" (%p)\n", > - ctrl->cnum, ctrl->ctrl.opts->subsysnqn, &ctrl); > + ctrl->cnum, ctrl->ctrl.opts->subsysnqn, ctrl); > > kref_get(&ctrl->ctrl.kref); >