RE: [PATCH V2][4/4] mmc: Add dt-bindings for realtek mmc driver

["Jyan Chou [周芷安]" <jyanchou@realtek.com>]

Hi Krzysztof,

> Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching.
> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.

Thanks for your remind. We had modified our code and resend new patches.

> You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the > patch to be tested.
> Also, coding style of your example is messy.

It was our mistake that didn't check dt-bindings accurately. We had corrected it and resend to all necessary To/Cc entries. Thanks.

Best regards,
Jyan


-----Original Message-----
From: Krzysztof Kozlowski <krzk@kernel.org> 
Sent: Wednesday, October 18, 2023 10:25 PM
To: Jyan Chou [周芷安] <jyanchou@realtek.com>; adrian.hunter@intel.com; ulf.hansson@linaro.org; jh80.chung@samsung.com
Cc: linux-mmc@vger.kernel.org; linux-kernel@vger.kernel.org; benchuanggli@gmail.com
Subject: Re: [PATCH V2][4/4] mmc: Add dt-bindings for realtek mmc driver


External mail.



On 18/10/2023 07:53, Jyan Chou wrote:
> Document the device-tree bindings for Realtek SoCs mmc driver.
>
> Signed-off-by: Jyan Chou <jyanchou@realtek.com>

Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching.

Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.

You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries.

Also, coding style of your example is messy.

Best regards,
Krzysztof