From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAA21C25B70 for ; Thu, 26 Oct 2023 21:29:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344848AbjJZV3v (ORCPT ); Thu, 26 Oct 2023 17:29:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231977AbjJZV3t (ORCPT ); Thu, 26 Oct 2023 17:29:49 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56D86DC; Thu, 26 Oct 2023 14:29:47 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E515EC433C8; Thu, 26 Oct 2023 21:29:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698355787; bh=+YN2wOtRkIWdM84iVFF3QLRFT0RlayTMutqyrR645Ug=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=YigZCOfaYFjhOlTe0VXDV9sMkkTwtrgGZL7mV5vejHxUIMuz7sG3CWmWA1b05pFQM ZAzBHz2izg0P8TKDSS2cZxc6b7orMYYCnbIHdnquWwKa0UmlkiKBXixkaS7V0B7QpC 7GhrTOMQekPtI3WMy8bTUSRfuPeVkqLmBoGfpBaeJ+qWR3S/6OKX7oEwbtAbv6fzie cd8/hr5kQhkEep5DEZURwbDz6AoVCtpVjbYSSqNUow8ThN8PK+VkR5Vmh0KnhNx5ZC dDIm0lna8pups1MNtMevU0uuhlDhvf7qn9S0pV3BSwCTX0ghs+v23tZHzXjOPlXqVG 1aP6DsTkSXvYQ== Message-ID: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20231018070144.8512-1-zhangqing@rock-chips.com> <20231025194849.4esjw4w2trgalp55@mercury.elektranox.org> Subject: Re: [PATCH v4 0/4] rockchip: add GATE_LINK From: Stephen Boyd Cc: conor+dt@kernel.org, heiko@sntech.de, kever.yang@rock-chips.com, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, huangtao@rock-chips.com, andy.yan@rock-chips.com To: Sebastian Reichel , zhangqing Date: Thu, 26 Oct 2023 14:29:44 -0700 User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting zhangqing (2023-10-25 19:25:43) >=20 > =E5=9C=A8 2023/10/26 5:40, Stephen Boyd =E5=86=99=E9=81=93: > > Quoting Sebastian Reichel (2023-10-25 12:48:49) > >> Hello Stephen, > >> > >> On Mon, Oct 23, 2023 at 06:47:17PM -0700, Stephen Boyd wrote: > >>> Quoting Elaine Zhang (2023-10-18 00:01:40) > >>>> Recent Rockchip SoCs have a new hardware block called Native Interfa= ce > >>>> Unit (NIU), which gates clocks to devices behind them. These effecti= vely > >>>> need two parent clocks. > >>>> Use GATE_LINK to handle this. > >>> Why can't pm clks be used here? The qcom clk driver has been doing th= at > >>> for some time now. > >>> > >>> $ git grep pm_clk_add -- drivers/clk/qcom/ > >> Maybe I'm mistaken, but as far as I can tell this is adding the > >> dependency on controller level and only works because Qualcomm > >> has multiple separate clock controllers. In the Rockchip design > >> there is only one platform device. > >> > >> Note, that the original downstream code from Rockchip actually used > >> pm_clk infrastructure by moving these clocks to separate platform > >> devices. I changed this when upstreaming the code, since that leaks > >> into DT and from DT point of view there should be only one clock > >> controller. > >> > > Why can't the rockchip driver bind to a single device node and make > > sub-devices for each clk domain and register clks for those? Maybe it > > can use the auxiliary driver infrastructure to do that? >=20 > Option 1: >=20 > Use the current patch to adapt the GATE_LINK type upstream. >=20 > The real function of GATE_LINK is implemented=E3=80=82 >=20 > Just to improve and adapt the existing features on upstream. >=20 >=20 > Option 2: >=20 > What we use on our internal branches are: Does this require DT changes? If so, it's a non-starter. Why can't auxiliary devices be used?