From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBouC0cvPbrfGapGlFw9i2r2N9p7GyIHMW0xyPIDdXMBZn0p4RH8OFAKEMIF4l2N+vFkl0a4T ARC-Seal: i=1; a=rsa-sha256; t=1516335832; cv=none; d=google.com; s=arc-20160816; b=qnFuOwK59yK84C34iHxUkgq9MhGPAIxardMnHwwPCoMv81qxnLbYvMjBfZUL9MRc9w WqBtoqQbgAB5veRFMP7C1J1KJ/DA9SlmqLOegSXLmX5OavgwbfHcGscwYpn+FJ6iYEL0 W6lRZIrNP7Cu1JlC0ajzsMOeGIZsCYXXM1ecnj/ue7X6vInf5UrRvFc3eCvo9rtEqbJX kTC8/oARUkOXAZ9WylKfXIdjr1MxIli4rjnlbI3e+pI7ksVh2Z1ClMz8/4JMGxVtZTLB u/4CNdM6F/iMCTtyQv8I9pmr9YveFP+jF0+o+oCONeGSmzXU5bobCGs710VGvvz9Ujup KMDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:message-id:references:in-reply-to:subject:cc:to:from :date:content-transfer-encoding:mime-version:dkim-signature :dkim-signature:arc-authentication-results; bh=qIOihT8uGFhGWGx8u9lRQVdcw8HnkMU4Gy10hn495x4=; b=uaRlgIk2oap4Tw+OXWBHSEkaxjQN0rhmGZmkwayOi6nctn2+AQAk3QozvaC5bEHlcb 5irjoMGQoj9HtYcZJ8oAZnDnhIJv1OYUZZDWyMCDPHszSvulolMBwIk13gfV0XlozVvQ IlQxduFlb27PENsAJjxMRcTIOwx8dy9v29ibXZ1HjvcZ3l2X5XLQImm+BMGC88JUbYNq 9mntHWDxsdsyaNP45Q18GEyddB403D1FXr+Mzl0MFz49cZcoTwT1JFFbwtbXMM49M/I/ P7HHcqT0ODBBluc3hdY2T1KGZkybPUhqo4MqkTbRw9yrptQfulBAal3VSdO5/stX05jV RaFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=Swy1ai0N; dkim=pass header.i=@codeaurora.org header.s=default header.b=YHig58q4; spf=pass (google.com: domain of poza@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=poza@codeaurora.org Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=Swy1ai0N; dkim=pass header.i=@codeaurora.org header.s=default header.b=YHig58q4; spf=pass (google.com: domain of poza@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=poza@codeaurora.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 19 Jan 2018 09:53:50 +0530 From: poza@codeaurora.org To: Sinan Kaya Cc: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Keith Busch , Wei Zhang , Timur Tabi Subject: Re: [PATCH v5 3/4] PCI/DPC: Unify and plumb error handling into DPC In-Reply-To: <0ab49441-548e-a5bc-d76b-bdc6fa7495dc@codeaurora.org> References: <1516185438-31556-1-git-send-email-poza@codeaurora.org> <1516185438-31556-4-git-send-email-poza@codeaurora.org> <733abfcb-5b31-7394-ab62-19a0888d71c2@codeaurora.org> <5cf7004e62a2979afb3c29e99d705c60@codeaurora.org> <35a9ce2b-156f-3235-c3b7-2c495fe9c52b@codeaurora.org> <64127dba1cebab196c88a160191ebee0@codeaurora.org> <0ab49441-548e-a5bc-d76b-bdc6fa7495dc@codeaurora.org> Message-ID: User-Agent: Roundcube Webmail/1.2.5 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589835690475100377?= X-GMAIL-MSGID: =?utf-8?q?1589993361680784405?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 2018-01-18 23:33, Sinan Kaya wrote: > On 1/18/2018 1:00 PM, poza@codeaurora.org wrote: >>> I think you would put into include/linux/pci.h only if there is an >>> external >>> use of constant outside of drivers/pci directory. Otherwise, you >>> should keep >>> the setting inside one of the header files in drivers/pci directory. >>> >>> I don't see any other subsystem caring about DPC_FATAL definition. >> >> ok so you are suggesting to move only DPC_FATAL ? so then AER can stay >> where it is. > > Now that both AER and DPC handling is getting unified, I think it makes > sense to > keep all error codes (AER+DPC) together in drivers/pci/pci.h rather > than having > them split in aer.h and dpc.h. > > Otherwise, how would we avoid having a new error type defined with the > existing values. I agree, its is just that drivers/acpi/apet/ghes.c has to do #include ../../pci/pci.h but thats okay I think. let me move error codes to drivers/pci/pci.h. Regards, Oza.