From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBov0u3QVKmHRgEY/7pqCMvZ/OuRQnEEQnuXKgZNHlltODUmJ+AkjsL641/tDlAeDl/ntPF+0 ARC-Seal: i=1; a=rsa-sha256; t=1516252653; cv=none; d=google.com; s=arc-20160816; b=IFQutcIEjVClbgPBvPd5v92qRLDW7qJjpauJ8Aoev14/Ixy1EWJG9+jIeHUDXEvnK9 9avcy5/1RIS5Da+m0I/Fqm+lYau5uGLUYTOqeyxfSs0n1/hietPoU+l4HYk3VS78Iq4T cJWkSY/qWja51CbaH5AyrcCqAZMGNJF/R6X5LgJxq99xXIHKl+2+qDTgb9K5w4zQFe7c +RDXN5t8aDleJ83ph/10D23OXL14XMTQn2Wl09wNVfKzVKW7d0ezqtuIDdrHSnGiN6LE ZSJt7zAg8vNyuDcsL+l0EiQ+b6RB5+yqvUoCAPzf09gT+ydu3yblVbLuVKM32Stn0nve Vahw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:message-id:references:in-reply-to:subject:cc:to:from :date:content-transfer-encoding:mime-version:dkim-signature :dkim-signature:arc-authentication-results; bh=X6GnvH1TMwG0l2M8IA3jo31cZkX33UZ8mUB3EsVct9c=; b=RTPcvDp0/6m2VjJraGU9hwaOD6iZt2nLd0e5U31GQ87+GXdVa0f4RuFt2SG9YXRw60 +RrYqZ/6bbBViS2kVq4Ke5zMBGU4Y1b8xGZJO2bBeVfiM0bm/AYHbcj66YuLf57rG7Cd OAx14qyXTlu8uraVKnkQSj4GnzNdf7I5tPaMOsGYQBnJ3s2zHO4G4gJcTB1MUbw9xtUQ 0sJ5elrLTeRIykqWnodOtaQh41T3U1wX2u7xtQU5Fk5DXv+9phZjN10ForJcDqJhH6Xj iR0Nuc0QVFz9b9O6DYo89SuGQtNskqG9alzRSnoFrDx+hT4BzoUN+WF/SjibnygaiguO mJcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=bDytO5jw; dkim=pass header.i=@codeaurora.org header.s=default header.b=ExCcQnVU; spf=pass (google.com: domain of poza@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=poza@codeaurora.org Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=bDytO5jw; dkim=pass header.i=@codeaurora.org header.s=default header.b=ExCcQnVU; spf=pass (google.com: domain of poza@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=poza@codeaurora.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 18 Jan 2018 10:47:32 +0530 From: poza@codeaurora.org To: Sinan Kaya Cc: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Keith Busch , Wei Zhang , Timur Tabi Subject: Re: [PATCH v5 3/4] PCI/DPC: Unify and plumb error handling into DPC In-Reply-To: <733abfcb-5b31-7394-ab62-19a0888d71c2@codeaurora.org> References: <1516185438-31556-1-git-send-email-poza@codeaurora.org> <1516185438-31556-4-git-send-email-poza@codeaurora.org> <733abfcb-5b31-7394-ab62-19a0888d71c2@codeaurora.org> Message-ID: User-Agent: Roundcube Webmail/1.2.5 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589835690475100377?= X-GMAIL-MSGID: =?utf-8?q?1589906142263105221?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 2018-01-17 22:16, Sinan Kaya wrote: > On 1/17/2018 5:37 AM, Oza Pawandeep wrote: >> +++ b/include/linux/dpc.h >> @@ -0,0 +1,9 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> + >> +#ifndef _DPC_H_ >> +#define _DPC_H_ >> + >> +#define DPC_FATAL 4 >> + >> +#endif //_DPC_H_ >> + > > can you keep this in drivers/pci.h and get rid of this file? I thought about this, but if I keep it in drivers/pci.h, then AER's defines have to be in that as well. (for unification) and then all the dependent files who are using AER_FATAL such as drivers/acpi/apei/ghees.c have to go on including this drivers file which is odd way of doing it. So I am not very sure about this....since AER_FATAL are in aer.h, I have made dpc.h Regards, Oza.