From: Jens Axboe <axboe@kernel.dk>
To: "李培锋(wink)" <lipeifeng@oppo.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"张诗明(Simon Zhang)" <zhangshiming@oppo.com>, 郭健 <guojian@oppo.com>,
"Bart Van Assche" <bvanassche@acm.org>
Subject: Re: 回复: [PATCH] block: mq-deadline: rename sort_list to sort_rb
Date: Thu, 6 Jul 2023 08:05:07 -0600 [thread overview]
Message-ID: <c77cf93f-c27e-63aa-c2d4-c494bd9e3bee@kernel.dk> (raw)
In-Reply-To: <TYZPR02MB55950B363465E43DB0044ACEC62CA@TYZPR02MB5595.apcprd02.prod.outlook.com>
On 7/6/23 3:27?AM, ???(wink) wrote:
>>>> Mq-deadline would store request in list:fifo_list and
>>>> rb_tree:sort_list, and sort_list should be renamed to sort_rb which
>>>> is beneficial for understanding.
>
>>> Huh? I think this patch makes the code less readable instead of more readable ...
>
>> Huh? Maybe we had different opinions about it, I thinks the essence of this word is 'sort'
>> So that reader can get the meaning of it easily. And in my mind, *_rb is more reasonable for rb_root ratherthan *_list for reader.
>
> Hi Sir?
> Should it be merged for the above reason? Hope for your reply, thanks.
No, the patch makes no sense. I agree with Bart that it doesn't make it
any more readable, in fact it's worse. We have a sort and fifo list, the
backing data structure isn't that exciting by itself.
--
Jens Axboe
next prev parent reply other threads:[~2023-07-06 14:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 4:06 [PATCH] block: mq-deadline: rename sort_list to sort_rb lipeifeng
2023-07-04 14:13 ` Bart Van Assche
2023-07-05 0:30 ` 回复: " 李培锋(wink)
2023-07-06 9:27 ` 李培锋(wink)
2023-07-06 14:05 ` Jens Axboe [this message]
2023-07-07 0:26 ` 回复: " 李培锋(wink)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c77cf93f-c27e-63aa-c2d4-c494bd9e3bee@kernel.dk \
--to=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=guojian@oppo.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lipeifeng@oppo.com \
--cc=zhangshiming@oppo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox