RE: [EXTERNAL] Re: [PATCH v3 4/4] ASoc: dt-bindings: PCM6240: Add initial DT binding

["Ding, Shenghao" <shenghao-ding@ti.com>]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Wednesday, February 7, 2024 5:53 PM
> To: Ding, Shenghao <shenghao-ding@ti.com>; broonie@kernel.org;
> conor+dt@kernel.org; devicetree@vger.kernel.org; robh+dt@kernel.org;
> andriy.shevchenko@linux.intel.com; linux-sound@vger.kernel.org;
> liam.r.girdwood@intel.com; lgirdwood@gmail.com; linux-
> kernel@vger.kernel.org
> Cc: Lu, Kevin <kevin-lu@ti.com>; Xu, Baojun <baojun.xu@ti.com>; P O, Vijeth
> <v-po@ti.com>; Navada Kanyana, Mukund <navada@ti.com>;
> perex@perex.cz; McPherson, Jeff <j-mcpherson@ti.com>; pierre-
> louis.bossart@linux.intel.com; 13916275206@139.com; Chawla, Mohit
> <mohit.chawla@ti.com>; soyer@irl.hu; Huang, Jonathan
> <jkhuang3@ti.com>; tiwai@suse.de; Djuandi, Peter <pdjuandi@ti.com>;
> Agrawal, Manisha <manisha.agrawal@ti.com>; Hari, Raj <s-hari@ti.com>;
> Yashar, Avi <aviel@ti.com>; Nagalla, Hari <hnagalla@ti.com>; Bajjuri,
> Praneeth <praneeth@ti.com>
> Subject: Re: [EXTERNAL] Re: [PATCH v3 4/4] ASoc: dt-bindings: PCM6240:
> Add initial DT binding
> 
> On 07/02/2024 10: 47, Ding, Shenghao wrote: > > >> -----Original Message---
> -- >> From: Krzysztof Kozlowski <krzysztof. kozlowski@ linaro. org> >> Sent:
> Tuesday, February 6, 2024 9: 53 PM >> To: Ding, Shenghao
> ZjQcmQRYFpfptBannerStart This message was sent from outside of Texas
> Instruments.
> Do not click links or open attachments unless you recognize the source of
> this email and know the content is safe.
> 
> ZjQcmQRYFpfptBannerEnd
> On 07/02/2024 10:47, Ding, Shenghao wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> Sent: Tuesday, February 6, 2024 9:53 PM
> >> To: Ding, Shenghao <shenghao-ding@ti.com>; broonie@kernel.org;
> >> conor+dt@kernel.org; devicetree@vger.kernel.org; robh+dt@kernel.org;
> >> andriy.shevchenko@linux.intel.com; linux-sound@vger.kernel.org;
> >> liam.r.girdwood@intel.com; lgirdwood@gmail.com; linux-
> >> kernel@vger.kernel.org
> >> Cc: Lu, Kevin <kevin-lu@ti.com>; Xu, Baojun <baojun.xu@ti.com>; P O,
> >> Vijeth <v-po@ti.com>; Navada Kanyana, Mukund <navada@ti.com>;
> >> perex@perex.cz; McPherson, Jeff <j-mcpherson@ti.com>; pierre-
> >> louis.bossart@linux.intel.com; 13916275206@139.com; Chawla, Mohit
> >> <mohit.chawla@ti.com>; soyer@irl.hu; Huang, Jonathan
> >> <jkhuang3@ti.com>; tiwai@suse.de; Djuandi, Peter <pdjuandi@ti.com>;
> >> Agrawal, Manisha <manisha.agrawal@ti.com>; Hari, Raj <s-hari@ti.com>;
> >> Yashar, Avi <aviel@ti.com>; Nagalla, Hari <hnagalla@ti.com>; Bajjuri,
> >> Praneeth <praneeth@ti.com>
> >> Subject: [EXTERNAL] Re: [PATCH v3 4/4] ASoc: dt-bindings: PCM6240:
> >> Add initial DT binding
> >>
> >> On 03/02/2024 04: 05, Shenghao Ding wrote: > + > + ti,tad5212:
> >> Low-power stereo audio DAC with 120-dB dynamic range. > + oneOf: > +
> >> - items: > + -
> >> enum: > + - ti,adc3120 > + - ti,adc5120 > + - ti,pcm3120 > + -
> >> ti,pcm5120 ZjQcmQRYFpfptBannerStart This message was sent from
> >> outside of Texas Instruments.
> >> Do not click links or open attachments unless you recognize the
> >> source of this email and know the content is safe.
> >>
> >> ZjQcmQRYFpfptBannerEnd
> >> On 03/02/2024 04:05, Shenghao Ding wrote:
> >>> +
> >>> +      ti,tad5212: Low-power stereo audio DAC with 120-dB dynamic
> range.
> >>> +    oneOf:
> >>> +      - items:
> >>> +          - enum:
> >>> +              - ti,adc3120
> >>> +              - ti,adc5120
> >>> +              - ti,pcm3120
> >>> +              - ti,pcm5120
> >>> +              - ti,pcm6120
> >>> +          - const: ti,adc6120
> >>> +      - items:
> >>> +          - enum:
> >>> +              - ti,pcm6260
> >>> +              - ti,pcm6140
> >>> +              - ti,pcm3140
> >>> +              - ti,pcm5140
> >>> +          - const: ti,pcm6240
> >>> +      - items:
> >>> +          - const: ti,dix4192
> >>> +          - const: ti,pcm6240
> >>
> >> Why dix4192 is not part of previous enum?
> >
> > dix4192 is not traditional ADC or DAC, but an Integrated Digital Audio
> > Interface Receiver and Transmitter, like an audio bridge to connect
> > different digital audio protocol, compatible with the AES3, S/PDIF,
> > IEC 60958, and EIAJ CP-1201 interface standards, Left-Justified, Right-
> Justified, and Philips I2S™ Data Formats.
> > So keep it alone for professional purpose.
> 
> Hm, it is a bit surprising to see some PCM6240-compatible devices 100%
> different from other PCM6240-compatible. PCM6240 is ADC. DIX4192 is not
> ADC, not even DAC. How can it be compatible with PCM6240 in such case?
> 
They all belong to audio convertor family.
> Best regards,
> Krzysztof
>