From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB31D1D2F6E for ; Tue, 27 Aug 2024 19:05:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724785549; cv=none; b=h1iAoI7m47dKDksiE6jpnjEOI1DnHiawPqZ2cWmCv0mK363+QCu6x3l5/awLT2CO7ktIFwtSC11XBWP5JsdbjZCqfhe0r50LUnBYwstbz4NYH1FvjawGQH1hBtp/zxT4luKi4oD4fd8U6LsmrZXnis0wWzU1vmaHOVIyFDJNXIg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724785549; c=relaxed/simple; bh=g2qfOyzD7mj2ctfLhV+IRVqjYo+8o4pLyGoAVHj2xpA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ORyF8Elt+NZadO7JiPTuF2uaRy7uPUMNSFAzJYrVgrJwEMF3nHA6F9jW9q2NV9eHwH3kby0Kx5e8h+618MRLyHMc/ff0TC5BncmtIqWy2GGEURBiT97q6w8Q131Na2VDL3mX/LK0mSOP8uFIBvVhKpqUW44kzqKKmKKdm6QEeJM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=m8DRmV6k; arc=none smtp.client-ip=209.85.166.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="m8DRmV6k" Received: by mail-io1-f42.google.com with SMTP id ca18e2360f4ac-824c85e414bso203763539f.2 for ; Tue, 27 Aug 2024 12:05:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1724785547; x=1725390347; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QPgtDg58q+McBQLoCDhB6dvqAm4lTGOJk5NvB5IqS60=; b=m8DRmV6kaV1LHryNqCjrFMqRFIqAEjBnmdg7YxEaaSJL6COGd7idy6QlK8B5XOMnZ+ +JHVI9G8Hx+/5XfWjo+kcF44wcjk8694+405egBeivCPcBCsriCbbyqv5oFpTl4p469C pkj5I9dDzMSMSV+GE6/f6sFBzSQy+ypfkcJ6H0YayDDrLGi2uxGQRGJiNvDTXRRoWgwa Yw8uwpJI2ry0OvWu64xckonkv45AJwI4gayaoOaqSWiZ0kSo84bI5Tb2/UR3qf3W2uAw FdAosR/idbDqsnvCgZNVgSHCrrrG7j1RghXNxGf63FD4vD9C6OFY6ypa/WgvmtDHU3w/ jqeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724785547; x=1725390347; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QPgtDg58q+McBQLoCDhB6dvqAm4lTGOJk5NvB5IqS60=; b=f3VM4E35bP8HKhGcDIEqm/lEwTU+Mep789ftBMG2QWIeLNvZn11j8pcCquXizuC+ZW VY9pALYZzMIp0yCK1U/nDKIxuZiy6eqjaWbZ8Ctjxm10BEzBdtdP7Y2bgMc4nd53pZFR 4kx8Ccoife/TiEN2g9FIj2YqY2Pz6GOipRCh2z8fSvQHgt3wjJ3hatv4a5UeUxHOIp5D f+23xQyEDsWpV5JSi+3vPysvJctmbtv5Y8nE32ntmBHJJPDHMKqA25i/qDqCnplqtLj0 k4mQjaEefSt7y6LMvYdO8JHaJ9AuqrLgHxaBp1NEb7tU36VQhKIc0xpEKdWGVpF4yeoB Qc3g== X-Forwarded-Encrypted: i=1; AJvYcCX5hVMBa1fDdHSyEgNpRe7TtFzHQyug+COrkXjpgdKbQu2S6lWxpbbo7yixpwHvpCbZA8XBCGJ3I0viUa8=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6fT18dTvVKpANCBYgF4xJpNzEc/Zn8KvqbNgdI8YqnQpCkAvY H6FVFcVz3pnh3c4H6Trhr52Vdj0rH/igK53sFiJWvYOlJbZZcPT99WGFqCq/BCk= X-Google-Smtp-Source: AGHT+IEuujl/9dEsZ4FQ8JuKJxuoRbbHy6rNrvvhcf00pWo8FSAo3yeLetJirxmhnMEDUTEhU7xR4w== X-Received: by 2002:a05:6602:13c8:b0:824:d752:986 with SMTP id ca18e2360f4ac-82787387f9amr1917557439f.16.1724785546835; Tue, 27 Aug 2024 12:05:46 -0700 (PDT) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4ce70f20255sm2724543173.3.2024.08.27.12.05.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Aug 2024 12:05:46 -0700 (PDT) Message-ID: Date: Tue, 27 Aug 2024 13:05:43 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/7] block: mtip32xx: Replace deprecated PCI functions To: Philipp Stanner , Wu Hao , Tom Rix , Moritz Fischer , Xu Yilun , Andy Shevchenko , Linus Walleij , Bartosz Golaszewski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Bjorn Helgaas , Alvaro Karsz , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Richard Cochran , Damien Le Moal , Hannes Reinecke , Keith Busch Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, virtualization@lists.linux.dev References: <20240827185616.45094-1-pstanner@redhat.com> <20240827185616.45094-4-pstanner@redhat.com> Content-Language: en-US From: Jens Axboe In-Reply-To: <20240827185616.45094-4-pstanner@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/27/24 12:56 PM, Philipp Stanner wrote: > pcim_iomap_regions() and pcim_iomap_table() have been deprecated by the > PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate > pcim_iomap_table(), pcim_iomap_regions_request_all()"). > > In mtip32xx, these functions can easily be replaced by their respective > successors, pcim_request_region() and pcim_iomap(). Moreover, the > driver's calls to pcim_iounmap_regions() in probe()'s error path and in > remove() are not necessary. Cleanup can be performed by PCI devres > automatically. > > Replace pcim_iomap_regions() and pcim_iomap_table(). > > Remove the calls to pcim_iounmap_regions(). Looks fine to me - since it depends on other trees, feel free to take it through those: Reviewed-by: Jens Axboe -- Jens Axboe