public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	Jakub Slepecki <jakub.slepecki@intel.com>,
	<nxne.cnse.osdt.itp.upstreaming@intel.com>,
	<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] ice: fix broken Rx on VFs
Date: Mon, 24 Nov 2025 18:17:56 +0100	[thread overview]
Message-ID: <c7bd3f03-fa2f-495c-94cb-8e310608cee6@intel.com> (raw)
In-Reply-To: <20251124170735.3077425-1-aleksander.lobakin@intel.com>

From: Alexander Lobakin <aleksander.lobakin@intel.com>
Date: Mon, 24 Nov 2025 18:07:35 +0100

Ooops, missed a tag, sorry...

> Since the tagged commit, ice stopped respecting Rx buffer length
> passed from VFs.
> At that point, the buffer length was hardcoded in ice, so VFs still
> worked up to some point (until, for example, a VF wanted an MTU
> larger than its PF).
> The next commit 93f53db9f9dc ("ice: switch to Page Pool"), broke
> Rx on VFs completely since ice started accounting per-queue buffer
> lengths again, but now VF queues always had their length zeroed, as
> ice was already ignoring what iavf was passing to it.
> 
> Restore the line that initializes the buffer length on VF queues
> basing on the virtchnl messages.
> 
> Fixes: 3a4f419f7509 ("ice: drop page splitting and recycling")
> Reported-by: Jakub Slepecki <jakub.slepecki@intel.com>

Suggested-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>

> Reviewed-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
> ---
> I'd like this to go directly to net-next to quickly unbreak VFs
> (the related commits are not in the mainline yet).
Thanks,
Olek

  reply	other threads:[~2025-11-24 17:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-24 17:07 [PATCH net-next] ice: fix broken Rx on VFs Alexander Lobakin
2025-11-24 17:17 ` Alexander Lobakin [this message]
2025-11-25  6:32   ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-11-25 10:59 ` Jakub Slepecki
2025-11-26  4:00 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7bd3f03-fa2f-495c-94cb-8e310608cee6@intel.com \
    --to=aleksander.lobakin@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jakub.slepecki@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nxne.cnse.osdt.itp.upstreaming@intel.com \
    --cc=pabeni@redhat.com \
    --cc=przemyslaw.kitszel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox