From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966313AbdGUCqk (ORCPT ); Thu, 20 Jul 2017 22:46:40 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:20659 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965967AbdGUCqj (ORCPT ); Thu, 20 Jul 2017 22:46:39 -0400 Subject: Re: [PATCH 2/2] sparc64: Use cpu_poke to resume idle cpu To: David Miller Cc: sparclinux@vger.kernel.org, rob.gardner@oracle.com, anthony.yznaga@oracle.com, linux-kernel@vger.kernel.org References: <1499545424-415240-1-git-send-email-vijay.ac.kumar@oracle.com> <1499545424-415240-3-git-send-email-vijay.ac.kumar@oracle.com> <20170720.125850.1894569815191415786.davem@davemloft.net> From: Vijay Kumar Organization: Oracle Corporation Message-ID: Date: Thu, 20 Jul 2017 21:47:15 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170720.125850.1894569815191415786.davem@davemloft.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/20/2017 2:58 PM, David Miller wrote: > From: Vijay Kumar > Date: Sat, 8 Jul 2017 14:23:44 -0600 > >> diff --git a/arch/sparc/kernel/hvapi.c b/arch/sparc/kernel/hvapi.c >> index 2677312..0b070d5 100644 >> --- a/arch/sparc/kernel/hvapi.c >> +++ b/arch/sparc/kernel/hvapi.c >> @@ -189,7 +189,7 @@ void __init sun4v_hvapi_init(void) >> >> group = HV_GRP_CORE; >> major = 1; >> - minor = 1; >> + minor = 6; /* CPU POKE */ >> if (sun4v_hvapi_register(group, major, &minor)) >> goto bad; > That CPU POKE comment will not stand the test of time, please remove it. > >> + /* Use cpu poke to resume idle cpu if supported*/ > Please put a space at the end of the comment and before the "*/" > >> + /*cpu poke is registered. */ > Please put a space at the beginning of the comment. > > And you should decide which way you want to consistently write. > Either capitalize the first word and finish the sentence with > a '.', or don't. Do it the same way each time. > > Thanks. Sure, I will fix these in v2. Thanks, -Vijay