From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-176.mta1.migadu.com (out-176.mta1.migadu.com [95.215.58.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1DE61474A5 for ; Tue, 24 Sep 2024 22:41:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727217668; cv=none; b=gFh7a2HzaUchUTxVgBg6tAR6pdJKFnZCQy4SUjiozKPlZ+OJ+tqCnUsmAYBvj7C8UA6+yw0VgmUeRVoUnyddf97zrD12QHErUqrfCOwUqdxv9+UY9BHfjmehv19KETToUMNGMCQfKZFyn0lkLdOVxwrIAgp8UD7OBUArCY62J1U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727217668; c=relaxed/simple; bh=NhMixv5kl+9QH6xYXoXAIcF/J3IXlleAgXvIX0252z8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oS2bx264Mq+xiffIYjtKNoRbsKLmqsxv+2hQL/Esy2Nht2O90XXiT6mBUzS1Jz0eV9WS/yrsxmrCkNtUIBzA+GZKmpDJKpLcIQw1C74hWRUZS77wA5HhpwKqsu66Km/FzLrjTyNR1PBWknpwmNNR/lWHOGlvUy8CDQXG4b8wkk8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=SLqyPgRt; arc=none smtp.client-ip=95.215.58.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="SLqyPgRt" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1727217663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D/3ql7hSu6hfJ6OUqVAGGrToVQdofg7CuYaFZlYBk80=; b=SLqyPgRtLkk/M3T3thMFA4Fk9htRI6ziWWflbkjrvNW+jLBX6iVw63Kg2ZVUh+c6tbkWgP GVAB6wHaVDQijoBgFZclOYkd22LPH2GX6TUK7HEr9HQm3yldyj9S/BbIczOBrPWqRi4188 1IgMXcJqtnKIYjKEqhuEFpd70PjRN3k= Date: Tue, 24 Sep 2024 15:40:53 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf-next v1] selftests/bpf:Enhance bpf ability to detect ksym read error by libcap To: Lin Yikai Cc: bpf@vger.kernel.org, opensource.kernel@vivo.com, Andrii Nakryiko , Eduard Zingerman , Mykola Lysenko , Alexei Starovoitov , Daniel Borkmann , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Shuah Khan , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev References: <20240914092426.431066-1-yikai.lin@vivo.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau In-Reply-To: <20240914092426.431066-1-yikai.lin@vivo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 9/14/24 11:24 AM, Lin Yikai wrote: > diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile > index 04716a5e43f1..369c5ad8fc4a 100644 > --- a/tools/testing/selftests/bpf/Makefile > +++ b/tools/testing/selftests/bpf/Makefile > @@ -183,7 +183,7 @@ NON_CHECK_FEAT_TARGETS := clean docs-clean > CHECK_FEAT := $(filter-out $(NON_CHECK_FEAT_TARGETS),$(or $(MAKECMDGOALS), "none")) > ifneq ($(CHECK_FEAT),) > FEATURE_USER := .selftests > -FEATURE_TESTS := llvm > +FEATURE_TESTS := llvm libcap > FEATURE_DISPLAY := $(FEATURE_TESTS) > > # Makefile.feature expects OUTPUT to end with a slash > @@ -208,6 +208,11 @@ ifeq ($(feature-llvm),1) > LLVM_LDFLAGS += $(shell $(LLVM_CONFIG) --ldflags) > endif > > +ifeq ($(feature-libcap), 1) > + CFLAGS += -DHAVE_LIBCAP_SUPPORT > + LDLIBS += -lcap > +endif > + [ ... ] > @@ -31,6 +35,55 @@ struct ksyms { > static struct ksyms *ksyms; > static pthread_mutex_t ksyms_mutex = PTHREAD_MUTEX_INITIALIZER; > > +#ifdef HAVE_LIBCAP_SUPPORT > +#include > +static bool bpf_cap__capable(cap_value_t cap) > +{ > + cap_flag_value_t val; > + cap_t caps = cap_get_proc(); > + > + if (!caps) > + return false; > + > + if (cap_get_flag(caps, cap, CAP_EFFECTIVE, &val) != 0) Instead of adding new dependency on libcap, please check if capget() can directly be used. Take a look at tools/testing/selftests/bpf/cap_helpers.c. pw-bot: cr > + val = CAP_CLEAR; > + > + if (cap_free(caps) != 0) > + return false; > + > + return val == CAP_SET; > +}