From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C81435E959 for ; Fri, 17 Apr 2026 05:27:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776403653; cv=none; b=pw9LMm3IZ9+2xgh4Qs7kB25qV5iliOIrfhjPBqGoADQYxRrraYzxTA7UElJunqwVSMSgy97EvfegawNLsOpeZgwlGv4PbLPpwzLBLOZtT482iyFCAgwnM6XUK/9WP7OmO0tUJLuHhg0qMx8/umuYI5cfL4mCftQSAmSym2CZrwk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776403653; c=relaxed/simple; bh=sQPJITnR9Z5bXhAk0RqJv/sWN1Hn17ijSRTOEukN5yk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZlXGUeZJEMsNwIgZqacUJDUMxl11x1Ipbcu77VQZndrXIR9Ts4mK67EXqLts8CuW/JI0CdCYYfLoL0z1m+Q1W3nBqDJiev5jEnhiOorU1D6CRRvPzwWKlTZni6ELThprCoV24c7Pn+gM+Jg2GxsEz60FajQFWm+L19mWrE50ss4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Sber4iGJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=O8n7NT3D; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Sber4iGJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="O8n7NT3D" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63H0flC44119536 for ; Fri, 17 Apr 2026 05:27:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PbQedCTMon0+ok3F72vFycxrfJmoF2dQzAk6fHch7uE=; b=Sber4iGJ/CjVKzEU lS+qmhjlPsh1R1DNND2++f/cBYipwmZcl0hjTEaYAQcWV3p3E3oVAb2ivEAP9xUF J6lEvHMKPv9E+x4ZCUR34mE3/EEZfdwMQmnPkBEsarLb8Z4jsWGvRE885zbFW3rg e5nXsG9ILUgYN7ynyx4+TLgrsChzmhbjlKvn1kWBkPExB+d6A7Eooxn2pqQk8n8W e9GYMgwEyT5i0m1Kkbg+eYXt7cwPsCNVcijwZUvWJYEfD7UpiArPbU5T05hxa79l Ckd5JwylGHdCfaJ+s0EGa5eg0k+e5VhjIEJavFaVaGNdh/O3P6qWmmAnkTu4VTMH cBUrBw== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4djtd94dhf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Apr 2026 05:27:31 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-354c44bf176so420590a91.0 for ; Thu, 16 Apr 2026 22:27:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776403650; x=1777008450; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PbQedCTMon0+ok3F72vFycxrfJmoF2dQzAk6fHch7uE=; b=O8n7NT3DHsmILnZEQI/KC/68WD3GStbCeYLwkO9SgID9H+slQKTKUks5Pj/xQL852S 8JGxkrqh0+vQIJ9VBcijeNCc8yabGkn1/Aaxd7vAnbtPOqIAH2ToVDCfmX7+eXIsl44c 3gyC7kBV8FmP5rzwGquM6+Y1rUhg1VSA561PsZkBLWFnPQVIw5YHGfjTV1YJeBi+XEWI 4hpVkW3bKk7tn2DdazWMZTij5qA1r5/uqHCu4EAVW+DBZtdXEbmtIFuDDeg5Sfhfd1I+ pPa4u4dZlSMSD+nhmFUZEOWWfa5ODJhMZCIXJCcPp/WwhVcVf4oDdtjF1EOyBpyHPXo9 KazQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776403650; x=1777008450; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PbQedCTMon0+ok3F72vFycxrfJmoF2dQzAk6fHch7uE=; b=kdO57NqSHqPtoKu3GVsMtjzDW/TKR4MvCsaKiKofXO5S/97s7qlKnwAS6zNhXaebyp bfYysoj7z7T/cvC2b3FLIok6Yz4ItI/kAFFcqaCBNGmzHmovU3l2oyoDwO9Ob48W4P7d ozXsAsotaC4/7otZ5azfPZBJotPQ+ApI03MTVLDfWNd6NinhSfgCllix4cgsAp8EvQ9E waV4MJLzMg70VtYo+JejWi81NMJTqipLrcW4jhZC1nSWnPDm67O6UgSKImTSKQzoF/+0 ZHzLrXnYSRhIVgPBFp6NNhnQm6JjzBeq9FSlzjNwXEDqGYZZnpn2gBShjLcOuyXZbLYJ L9wg== X-Forwarded-Encrypted: i=1; AFNElJ+eMznNZpITS6m/5bh6mZ+Ss7nxOgECF1hPdaeuZ2WaHwolceuimJGU81PwcKPEw4aKMBh4Y1jIpGJeK+Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzcWNgsMZ0S3ZhZG0T+wtDTwY3xkA77i6Mfm70IfFl7GWIEx1TV rq7DCU+1WzNLbSUB5AibKoYO4rt/IJcBopUpACLLTVGVzNIq4MZuMzR2wGagCiTaC6N2Ke1p/IU lpkfi3mI3opTOr2SxL5sx4UPrEVILSG4/WAd/VGoXmPg1wF3jY8HenWdE5jMMkZIqKRc= X-Gm-Gg: AeBDievgMSAcB7lPFQVEhyr0zfSLbKOdzkXo1nRAe9Sde2PCFB7GvNsee4MS0148flK F/hLorOEhoYbqfdnwKFZ8UoK/h+bfzwqgSxXqDizoAVlqnMH3gMSHKu5kCj3TSk4mlqcD9tvZuX WQRtW+r94KIBXtYKLjtIYBT36ZdCBJJutpB/oGw4pog6PId1C/oWmn4SBddb+q1wlck7jeecn6Q //40445p+dncQHzXJgEbFqhGoiOtSWhZJfakIrAwj6N5Hd2XJ5fvgcPpGIgjyklhcmY/AVp2jLW 38t4dsSLjnAyiC/Ws/4QLnw0g00w26adozIG4d2CLrgzWMgap92L0gEXJHHTyCEeflaC/Ht/fz9 CXJ8ljXzJJtNoIB/aL8XfKmFbaWfoZamy3h2O/aoqYap4e9a3GBVy3DJv/MQAyESC X-Received: by 2002:a17:90a:ec8b:b0:35e:5b19:234d with SMTP id 98e67ed59e1d1-361403f0aefmr1476930a91.7.1776403650102; Thu, 16 Apr 2026 22:27:30 -0700 (PDT) X-Received: by 2002:a17:90a:ec8b:b0:35e:5b19:234d with SMTP id 98e67ed59e1d1-361403f0aefmr1476902a91.7.1776403649639; Thu, 16 Apr 2026 22:27:29 -0700 (PDT) Received: from [10.217.217.28] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3613fabeccesm341061a91.6.2026.04.16.22.27.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Apr 2026 22:27:29 -0700 (PDT) Message-ID: Date: Fri, 17 Apr 2026 10:57:22 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] arm64: dts: qcom: hamoa-pmics: define VADC for pmk8550 To: Aleksandrs Vinarskis , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Bryan O'Donoghue Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, laurentiu.tudor1@dell.com, Abel Vesa , Tobias Heider , Val Packett References: <20260404-dell-xps-9345-ec-v2-0-c977c3caa81f@vinarskis.com> <20260404-dell-xps-9345-ec-v2-3-c977c3caa81f@vinarskis.com> Content-Language: en-US From: Jishnu Prakash In-Reply-To: <20260404-dell-xps-9345-ec-v2-3-c977c3caa81f@vinarskis.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE3MDA1MSBTYWx0ZWRfX5H29BKEZtjFo ft8n8gqQiTlthHRGcekZsTbbtD7EAQQjKpScPVrYxyPNgbchVIQZofmrg/7PYC77fxxiJk4q7pp KoFy25ddik/GjfNpjYkLf2YoLqzWfYv1a5wXloTfyg7eCXXI443WdXa7m9bKkfKk8uKjWB7Amt3 lIX9oJbHl/LcPX6P6gyDMseWtySXqw1Z8WHGPMoYmUKeUpSGSuhacZTQ+MtELFLWNyRXB4GiL9R PX2wbGbApNlOCm5WS770D6zPosExmJSLudM+r5uQjqJXpLwKzEpihFmzenBIZP48pOXAQV/Olof wtrZQkYGzlfn6tCRcbknMPCMhxVwv52G8CM3ZjXh9eX3oJ40WZ3jNiBG1rRO5J0SojGm0Qcn9Nb XrGCRfGWQAuWAXIpFAdkUK/sWrqUEBj42nkutNC7JfNQRKf/hvLF+7lWrvyziipZ0DiEr7KsUgZ azX8jio622KBQLJ827g== X-Authority-Analysis: v=2.4 cv=avuCzyZV c=1 sm=1 tr=0 ts=69e1c4c3 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=I76Qk8w-AAAA:8 a=n3mQhmZCFyheae90VUUA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 a=vUPM0Wvl0xcrLs4nqPIT:22 X-Proofpoint-GUID: _GIicPXg7YdsAdZ9-qUz3hXVnEymz_ti X-Proofpoint-ORIG-GUID: _GIicPXg7YdsAdZ9-qUz3hXVnEymz_ti X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-16_04,2026-04-16_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 spamscore=0 bulkscore=0 priorityscore=1501 adultscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604170051 On 4/4/2026 6:25 PM, Aleksandrs Vinarskis wrote: > Follow pattern of pmk8350 to add missing pmk8550 VADC to hamoa. > Register address of 0x9000 matches example schema for spmi-adc5-gen3. > > Signed-off-by: Aleksandrs Vinarskis > --- > arch/arm64/boot/dts/qcom/hamoa-pmics.dtsi | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/hamoa-pmics.dtsi b/arch/arm64/boot/dts/qcom/hamoa-pmics.dtsi > index 6a31a0adf8be472badea502a916cdbc9477e9f2b..cc69d299bc356d90aa1483f347f5eee43b853e45 100644 > --- a/arch/arm64/boot/dts/qcom/hamoa-pmics.dtsi > +++ b/arch/arm64/boot/dts/qcom/hamoa-pmics.dtsi > @@ -218,6 +218,32 @@ pon_resin: resin { > }; > }; > > + pmk8550_vadc: adc@9000 { > + compatible = "qcom,spmi-adc5-gen3"; > + reg = <0x9000>, <0x9100>; > + #address-cells = <1>; > + #size-cells = <0>; > + interrupts = <0x0 0x90 0x1 IRQ_TYPE_EDGE_RISING>, > + <0x0 0x91 0x1 IRQ_TYPE_EDGE_RISING>; > + #io-channel-cells = <1>; > + #thermal-sensor-cells = <1>; > + > + channel@3 { > + reg = <0x3>; > + label = "pmk8550_die_temp"; > + qcom,pre-scaling = <1 1>; > + }; > + > + channel@44 { > + reg = <0x44>; > + label = "pmk8550_xo_therm"; > + qcom,pre-scaling = <1 1>; > + qcom,ratiometric; > + qcom,hw-settle-time = <200>; > + qcom,adc-tm; There's a small problem here - if you add the "qcom,adc-tm" property under any channels, the auxiliary TM driver will be loaded to handle this functionality and it will attempt to register such channels as thermal devices. Since there is no thermal-zone node added for this channel, you will get an error from here. If you intend this channel to be used for ADC_TM functionality, a thermal zone node for this channel has to be added. If this functionality is not needed, it's better to remove the "qcom,adc-tm" property. Thanks, Jishnu > + }; > + }; > + > pmk8550_rtc: rtc@6100 { > compatible = "qcom,pmk8350-rtc"; > reg = <0x6100>, <0x6200>; >