From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6E08409107 for ; Tue, 30 Jun 2026 12:02:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782820926; cv=none; b=o/nXlGoV/wnoeGP+9lShdmMjQiCDlp6moduyBwi+vuWgP+vnigs5nbwk+NOkBigCyFjBz6vC+ZysrC5aXCUoyWLwjoW3toBJL6GFUi7+fspBJ0sL/XPvM08HJhQNeT5YJKzdXwuyxWZj8As8bhyu/SiFADhD8Il4edp3LLTmAIs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782820926; c=relaxed/simple; bh=jB8ORTPN/Ir/rdNJDngB2P7qDRWmgC5iuBxccmgQJpU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=X49EAi/0L9VXWrKmva6NHqBM8H1PsCxIMuJHUTt34tzIJR5OLgjyx4blGu71E2UMSd6R372dGHoxersDW2qIni4iTkr7xhocJrbLbkCgbQ3P1mEWBK3Yo0/wtey+KjS/9oDdLXPHOSHo5ec4hYyAvmHRg07vpqp8Nvgc+1n8Gro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=J3aionmF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FpHowL6c; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="J3aionmF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FpHowL6c" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65U9n1KY1573385 for ; Tue, 30 Jun 2026 12:02:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ghIqzt2swN22I+Ok/FxKdmKOxX4q+2Bz9NLExdF6R7k=; b=J3aionmFiPLg5GU6 Sv+MSK0KCIjz4E0L5/BagG6QrzTryp9CS6HWYvJ+Nc8rCdONGpes/ANva9n8rvhD N+VHMh+8VnebliA+jFtYhVY9KTdapI3zygRUJwd0RqwLJ7Oi7D1aXf+SI9RhehtF LsKt/Q0Y0KQjvO1+TK/ObRJDQCfUaDXRZoB1l17r9C4iuRUvOcNP8WxDuSD/SKXI MfU3BrQNfbgaNjRJrj+kqipfDsxtpagxrS644oG9tPCIgDkKN4DcdIzmlFBdYhNX V10f2t+yahF/Kkd1Y6gHUyEVmdeVeSJo5L1pNsSgGqAQ8LsZa+fFNOeso3AjkpR5 5eULPA== Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f468622ds-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 12:02:03 +0000 (GMT) Received: by mail-vk1-f200.google.com with SMTP id 71dfb90a1353d-5bdcdbc954eso2664e0c.1 for ; Tue, 30 Jun 2026 05:02:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782820922; x=1783425722; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ghIqzt2swN22I+Ok/FxKdmKOxX4q+2Bz9NLExdF6R7k=; b=FpHowL6cNLngCkVKG+pj1tkbjMf98w3pHYvfzNVg2VAzjve5h+zV0go6SWlO1BajvC KboybOHyS9KRJpkRsdtF/3buL5tdOz+DMxqIgKdjL/q8z+5NQeSMwmmNtNTBZjsfbTWo TD7NQfwvvuevLoG1Ella0YJCqjvk5QBuaJ5zDPl9N3KUfMY9P8g2fUytYbcafwTBVNdH aMXF4KEXQNI6eZe2QVgxpDyU8P7LtFVmvZxzWbbhkQMcD+2V5vKXKcdWBGtz9wm2armP ncFtPZTi2JOkv4RabCLzO6j9dNj8niJWHdf5spnI0A1YYWJ/HI80r9gDK+7WSIsUiXJh 0wnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782820922; x=1783425722; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ghIqzt2swN22I+Ok/FxKdmKOxX4q+2Bz9NLExdF6R7k=; b=nZcUwj72YZCe/i0z9U9gJHHCORnu6GRiCnNDrbeZLON978y3+fsl8V+TIyPEwuYKmw J5DEVPZ+WdE24H4RIBomZlRuU+MpvAfdGhcfyI9hNBSMgl1GlJSdwysoR4dvfTpfejpM lF77q9ZUFhnia6CP7Jmx1akDeznDM/LJ79NIA8JOeCFehpeT9SjXdLwnnVBvRkALDubK /GaxpRWiDUsldig+LfNcSbShlkLG80iCmvy3V+JwjC64i7/vR/2mWibRxMQl9JcrsQmt PTVYEGJvdS+9FP0L1gDYlSE9vmVzA0mCuj+iksLzYYoToth1soG5N7YWuN2iuIFl2Awq /Iug== X-Forwarded-Encrypted: i=1; AHgh+RpuNeEjdHqmUAxdqFv/KqbSrllfNval8cO8LyJLoGnreE+xPvgfuPdMVnlwbQ+Yy3UbNRzZ9xg9OQvm99s=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+PgVJ4ISf0WP12qPw8eOtesviMFKfpMTP+HHKiLEKjwQsNhlB Y8gzW19wr9yGRgxGOdXiiEhEsxHtFoPqN5ufzG+fc6tvC0KnhPcJHi6IawoG5KkVuqTjY2J4g1B 4xnDZ+55J+b4SSaNv25zenCAF0OMQwKZZkBNYgKXXreaF4QH839hEhZR8jqStTTPBhb4= X-Gm-Gg: AfdE7cnvb+i5oQvwmT1VDlF5RCbsgDJvChe487rmSBenLfA+5tyjrLSCrSI7cGSA4w2 WTFvwEBp2YHys9y+Kv0PWTZxkMEieRbfx1ooVuhAQbQFb3Nd+DRvaLiG0sDud5LeYe+7g75n2qH 7eRLkOyLKwWlfeR78j9Eu6x4JInoBqClh2/vXOV0LyAoeohww3PhanxrQlwOw/NBkdsakTo3ZTT ZNFB2LT4YcbvpFZmzlfIy5lJ7PoCpNelmhcTvKFY/gdccphRt/CS6ftlgW209Y/eMVruTnvDixC fvpBUc0RG5orI4M4SBoYzKHbsPd5ucLqTJJI4jS2jw+8VFWUDM4XsskPRmhJfnbJgYPgWqPtsKb guVzLElh+fvVo4r8T8u9GPxdhDk3N0zzQwKM= X-Received: by 2002:a05:6102:6448:b0:737:9003:ac52 with SMTP id ada2fe7eead31-73a333d61b9mr493066137.0.1782820922364; Tue, 30 Jun 2026 05:02:02 -0700 (PDT) X-Received: by 2002:a05:6102:6448:b0:737:9003:ac52 with SMTP id ada2fe7eead31-73a333d61b9mr490634137.0.1782820901854; Tue, 30 Jun 2026 05:01:41 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1288d1d61asm113746666b.13.2026.06.30.05.01.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 05:01:40 -0700 (PDT) Message-ID: Date: Tue, 30 Jun 2026 14:01:37 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: hamoa-pmics: Add ADC support To: Jishnu Prakash , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ayyagari Ushasreevalli , Kamal Wadhwa References: <20260614-adc5_gen3_dt-v2-0-32ec576c5865@oss.qualcomm.com> <20260614-adc5_gen3_dt-v2-4-32ec576c5865@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260614-adc5_gen3_dt-v2-4-32ec576c5865@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: g-DIP1CVlkH5_Repzfvxt5akUp0JbdWE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDExMCBTYWx0ZWRfX84vquy/fkLRZ OIaXW96L64NKFVMq9gEyHVCF0SVMxKX8GrpjlKMGmkvXfvOETTRiLkXHHE7/Kz+cDb60wS/K+zE F4j76rKn3lAq89nggrazV/hOYY/wlbmskusP56TllMpEaFQnT3hSb/oib1utSamsT29nfR9qE0h yC6BfpMEadkeS5o22uVxiLFEg9GG7NV4eSkJie3v2d7iYy3jjUz6AMctsQQGM0es1gbqCn18UZq 5JMbQv8d7CT9MMUclb6mUQaGTLO7oAwUGweT0QMuso4YjXzNc1FMCbpqYO4+QL9OBExF7/SwQJR CWQkS4NCprebB1s2JTo7b83c/XHWQiQoV00CmxpMXrPCXtwleBz4WhbX0+XJyVqIX+WgboxpTFW 2CARL8Qb8GMpOfqMBeLaiJjYwn7akpi1d3NugFnTRAczmudwCavg4G/J14HBiEmvDh7oqIv44wb sWrdAcQcIBm2HGiUoIA== X-Proofpoint-GUID: g-DIP1CVlkH5_Repzfvxt5akUp0JbdWE X-Authority-Analysis: v=2.4 cv=FbcHAp+6 c=1 sm=1 tr=0 ts=6a43b03b cx=c_pps a=wuOIiItHwq1biOnFUQQHKA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=XhgZWyofoZ1-JSIGm7gA:9 a=QEXdDO2ut3YA:10 a=XD7yVLdPMpWraOa8Un9W:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDExMCBTYWx0ZWRfXxOrpQazzVkuI +DwAjCKLo1ckYZmqtBe+mO8Y5BZ8siLS5Pjs0Cgh8i/d0IQUXQRP+0/LdoBzWd/Ca5WsZeXoyVZ 5CAirHF7BN4Z/B0jINcJ3ut7GJ4TJiQ= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 bulkscore=0 adultscore=0 phishscore=0 malwarescore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300110 On 6/14/26 10:05 AM, Jishnu Prakash wrote: > From: Ayyagari Ushasreevalli > > Add ADC node and define channels for: > - Die temperature for PMK8550, PM8550VE* and PMC8380* PMICs. > - PM8550: Die temperature, VPH power, and system thermistors. > > Define thermal zones 'sys-0-thermal' through 'sys-6-thermal' which > correspond to the off-PMIC system thermistors connected via > PM8550 AMUX/GPIO lines. > > Also,add io-channels and io-channel-names properties to the > temp_alarm nodes so that they can get temperature reading > from the ADC die_temp channels. > > Signed-off-by: Ayyagari Ushasreevalli > Signed-off-by: Jishnu Prakash > --- [...] > + sys-0-thermal { > + polling-delay-passive = <0>; Drop, this is zero by default > + thermal-sensors = <&pmk8550_vadc ADC5_GEN3_AMUX1_GPIO_100K_PU(1)>; > + trips { Please add a \n between the last property and the following subnode > pmc8380_6_gpios: gpio@8800 { > @@ -451,6 +697,8 @@ pm8550ve_8_temp_alarm: temp-alarm@a00 { > reg = <0xa00>; > interrupts = <0x8 0xa 0x0 IRQ_TYPE_EDGE_BOTH>; > #thermal-sensor-cells = <0>; > + io-channels = <&pmk8550_vadc ADC5_GEN3_DIE_TEMP(8)>; > + io-channel-names = "thermal"; > }; pmc8380_6 isn't mounted on purwa boards - do we need to override the channel definitions in the vadc? Konrad