From: Alexander Gordeev <agordeev@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Alexander Gordeev <agordeev@redhat.com>,
Naresh Kumar Inna <naresh@chelsio.com>,
Arvind Bhushan <arvindb@chelsio.com>,
linux-scsi@vger.kernel.org, linux-pci@vger.kernel.org
Subject: [PATCH v2 06/23] csiostor: Use pci_enable_msix_range() instead of pci_enable_msix()
Date: Mon, 24 Feb 2014 09:02:06 +0100 [thread overview]
Message-ID: <c7d2dc937c290f25c179f2ebbe1fcdb79e13b010.1393191330.git.agordeev@redhat.com> (raw)
In-Reply-To: <cover.1393191330.git.agordeev@redhat.com>
As result of deprecation of MSI-X/MSI enablement functions
pci_enable_msix() and pci_enable_msi_block() all drivers
using these two interfaces need to be updated to use the
new pci_enable_msi_range() or pci_enable_msi_exact()
and pci_enable_msix_range() or pci_enable_msix_exact()
interfaces.
Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Cc: Naresh Kumar Inna <naresh@chelsio.com>
Cc: Arvind Bhushan <arvindb@chelsio.com>
Cc: linux-scsi@vger.kernel.org
Cc: linux-pci@vger.kernel.org
---
drivers/scsi/csiostor/csio_hw.h | 2 +-
drivers/scsi/csiostor/csio_isr.c | 22 +++++++++-------------
2 files changed, 10 insertions(+), 14 deletions(-)
diff --git a/drivers/scsi/csiostor/csio_hw.h b/drivers/scsi/csiostor/csio_hw.h
index 49b1daa..5db2d85 100644
--- a/drivers/scsi/csiostor/csio_hw.h
+++ b/drivers/scsi/csiostor/csio_hw.h
@@ -94,7 +94,7 @@ enum {
};
struct csio_msix_entries {
- unsigned short vector; /* Vector assigned by pci_enable_msix */
+ unsigned short vector; /* Assigned MSI-X vector */
void *dev_id; /* Priv object associated w/ this msix*/
char desc[24]; /* Description of this vector */
};
diff --git a/drivers/scsi/csiostor/csio_isr.c b/drivers/scsi/csiostor/csio_isr.c
index 91ba91d..a8c748a 100644
--- a/drivers/scsi/csiostor/csio_isr.c
+++ b/drivers/scsi/csiostor/csio_isr.c
@@ -499,7 +499,7 @@ csio_reduce_sqsets(struct csio_hw *hw, int cnt)
static int
csio_enable_msix(struct csio_hw *hw)
{
- int rv, i, j, k, n, min, cnt;
+ int i, j, k, n, min, cnt;
struct csio_msix_entries *entryp;
struct msix_entry *entries;
int extra = CSIO_EXTRA_VECS;
@@ -521,19 +521,15 @@ csio_enable_msix(struct csio_hw *hw)
csio_dbg(hw, "FW supp #niq:%d, trying %d msix's\n", hw->cfg_niq, cnt);
- while ((rv = pci_enable_msix(hw->pdev, entries, cnt)) >= min)
- cnt = rv;
- if (!rv) {
- if (cnt < (hw->num_sqsets + extra)) {
- csio_dbg(hw, "Reducing sqsets to %d\n", cnt - extra);
- csio_reduce_sqsets(hw, cnt - extra);
- }
- } else {
- if (rv > 0)
- csio_info(hw, "Not using MSI-X, remainder:%d\n", rv);
-
+ cnt = pci_enable_msix_range(hw->pdev, entries, min, cnt);
+ if (cnt < 0) {
kfree(entries);
- return -ENOMEM;
+ return cnt;
+ }
+
+ if (cnt < (hw->num_sqsets + extra)) {
+ csio_dbg(hw, "Reducing sqsets to %d\n", cnt - extra);
+ csio_reduce_sqsets(hw, cnt - extra);
}
/* Save off vectors */
--
1.7.7.6
next prev parent reply other threads:[~2014-02-24 8:00 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 8:02 [PATCH v2 00/23] scsi: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-02-24 8:02 ` [PATCH v2 01/23] be2iscsi: Use pci_enable_msix_exact() " Alexander Gordeev
2014-03-11 17:06 ` Jayamohan Kallickal
2014-02-24 8:02 ` [PATCH v2 02/23] bfa: Do not call pci_enable_msix() after it failed once Alexander Gordeev
2014-03-02 8:01 ` Anil Gurumurthy
2014-02-24 8:02 ` [PATCH v2 03/23] bfa: Cleanup bfad_setup_intr() function Alexander Gordeev
2014-03-02 8:02 ` Anil Gurumurthy
2014-02-24 8:02 ` [PATCH v2 04/23] bfa: Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
2014-02-24 8:02 ` [PATCH v2 05/23] csiostor: Remove superfluous call to pci_disable_msix() Alexander Gordeev
2014-02-24 8:02 ` Alexander Gordeev [this message]
2014-02-24 8:02 ` [PATCH v2 07/23] fnic: Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
2014-02-24 8:02 ` [PATCH v2 08/23] hpsa: Fallback to MSI rather than to INTx if MSI-X failed Alexander Gordeev
2014-02-24 8:02 ` [PATCH v2 09/23] hpsa: Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
2014-02-24 8:02 ` [PATCH v2 10/23] isci: " Alexander Gordeev
2014-03-03 13:56 ` Dorau, Lukasz
2014-02-24 8:02 ` [PATCH v2 11/23] lpfc: Remove superfluous call to pci_disable_msix() Alexander Gordeev
2014-02-24 8:02 ` [PATCH v2 12/23] lpfc: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-02-24 8:02 ` [PATCH v2 13/23] megaraid: Fail resume if MSI-X re-initialization failed Alexander Gordeev
2014-02-24 8:02 ` [PATCH v2 14/23] megaraid: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-02-24 8:02 ` [PATCH v2 15/23] mpt2sas: Use pci_enable_msix_exact() " Alexander Gordeev
2014-02-24 8:02 ` [PATCH v2 16/23] mpt3sas: " Alexander Gordeev
2014-02-24 8:02 ` [PATCH v2 17/23] pm8001: Fix invalid return when request_irq() failed Alexander Gordeev
2014-02-24 8:02 ` [PATCH v2 18/23] pm8001: Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
2014-02-24 8:02 ` [PATCH v2 19/23] pmcraid: Get rid of a redundant assignment Alexander Gordeev
2014-02-24 8:02 ` [PATCH v2 20/23] pmcraid: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-02-24 8:02 ` [PATCH v2 21/23] qla2xxx: " Alexander Gordeev
2014-02-24 8:02 ` [PATCH v2 22/23] qla4xxx: Use pci_enable_msix_exact() " Alexander Gordeev
2014-02-24 8:02 ` [PATCH v2 23/23] vmw_pvscsi: " Alexander Gordeev
2014-03-04 19:27 ` Arvind Kumar
2014-02-25 8:37 ` [PATCH v2 00/23] scsi: Use pci_enable_msix_range() " Alexander Gordeev
2014-03-13 4:04 ` Bjorn Helgaas
2014-03-13 7:04 ` James Bottomley
2014-04-02 11:49 ` Alexander Gordeev
2014-04-02 17:00 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7d2dc937c290f25c179f2ebbe1fcdb79e13b010.1393191330.git.agordeev@redhat.com \
--to=agordeev@redhat.com \
--cc=arvindb@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=naresh@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).