The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Lukasz Majczak <lma@chromium.org>,
	Gwendal Grignou <gwendal@chromium.org>,
	Lee Jones <lee@kernel.org>, Benson Leung <bleung@chromium.org>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Tzung-Bi Shih <tzungbi@kernel.org>,
	Radoslaw Biernacki <biernacki@google.com>
Cc: linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev,
	linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] drivers: watchdog: Add ChromeOS EC watchdog
Date: Wed, 17 Jan 2024 16:29:52 +0100	[thread overview]
Message-ID: <c7ddec3b-2304-4d7f-80da-0074c1d68cc0@kernel.org> (raw)
In-Reply-To: <20240117102450.4080839-1-lma@chromium.org>

On 17/01/2024 11:24, Lukasz Majczak wrote:

Few more nits:

> This adds EC-based watchdog support for ChromeOS

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

> based devices equipped with embedded controller (EC).
> 

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.

And not a nit - important:

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Tools are doing it automatically, so either you work on some ancient
tree (don't), on fork of kernel (don't) or ignore some maintainers
(really don't).

Best regards,
Krzysztof


  parent reply	other threads:[~2024-01-17 15:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-17 10:24 [PATCH] drivers: watchdog: Add ChromeOS EC watchdog Lukasz Majczak
2024-01-17 15:27 ` Krzysztof Kozlowski
2024-01-18 17:28   ` Łukasz Majczak
2024-01-17 15:29 ` Krzysztof Kozlowski [this message]
2024-01-17 16:23 ` Guenter Roeck
2024-01-18 18:08   ` Łukasz Majczak
2024-01-18 18:17     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7ddec3b-2304-4d7f-80da-0074c1d68cc0@kernel.org \
    --to=krzk@kernel.org \
    --cc=biernacki@google.com \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=gwendal@chromium.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=lma@chromium.org \
    --cc=tzungbi@kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox