From: Naman Jain <namjain@linux.microsoft.com>
To: Michael Kelley <mhklinux@outlook.com>,
"K . Y . Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H . Peter Anvin" <hpa@zytor.com>
Cc: "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Mukesh Rathor <mrathor@linux.microsoft.com>,
Stanislav Kinsburskii <skinsburskii@linux.microsoft.com>,
Nuno Das Neves <nunodasneves@linux.microsoft.com>,
Christoph Hellwig <hch@infradead.org>,
Saurabh Sengar <ssengar@linux.microsoft.com>,
ALOK TIWARI <alok.a.tiwari@oracle.com>
Subject: Re: [PATCH v10 2/2] Drivers: hv: Introduce mshv_vtl driver
Date: Thu, 6 Nov 2025 22:33:06 +0530 [thread overview]
Message-ID: <c7e53740-ed96-470c-b16a-46061a9dfac7@linux.microsoft.com> (raw)
In-Reply-To: <SN6PR02MB41574847FF9B66A3D7321167D4C2A@SN6PR02MB4157.namprd02.prod.outlook.com>
On 11/6/2025 8:24 PM, Michael Kelley wrote:
> From: Naman Jain <namjain@linux.microsoft.com> Sent: Tuesday, October 28, 2025 10:02 PM
>>
>> Provide an interface for Virtual Machine Monitor like OpenVMM and its
>> use as OpenHCL paravisor to control VTL0 (Virtual trust Level).
>> Expose devices and support IOCTLs for features like VTL creation,
>> VTL0 memory management, context switch, making hypercalls,
>> mapping VTL0 address space to VTL2 userspace, getting new VMBus
>> messages and channel events in VTL2 etc.
>>
>> Co-developed-by: Roman Kisel <romank@linux.microsoft.com>
>> Signed-off-by: Roman Kisel <romank@linux.microsoft.com>
>> Co-developed-by: Saurabh Sengar <ssengar@linux.microsoft.com>
>> Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
>> Signed-off-by: Naman Jain <namjain@linux.microsoft.com>
>> ---
>> arch/x86/hyperv/Makefile | 10 +-
>> arch/x86/hyperv/hv_vtl.c | 43 +
>> arch/x86/hyperv/mshv-asm-offsets.c | 37 +
>> arch/x86/hyperv/mshv_vtl_asm.S | 98 ++
>> arch/x86/include/asm/mshyperv.h | 34 +
>> drivers/hv/Kconfig | 26 +-
>> drivers/hv/Makefile | 7 +-
>> drivers/hv/mshv_vtl.h | 25 +
>> drivers/hv/mshv_vtl_main.c | 1392 ++++++++++++++++++++++++++++
>> include/hyperv/hvgdk_mini.h | 106 +++
>> include/uapi/linux/mshv.h | 80 ++
>> 11 files changed, 1855 insertions(+), 3 deletions(-)
>> create mode 100644 arch/x86/hyperv/mshv-asm-offsets.c
>> create mode 100644 arch/x86/hyperv/mshv_vtl_asm.S
>> create mode 100644 drivers/hv/mshv_vtl.h
>> create mode 100644 drivers/hv/mshv_vtl_main.c
>>
>
> I've reviewed and made suggestions on most of this code pretty
> carefully over the past few months and through 10 revisions. This
> version addresses my suggestions and looks good to me. There
> are a few areas, such as the assembly code in mshv_vtl_asm.S and
> the details of the hypervisor ABI for doing VTL Return, that are
> outside my area of expertise so I'm limited to a surface level
> review.
>
> Reviewed-by: Michael Kelley <mhklinux@outlook.com>
Thanks for the review Michael.
Regards
Naman
prev parent reply other threads:[~2025-11-06 17:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 5:01 [PATCH v10 0/2] Drivers: hv: Introduce new driver - mshv_vtl Naman Jain
2025-10-29 5:01 ` [PATCH v10 1/2] Drivers: hv: Export some symbols for mshv_vtl Naman Jain
2025-11-06 14:45 ` Michael Kelley
2025-11-06 14:49 ` Peter Zijlstra
2025-11-06 17:02 ` Naman Jain
2025-10-29 5:01 ` [PATCH v10 2/2] Drivers: hv: Introduce mshv_vtl driver Naman Jain
2025-11-06 14:54 ` Michael Kelley
2025-11-06 17:03 ` Naman Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7e53740-ed96-470c-b16a-46061a9dfac7@linux.microsoft.com \
--to=namjain@linux.microsoft.com \
--cc=alok.a.tiwari@oracle.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhklinux@outlook.com \
--cc=mingo@redhat.com \
--cc=mrathor@linux.microsoft.com \
--cc=nunodasneves@linux.microsoft.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=seanjc@google.com \
--cc=skinsburskii@linux.microsoft.com \
--cc=ssengar@linux.microsoft.com \
--cc=tglx@linutronix.de \
--cc=wei.liu@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox