From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f50.google.com (mail-oo1-f50.google.com [209.85.161.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE3A538910F for ; Sat, 8 Aug 2026 18:38:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786214319; cv=none; b=l9dSbJHTGnIU8LZfm1Y2QRF41sf7OOC+sRGnP37LmvoYZW7+uZ3X15R6HhuzflT8tYs+3h7LCCHoabgFyGf4INrAdUuILXwbxIwW7bKsV2RPT0ROWCBfjS/ELDrNWSj8btdV/THohsTKWJoYFt5JStErLbq27r9SlWV7+ansA+U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786214319; c=relaxed/simple; bh=K2TOovoxyOuQXz0NUxhR+aOkqI/H40z4teyVi6PX3F0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PtluJtbLvTATZCCDHRF5lFUNzisvp7tPUPH1tyOubb2gsJvkZ3N/D2/7Xj3P2NfbXG1qwLFhdKgpJ0jeJ3dLAnNgHpvpKzB3pF1V7KrwkuVt1QiKwnXfsxCWP21q4vIMPp8RekLM8yJKYEfFvMD51rk7PRZnH1WAvUxVqVOCUrI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=Eu/twQzC; arc=none smtp.client-ip=209.85.161.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="Eu/twQzC" Received: by mail-oo1-f50.google.com with SMTP id 006d021491bc7-6acbf97e9a1so317085eaf.1 for ; Sat, 08 Aug 2026 11:38:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1786214317; x=1786819117; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BYohLP+0c4lv6k8Vs2Mp24gW1cAJvUuJNgonaHAKjlI=; b=Eu/twQzCrd6A23ES5ns+4/7Ns/rHO95wM3c9D/PpuV+C1EYQJSXmG+RINA0GzL+N/n FPmG7TwvIgjivH8fAdH+6RJXkAJdZe1iaQW2+We0aBurNIoMKKbh4JszK5yH6e+St+F+ 3tiQWPWVopOKCvyEcw0BPSNEk/pA5p8Z6ICP/emv0UVU0ojC6i6cfCMQZSYC4yA0ArUs AAunM3eLcdlTw6Hkkqm+q6y/bNcCzIvseRemHnTTunC++iz8p4e4wwCNpXEX7/m0Eool 0KrP9yLS9vSenSu9rqABgc8YrxBIcbPdoTrzpFfi3NtrBSe9g9xfW98q12j3SdQaIlpW YhJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786214317; x=1786819117; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BYohLP+0c4lv6k8Vs2Mp24gW1cAJvUuJNgonaHAKjlI=; b=nyjLOmNVRkctk7evLEj50xH8OfiAOrYsl0k53l7U+Yv/NauMhRQXghU4KK19gh+iLF oaAxfa5du3Wve04/Hot6HtKqHt1t67r4F/vWiNQqIpATB5ff7epU5ioCq0afBQWZmVr4 YzpDcxxkCJmmcdtSla0i0KBKiUdQmpNDT7O/fTpV0lJsxfa6dP4jjVB4lhmmPgyXm72X /LQZg6dLpkOEz9KoJMsmg47JS1xz5TkS9wdG0Vpg2hZU0V3mhEWxEuCvN/9X+RR0u0k5 m9qk9ja+3PdjlvoRVfqd/co4mF93EPEErdBVlOtNb6vGqMX6sgW8z/y+FOkRcLI/K332 YWtA== X-Forwarded-Encrypted: i=1; AHgh+RqbPTjPd2y+PzALFXHQDNV8tUvYgJcx3d3HpMGir1ZHPF7eWA1mdAk9XG6TQ/eFyYXXm3qZbnscT66bUZM=@vger.kernel.org X-Gm-Message-State: AOJu0YzghZAJ1tsFT5+HSazaBX/uViHg6mL7HIDmOMz88FT33LfroNjL IbBkFZAFJFYxMoY07G64K4k35rVsez6YG7Y7QGoCv5HLfLkgLjB5DB+fuuf93nngBuc= X-Gm-Gg: AR+sD11isrplkkI31F82IrqGmmhy+lG0JFObjPqBqvjMvAGwI8Ge8F1We8BqD9nr7km RjtED6MYFrGbc8Lg0u87uo/AdounBmN08plG9iNi8dLxXh/o8/TB6cDTvkAI6xT92snt54Egj3j jTLoG6OMa1FpM5eolb78w+Y/3QF9eEuWeSJ7+bgAnUHBtgnIm6SyQNP/hR+9Vev84ZsUWaXSe90 uEXvAL2+6IPc56gD645XzsrBu3Tg9vzila8SibCMViqokjJLv0m5bp1C+vX5euQ0iR9h6kH/Dtn Jv59dVzmYof6mM8HBoU4wLdm4iQcFxCY+puh3zQ5OOPWmHxLjmKwsKo7utH1LH77h/+MNLlohuy /F3ysfaD8lHM7Kn9tQpREcS5WsFyjZHpNS0ZQd5JOfWcqCjytUyudPWqf1DSmavkp7orWNj3K7X CTsTbxvwDGCcvBhL1nPnSIpzpxPTWkrc6NhAe2PuL39G5pwRfI+aLX210rFygWxJFNiGk4JvHoC fFUtCjb3CLSAyF6BYsYSqG5ibXfDBasQh8MhWg= X-Received: by 2002:a05:6820:c3c9:b0:6b0:5233:f69a with SMTP id 006d021491bc7-6b05233f906mr1653779eaf.30.1786214316792; Sat, 08 Aug 2026 11:38:36 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:99c2:f16e:201c:3bb5? ([2600:8803:e7e4:500:99c2:f16e:201c:3bb5]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6b02be9294fsm5236394eaf.13.2026.08.08.11.38.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 08 Aug 2026 11:38:36 -0700 (PDT) Message-ID: Date: Sat, 8 Aug 2026 13:38:35 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/9] dt-bindings: iio: adc: support the TI ADS126x ADC family To: Kurt Borja , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bartosz Golaszewski Cc: =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org References: <20260807-ads126x-v3-0-f89925d72792@gmail.com> <20260807-ads126x-v3-1-f89925d72792@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260807-ads126x-v3-1-f89925d72792@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/7/26 10:58 PM, Kurt Borja wrote: > The ADS1262 and ADS1263 are 32-bit, 38.4-kSPS delta-sigma ADCs with an > integrated PGA, internal reference, excitation and burn-out current > sources for sensor biasing and diagnostics. The ADS1263 adds a second, > 24-bit delta-sigma ADC (ADC2) for background measurements. > ... > +patternProperties: > + "^ain([0-9]|com)-supply$": > + description: > + Common-mode voltage supply connected to AIN or AINCOM. > + > + "^refp[1-3]-supply$": > + description: > + Positive voltage reference connected to REFP1 (AIN0), REFP2 (AIN2) or > + REFP3 (AIN4). If not described, its assumed to be connected to ground > + (0V). Would we really have a case with a negative only reference? I would say if not described, assume the pin is free for other use. > + > + "^refn[1-3]-supply$": > + description: > + Negative voltage reference connected to REFN1 (AIN1), REFN2 (AIN3) or > + REFN3 (AIN5). If not described, its assumed to be connected to ground > + (0V). Assumption is only true when corresponding refp supply is described. Otherwise we should assume the pin is free for other uses. > + > + "^ti,refp[1-3]-refn[1-3]-resistor-ohms$": > + description: > + Magnitude of the external reference resistor connected between REFP > + and REFN. In ratiometric configurations, such as RTD measurements, the > + IDAC excitation current returns through this resistor, generating the > + reference voltage for the conversion. > + > + "^channel@[0-9]+$": > + $ref: /schemas/iio/adc/adc.yaml# > + unevaluatedProperties: false > + > + properties: > + reg: > + maxItems: 1 > + > + single-channel: > + minimum: 0 > + maximum: 10 > + > + common-mode-channel: > + minimum: 0 > + maximum: 10 > + default: 10 > + > + diff-channels: > + description: | > + In addition to the analog input pins 0 (AIN0) - 10 (AINCOM), there are > + special inputs that can be selected from the following values: > + 11: Temperature sensor monitor > + 12: Analog power supply monitor > + 13: Digital power supply monitor > + 14: TDAC test signal For reasons mentioned in the reply to the cover letter, I'm not a fan of the monitor channels here. > + items: > + minimum: 0 > + maximum: 14 > + ... > + input-chopping: true > + > + ti,idac-rotation: Should we make this one a standard property like input-chopping? > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + Automatically swap the IDAC1 and IDAC2 connections of alternate > + conversions. The ADC averages the alternate conversions to eliminate > + IDAC mismatch. > + ... > +examples: > + - | > + #include > + #include > + > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + adc@0 { > + compatible = "ti,ads1262"; > + reg = <0>; > + spi-max-frequency = <8000000>; > + spi-cpha; > + avdd-supply = <&avdd>; > + dvdd-supply = <&dvdd>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + interrupts-extended = <&gpio 0 IRQ_TYPE_EDGE_FALLING>; > + interrupt-names = "drdy"; > + > + /* Typical common mode voltage configuration */ > + aincom-supply = <&ads1262_vbias>; > + > + regulators { > + ads1262_vbias: vbias { > + regulator-name = "vbias"; The node name is already "vbias" so giving regulator-name is redundant. > + }; > + }; > + > + channel@0 { > + reg = <0>; > + single-channel = <0>; > + /* The VBIAS is enabled on pin 10 (AINCOM) */ > + common-mode-channel = <10>; > + }; > + }; > + }; > +