From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 543AA2BDC09 for ; Mon, 15 Sep 2025 13:58:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757944738; cv=none; b=bxz/RIMN0ak3NjXn0ZAZvdqFdvcKnYYe5Xbt9c2rUTaCUFszfy8MMAJnRnnBcpCKlQM3eTAzC/j0btGfKZwHFS/M8cdm0udACZLf5Ri84F/Ly/CWyHz8wWMmtMMY5wFwLGeDKcn2TZpgUTmkN7HZlWgWjWXg1I1TB3RduiGRytk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757944738; c=relaxed/simple; bh=I7v+5IF3MJLM8aJokyMDXiOPATGx8skEeIfa859qBmw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uBNF2nmLXQVeDDQ9UNzA3hfSIJT3MOGN0KV9h5Lj2ASxT/dAr/loK625WMaYMJluMBlzRCCbN1PAtASjX+qj1kq1pEFGfhMeOKVQ/VVcx0OU6x4rb/gLUX5m80CkS257Y833Bh8TNRHiPB0a5WcsQTVvBGT+hNDm6FL4hHKP+YI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=S3feqcNk; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="S3feqcNk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757944735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KplBuZ22IZOGWRL/FpbuNQDyW9jhWweOev+kRyWsIQM=; b=S3feqcNkbunBh9gNb5iIH57a7lf9rcINtKZ1EIbL7Ld7+R5HMtd4wiIIZShu6dtGNszkAp Qj2yhD30gRKozfuqK+ydgEtE92s5x6CD5bZ/q6qeE8TsYYA/VLpzs4COnYMbfCuEUVzZMD B5MJnxHrUxTPV4iMGJmyGUX4zgrJht0= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-580-ISvLntYcPYyX-fJeAsQ_7Q-1; Mon, 15 Sep 2025 09:58:52 -0400 X-MC-Unique: ISvLntYcPYyX-fJeAsQ_7Q-1 X-Mimecast-MFC-AGG-ID: ISvLntYcPYyX-fJeAsQ_7Q_1757944731 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-45deddf34b9so30807945e9.1 for ; Mon, 15 Sep 2025 06:58:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757944731; x=1758549531; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KplBuZ22IZOGWRL/FpbuNQDyW9jhWweOev+kRyWsIQM=; b=eGHN2rrF51pR0YFw9ut7lU66WIixPPSoWBzJvyDB7hV1eb2rBGwHu/Zffa2rFmJgPM ME0lqGyKo16zhbezi1DmwVybYQ0WM5pEhjL3xbsz5WK6ihcIftA+cmssGR3sCYc92z7R IP4xbzHQpv3pw51mZupGnAKKl9+uza9Vbvj31kjz8fFhuC0ycGp7qL4ix7MlTMo3ntS0 JGo0rWjuKfKostT7RWl8cz2TKuCJdctZ3CHXovTKBSUkpmTxJi3fQiFALm2ou4nMgG7w y4zc5q/CjD1zUIpCLCBjVZ3xDXPja0H3F/4MFXfJ6hjt8RiS97tqqlNBZsTOwBrh/nAK lhtg== X-Forwarded-Encrypted: i=1; AJvYcCVGH1MuGo2f9xw1++boCfyxJEaV6AyBDbVvVo+TJ5/ffTA8LrGOEgygmVhK4uUM17CIErgoUfEyH0Hks2M=@vger.kernel.org X-Gm-Message-State: AOJu0YxxTHgDqualE1qjy8+cswfnNdX6PAj4o3zzVOWLf+c1aflNAYBx bDxmdxAW9J9f61ar6Bn7zH2OuwzGHNMAoXtxz8Ujue6QgpKacTHie5yieC+JgqAQS6COktPKHkr 5Sya/Bs1V2zJ3LJUhcwtwU5gbRSdO/UcExfp+8IzZ90S5sSh3eAD9qmo1/DW8XCj95g== X-Gm-Gg: ASbGncstAeugXWXVi7yBufGb/VfVz/UYTgLwjYfcGQK1KncO7DRjS/8p073UDcfhZ7u K65kJm1c2sxHDui7EicQiftyZSAcjqqyaFLWipEUKpj5AHNSbrYkLev0tPwO80CuTJXjTcMRfgF qmNGDlWMSUVJDqkFxEfMfa/SLP41QY093m93IcgtKu5JHlEs1isUQqOrmTz4DN0gLVPXEK9og+H OiHh5zIP7joDKhhc3/J6WJc1wumvrDeD6hcrQoigkaij7sv6uSxh8gHEUhDSfNSdUQme5jWiiNx 0Lcz2OAgzvtJQNx4xHCv6JI6RQyqJCkJi84fgj4Obq9szmnL/EEq21WCtvseAhh6HIPdROyL7ar eLwQfa9HWoCoJQbeeJ36FF5hzM7oZzm0A6Svf9DsvB6VVgr75ZzNVU2QRGeLOsjfPayc= X-Received: by 2002:a05:6000:2203:b0:3ea:c893:95b6 with SMTP id ffacd0b85a97d-3eac89399f3mr2857014f8f.27.1757944731376; Mon, 15 Sep 2025 06:58:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFIBtT4aq3cbJaZEsloIj9LKZOAl7+0MXz1dTLWOlVPNL7ugkjzjyk5jkvOXhyuIKcyfXFb/Q== X-Received: by 2002:a05:6000:2203:b0:3ea:c893:95b6 with SMTP id ffacd0b85a97d-3eac89399f3mr2856982f8f.27.1757944730925; Mon, 15 Sep 2025 06:58:50 -0700 (PDT) Received: from ?IPV6:2003:d8:2f18:f900:e0ae:65d5:8bf8:8cfd? (p200300d82f18f900e0ae65d58bf88cfd.dip0.t-ipconnect.de. [2003:d8:2f18:f900:e0ae:65d5:8bf8:8cfd]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e859a278c1sm10646171f8f.24.2025.09.15.06.58.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Sep 2025 06:58:50 -0700 (PDT) Message-ID: Date: Mon, 15 Sep 2025 15:58:49 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv2] mm/khugepaged: Do not fail collapse_pte_mapped_thp() on SCAN_PMD_NULL To: Kiryl Shutsemau , Andrew Morton , Lorenzo Stoakes Cc: Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 15.09.25 15:52, Kiryl Shutsemau wrote: > From: Kiryl Shutsemau > > MADV_COLLAPSE on a file mapping behaves inconsistently depending on if > PMD page table is installed or not. > > Consider following example: > > p = mmap(NULL, 2UL << 20, PROT_READ | PROT_WRITE, > MAP_SHARED, fd, 0); > err = madvise(p, 2UL << 20, MADV_COLLAPSE); > > fd is a populated tmpfs file. > > The result depends on the address that the kernel returns on mmap(). > If it is located in an existing PMD table, the madvise() will succeed. > However, if the table does not exist, it will fail with -EINVAL. > > This occurs because find_pmd_or_thp_or_none() returns SCAN_PMD_NULL when > a page table is missing, which causes collapse_pte_mapped_thp() to fail. > > SCAN_PMD_NULL and SCAN_PMD_NONE should be treated the same in > collapse_pte_mapped_thp(): install the PMD leaf entry and allocate page > tables as needed. > > Signed-off-by: Kiryl Shutsemau > --- Acked-by: David Hildenbrand -- Cheers David / dhildenb