From: Krzysztof Kozlowski <krzk@kernel.org>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Hiago De Franco <hiagofranco@gmail.com>,
Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Hiago De Franco <hiago.franco@toradex.com>
Subject: Re: [PATCH 1/3] ARM: dts: imx6qdl-apalis: Update audio card name
Date: Mon, 9 Sep 2024 19:44:12 +0200 [thread overview]
Message-ID: <c856ab91-2011-470e-84da-1ba08569844d@kernel.org> (raw)
In-Reply-To: <20240909125419.GA33114@francesco-nb>
On 09/09/2024 14:54, Francesco Dolcini wrote:
> Hello Krzysztof,
> thanks for the review/feedback.
>
> On Mon, Sep 09, 2024 at 02:09:11PM +0200, Krzysztof Kozlowski wrote:
>> On 09/09/2024 13:49, Hiago De Franco wrote:
>>> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi
>>> index edf55760a5c1..1c72da417011 100644
>>> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi
>>> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi
>>> @@ -191,7 +191,7 @@ sound {
>>> "MIC_IN", "Mic Jack",
>>> "Mic Jack", "Mic Bias",
>>> "Headphone Jack", "HP_OUT";
>>> - model = "imx6q-apalis-sgtl5000";
>>> + model = "apalis-imx6";
>>
>> Doesn't this break all the users? E.g. ALSA UCM and whatever
>> user-space-parsing stuff you have?
>
> I am not sure about "all" users, but for sure it's a breaking change.
> There is no ALSA UCM for this board (and also not for the other twos in
> this series), we just worked on it and we thought that if we want to do
> such a change the moment is now.
>
> What should we do?
For me is enough to explain in commit msg such expected (or lack of it)
impact.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-09 17:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 11:48 [PATCH 0/3] ARM: dts: imx[6qdl|7]-[apalis|colibri]: Update audio card names Hiago De Franco
2024-09-09 11:49 ` [PATCH 1/3] ARM: dts: imx6qdl-apalis: Update audio card name Hiago De Franco
2024-09-09 12:09 ` Krzysztof Kozlowski
2024-09-09 12:54 ` Francesco Dolcini
2024-09-09 17:44 ` Krzysztof Kozlowski [this message]
2024-09-09 11:49 ` [PATCH 2/3] ARM: dts: imx6qdl-colibri: " Hiago De Franco
2024-09-09 11:49 ` [PATCH 3/3] ARM: dts: imx7-colibri: " Hiago De Franco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c856ab91-2011-470e-84da-1ba08569844d@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=francesco@dolcini.it \
--cc=hiago.franco@toradex.com \
--cc=hiagofranco@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox