Re: [PATCH 1/3] ARM: dts: imx6qdl-apalis: Update audio card name

Krzysztof Kozlowski
2024-09-09T12:09:19Z

On 09/09/2024 13:49, Hiago De Franco wrote:
> From: Hiago De Franco <hiago.franco@toradex.com>
>
> Update the audio card name for Apalis iMX6 to match its specific SoM
> name, making it less than 15 characters to fix the following warning
>
> fsl-asoc-card sound: ASoC: driver name too long
> 'imx6q-apalis-sgtl5000' -> 'imx6q-apalis-sg'
>
> making it compliant with the ALSA configuration specification [1].
>
> [1] Documentation/sound/alsa-configuration.rst
>
> Signed-off-by: Hiago De Franco <hiago.franco@toradex.com>
> ---
> arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi
> index edf55760a5c1..1c72da417011 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi
> @@ -191,7 +191,7 @@ sound {
> "MIC_IN", "Mic Jack",
> "Mic Jack", "Mic Bias",
> "Headphone Jack", "HP_OUT";
> - model = "imx6q-apalis-sgtl5000";
> + model = "apalis-imx6";

Doesn't this break all the users? E.g. ALSA UCM and whatever
user-space-parsing stuff you have?

Best regards,
Krzysztof