From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>, Qais Yousef <qyousef@layalina.io>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Sudeep Holla <sudeep.holla@arm.com>, Wei Wang <wvw@google.com>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH] block/blk-mq: Don't complete locally if capacities are different
Date: Tue, 23 Jan 2024 08:58:48 -0700 [thread overview]
Message-ID: <c85898de-0780-4690-adfa-99332eae0090@kernel.dk> (raw)
In-Reply-To: <Za99LKnQE/M6pVfM@infradead.org>
On 1/23/24 1:47 AM, Christoph Hellwig wrote:
> On Mon, Jan 22, 2024 at 10:42:20PM +0000, Qais Yousef wrote:
>> The logic in blk_mq_complete_need_ipi() assumes SMP systems where all
>> CPUs have equal capacities
>
> What is a capacity here?
It seems to be the chosen word to describe the performance potential of
the core in question, we use it elsewhere in the kernel. But yes, could
do with a bit more of an explanation.
>> + return arch_scale_cpu_capacity(this_cpu) >= arch_scale_cpu_capacity(that_cpu);
>
> oerly long line here.
>
> Also pleas split patches for different subsystems.
Yes please, the sched/topology thing should be a separate prep patch.
--
Jens Axboe
next prev parent reply other threads:[~2024-01-23 15:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 22:42 [PATCH] block/blk-mq: Don't complete locally if capacities are different Qais Yousef
2024-01-23 8:47 ` Christoph Hellwig
2024-01-23 15:58 ` Jens Axboe [this message]
2024-01-24 0:24 ` Qais Yousef
2024-02-02 23:20 ` Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c85898de-0780-4690-adfa-99332eae0090@kernel.dk \
--to=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dietmar.eggemann@arm.com \
--cc=hch@infradead.org \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=qyousef@layalina.io \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=wvw@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox