Re: [PATCH v2 1/5] iommu/vt-d: Separate page request queue from SVM

Joel Granados
2024-09-16T09:24:29Z

On Sat, Sep 14, 2024 at 12:52:22AM +0000, Tian, Kevin wrote:
> > From: Joel Granados via B4 Relay
> > <devnull+j.granados.samsung.com@kernel.org>
> >
> > From: Joel Granados <j.granados@samsung.com>
> >
> > IO page faults are no longer dependent on CONFIG_INTEL_IOMMU_SVM.
> > Move
> > all Page Request Queue (PRQ) functions that handle prq events to a new
> > file in drivers/iommu/intel/prq.c. The page_req_des struct is now
> > declared in drivers/iommu/intel/prq.c.
> >
> > No functional changes are intended. This is a preparation patch to
> > enable the use of IO page faults outside the SVM/PASID use cases.
>
> Do we want to guard it under a new config option e.g.
> CONFIG_INTEL_IOMMU_IOPF? it's unnecessary to allocate resources
> for the majority usages which don't require IOPF.
>
> Baolu?
>
> > -#ifdef CONFIG_INTEL_IOMMU_SVM
> > if (pasid_supported(iommu)) {
> > if (ecap_prs(iommu->ecap))
> > - intel_svm_finish_prq(iommu);
> > + intel_finish_prq(iommu);
> > }
> > -#endif
>
> either intel_iommu_finish_prq() or intel_prq_finish().

Thx; I see the pattern now! The first (Adding "_iommu_" to the name)
makes more sense to me as I see some intel_iommu_* function further down
in the iommu.h file.

>
> same for other helpers.

Will change for the next version

Best

--

Joel Granados