RE: [PATCH v2 1/5] iommu/vt-d: Separate page request queue from SVM

Tian, Kevin
2024-09-14T00:52:30Z

> From: Joel Granados via B4 Relay
> <devnull+j.granados.samsung.com@kernel.org>
>
> From: Joel Granados <j.granados@samsung.com>
>
> IO page faults are no longer dependent on CONFIG_INTEL_IOMMU_SVM.
> Move
> all Page Request Queue (PRQ) functions that handle prq events to a new
> file in drivers/iommu/intel/prq.c. The page_req_des struct is now
> declared in drivers/iommu/intel/prq.c.
>
> No functional changes are intended. This is a preparation patch to
> enable the use of IO page faults outside the SVM/PASID use cases.

Do we want to guard it under a new config option e.g.
CONFIG_INTEL_IOMMU_IOPF? it's unnecessary to allocate resources
for the majority usages which don't require IOPF.

Baolu?

> -#ifdef CONFIG_INTEL_IOMMU_SVM
> if (pasid_supported(iommu)) {
> if (ecap_prs(iommu->ecap))
> - intel_svm_finish_prq(iommu);
> + intel_finish_prq(iommu);
> }
> -#endif

either intel_iommu_finish_prq() or intel_prq_finish().

same for other helpers.