public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Josua Mayer <josua@solid-run.com>
To: Frank Li <Frank.li@nxp.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Mikhail Anikin <mikhail.anikin@solid-run.com>,
	Yazan Shhady <yazan.shhady@solid-run.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v8 3/8] arm64: dts: imx8mp-hummingboard-pulse: fix mini-hdmi dsi port reference
Date: Thu, 29 Jan 2026 10:58:40 +0000	[thread overview]
Message-ID: <c87d6af5-f2b9-4a4d-bfcf-431c84e06601@solid-run.com> (raw)
In-Reply-To: <aXpD13sHZYoXGQY7@lizhi-Precision-Tower-5810>

On 28/01/2026 19:13, Frank Li wrote:
> On Wed, Jan 28, 2026 at 06:21:27PM +0200, Josua Mayer wrote:
>> imx8mp.dtsi includes a default port@1 node with an empty placeholder
>> endpoint intended for linking to a dsi bridge or panel.
>>
>> HummingBoard Pulse mini-hdmi dtsi added and linked hdmi bridge to yet
>> another endpoint.
>>
>> This duplicate endpoint can cause dsi_attach to fail.
> Can you add descript about why duplicate endpoint cause fail?

I didn't debug this in detail. Basic observation was as follows:

I was under the impression that two endpoint nodes ended up in the final 
dtb,
with different phandles which made the remote-endpoint references 
inconsistent.

I'd prefer not to explain in detail what happened, and focus on removing
inconsistency from the dts.

>
> Frank
>> Remove the duplicate node and link to the one defined in soc dtsi.
>> Further remove the unnecessary attach-bridge property.
>>
>> Fixes: 2a222aa2bee9 ("arm64: dts: add description for solidrun imx8mp hummingboard variants")
>> Signed-off-by: Josua Mayer <josua@solid-run.com>
>> ---
>>   .../dts/freescale/imx8mp-hummingboard-pulse-mini-hdmi.dtsi    | 11 ++++-------
>>   1 file changed, 4 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-hummingboard-pulse-mini-hdmi.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-hummingboard-pulse-mini-hdmi.dtsi
>> index 46916ddc0533..0e5f4607c7c1 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mp-hummingboard-pulse-mini-hdmi.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mp-hummingboard-pulse-mini-hdmi.dtsi
>> @@ -41,7 +41,7 @@ port@0 {
>>   				reg = <0>;
>>
>>   				adv7535_from_dsim: endpoint {
>> -					remote-endpoint = <&dsim_to_adv7535>;
>> +					remote-endpoint = <&mipi_dsi_out>;
>>   				};
>>   			};
>>
>> @@ -71,11 +71,8 @@ &lcdif1 {
>>   &mipi_dsi {
>>   	samsung,esc-clock-frequency = <10000000>;
>>   	status = "okay";
>> +};
>>
>> -	port@1 {
>> -		dsim_to_adv7535: endpoint {
>> -			remote-endpoint = <&adv7535_from_dsim>;
>> -			attach-bridge;
>> -		};
>> -	};
>> +&mipi_dsi_out {
>> +	remote-endpoint = <&adv7535_from_dsim>;
>>   };
>>
>> --
>> 2.43.0
>>
>>


  reply	other threads:[~2026-01-29 10:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-28 16:21 [PATCH v8 0/8] arm64: dts: add description for solidrun imx8mp hummingboard-iiot Josua Mayer
2026-01-28 16:21 ` [PATCH v8 1/8] dt-bindings: arm: fsl: Add various solidrun i.mx8m boards Josua Mayer
2026-01-28 16:21 ` [PATCH v8 2/8] arm64: dts: imx8mp-hummingboard-pulse/cubox-m: fix vmmc gpio polarity Josua Mayer
2026-01-28 17:10   ` Frank Li
2026-01-28 16:21 ` [PATCH v8 3/8] arm64: dts: imx8mp-hummingboard-pulse: fix mini-hdmi dsi port reference Josua Mayer
2026-01-28 17:13   ` Frank Li
2026-01-29 10:58     ` Josua Mayer [this message]
2026-01-28 16:21 ` [PATCH v8 4/8] arm64: dts: imx8mp-sr-som: build dtbs with symbols for overlay support Josua Mayer
2026-01-28 17:19   ` Frank Li
2026-01-28 16:21 ` [PATCH v8 5/8] arm64: dts: add support for SolidRun i.MX8MP HummingBoard IIoT Josua Mayer
2026-01-28 17:24   ` Frank Li
2026-01-29 10:49     ` Josua Mayer
2026-01-29 16:17       ` Frank Li
2026-02-05 11:00         ` Josua Mayer
2026-01-28 16:21 ` [PATCH v8 6/8] arm64: dts: imx8mp-hummingboard-iiot: add dt overlays for muxable ports Josua Mayer
2026-01-28 16:21 ` [PATCH v8 7/8] arm64: dts: add description for solidrun solidsense-n8 board Josua Mayer
2026-01-28 16:21 ` [PATCH v8 8/8] arm64: dts: add description for solidrun i.mx8mm som and evb Josua Mayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c87d6af5-f2b9-4a4d-bfcf-431c84e06601@solid-run.com \
    --to=josua@solid-run.com \
    --cc=Frank.li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikhail.anikin@solid-run.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=yazan.shhady@solid-run.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox