From: Joe Perches <joe@perches.com>
To: Christian Brauner <christian.brauner@ubuntu.com>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] .clang-format: update column limit
Date: Wed, 10 Jun 2020 10:13:24 -0700 [thread overview]
Message-ID: <c8851256aa453461481233e8a7fea878f9580c5b.camel@perches.com> (raw)
In-Reply-To: <20200610125147.2782142-1-christian.brauner@ubuntu.com>
On Wed, 2020-06-10 at 14:51 +0200, Christian Brauner wrote:
> The provided clang-format file wraps at 80 chars. If noone minds I'd like
> to adjust this limit to 100 similar to what checkpatch (cf. [1]) uses now.
>
> [1]: commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning")
> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
[]
> diff --git a/.clang-format b/.clang-format
[]
> @@ -52,7 +52,7 @@ BreakConstructorInitializersBeforeComma: false
> #BreakConstructorInitializers: BeforeComma # Unknown to clang-format-4.0
> BreakAfterJavaFieldAnnotations: false
> BreakStringLiterals: false
> -ColumnLimit: 80
> +ColumnLimit: 100
Ii think this is a not a good change.
If you read the commit log you provided, it ways
"staying withing 80 columns is certainly still _preferred_"
With this change, clang would _always_ wrap to 100 columns.
clang would not make any reasonable attempt to use 80 when
it should.
next prev parent reply other threads:[~2020-06-10 17:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 12:51 [PATCH] .clang-format: update column limit Christian Brauner
2020-06-10 15:55 ` Miguel Ojeda
2020-06-10 15:58 ` Nathan Chancellor
2020-06-10 16:23 ` Sedat Dilek
2020-06-10 17:13 ` Joe Perches [this message]
2020-06-10 17:32 ` Christian Brauner
2020-06-11 10:03 ` Miguel Ojeda
2020-06-11 10:36 ` Joe Perches
2020-06-11 11:54 ` Miguel Ojeda
2020-06-11 16:22 ` Joe Perches
2020-06-11 18:51 ` Miguel Ojeda
2020-06-11 19:26 ` Joe Perches
2020-06-22 0:03 ` Miguel Ojeda
2023-12-18 10:18 ` Alexander Potapenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8851256aa453461481233e8a7fea878f9580c5b.camel@perches.com \
--to=joe@perches.com \
--cc=christian.brauner@ubuntu.com \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox