From: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Hugo Villeneuve <hugo@hugovil.com>, <agross@kernel.org>,
<konrad.dybcio@linaro.org>, <gregkh@linuxfoundation.org>,
<jirislaby@kernel.org>, <bartosz.golaszewski@linaro.org>,
<linux-arm-msm@vger.kernel.org>, <linux-serial@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <quic_msavaliy@quicinc.com>,
<dianders@chromium.org>, <mka@chromium.org>,
<swboyd@chromium.org>, <quic_vtanuku@quicinc.com>
Subject: Re: [PATCH RESEND] tty: serial: qcom-geni-serial: Poll primary sequencer irq status after cancel_tx
Date: Mon, 14 Aug 2023 23:14:47 +0530 [thread overview]
Message-ID: <c88fa667-c746-e9da-1ae0-e469607e366d@quicinc.com> (raw)
In-Reply-To: <7mdlnuxzm7rxstl2r3kyyiuefbj3wpyqprzufdrsxe7hy5fvfo@tdwfhi6a27hj>
Thank you very much, Hugo Villeneuve and Bjorn, for the review and time.
If this one doesn't get merged, I will post another patch series incorporating suggestions (including splitting) along with few more changes.
-Vijay/
On 8/10/2023 8:06 PM, Bjorn Andersson wrote:
> On Wed, Aug 09, 2023 at 10:51:54PM +0530, Vijaya Krishna Nivarthi wrote:
>> Hi,
>>
>> Thank you very much for the review...
>>
> Thank you for the bug fix, Vijaya.
>
>> On 8/9/2023 6:49 PM, Hugo Villeneuve wrote:
>>> On Wed, 9 Aug 2023 17:41:40 +0530
>>> Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com> wrote:
>>>
>>>> TX is handled by primary sequencer. After cancelling primary command, poll
>>>> primary sequencer's irq status instead of that of secondary.
>>> Hi,
>>> it is not clear to me if this is a bug fix or an improvement?
>> This is a bug fix.
> Please describe the actual problem you're solving, to allow others
> working in and around this driver to know what issue(s) are corrected.
>
> This will save others debugging time, and it will teach others to help
> you maintain this driver.
>
> The section in the documentation on how to describe your changes is
> good, please read it:
> https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
>
>>>> While at it, also remove a couple of redundant lines that read from IRQ_EN
>>>> register and write back same.
>>> This should go into a separate patch.
>> The changes were too close by so I wasn't sure it could be split into 2
>> patches.
>>
>> I see that the earlier patch has already been signed off by Greg. (I did a
>> RESEND after realising that I had Bjorn Andersson's email address incorrect)
> Please use ./scripts/get_maintainer.pl on the upstream tree, as this
> uses up to date information about recipients.
>
>> Will post another version if original patch doesn't get merged for any
>> reason.
>>
> Please double check linux-next [1], if it's unclear if Greg picked up
> your previous patch (he's usually quite explicit about it...). I really
> would like some more details on the bug fix...
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/
>
> Regards,
> Bjorn
next prev parent reply other threads:[~2023-08-14 17:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 12:11 [PATCH RESEND] tty: serial: qcom-geni-serial: Poll primary sequencer irq status after cancel_tx Vijaya Krishna Nivarthi
2023-08-09 13:19 ` Hugo Villeneuve
2023-08-09 17:21 ` Vijaya Krishna Nivarthi
2023-08-10 14:36 ` Bjorn Andersson
2023-08-14 17:44 ` Vijaya Krishna Nivarthi [this message]
2023-08-09 19:40 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c88fa667-c746-e9da-1ae0-e469607e366d@quicinc.com \
--to=quic_vnivarth@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=hugo@hugovil.com \
--cc=jirislaby@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mka@chromium.org \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_vtanuku@quicinc.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox