From: SF Markus Elfring <elfring@users.sourceforge.net>
To: devel@driverdev.osuosl.org, lustre-devel@lists.lustre.org,
Andreas Dilger <andreas.dilger@intel.com>,
Ben Evans <bevans@cray.com>, Bobi Jam <bobijam.xu@intel.com>,
Emoly Liu <emoly.liu@intel.com>, Fan Yong <fan.yong@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Gregoire Pichon <gregoire.pichon@bull.net>,
Henri Doreau <henri.doreau@cea.fr>,
James Simmons <jsimmons@infradead.org>,
Jinshan Xiong <jinshan.xiong@intel.com>,
"John L. Hammond" <john.hammond@intel.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Lai Siyao <lai.siyao@intel.com>,
Oleg Drokin <oleg.drokin@intel.com>,
Sebastien Buisson <sbuisson@ddn.com>,
Stephen Champion <schamp@sgi.com>, wang di <di.wang@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 3/5] staging/lustre/obdclass: Use seq_putc() in four functions
Date: Sun, 1 Jan 2017 17:37:04 +0100 [thread overview]
Message-ID: <c88fdadd-bdef-7e7f-7704-487587693838@users.sourceforge.net> (raw)
In-Reply-To: <45ae8939-a775-865b-ade0-9e38a7ff2b5d@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 1 Jan 2017 16:12:23 +0100
A few single characters (line breaks) should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/staging/lustre/lustre/obdclass/cl_object.c | 4 ++--
drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/cl_object.c b/drivers/staging/lustre/lustre/obdclass/cl_object.c
index f5d4e23c64b7..277908d66a89 100644
--- a/drivers/staging/lustre/lustre/obdclass/cl_object.c
+++ b/drivers/staging/lustre/lustre/obdclass/cl_object.c
@@ -441,7 +441,7 @@ static int cache_stats_print(const struct cache_stats *cs,
seq_printf(m, "%6s", " ");
for (i = 0; i < CS_NR; i++)
seq_printf(m, "%8s", names[i]);
- seq_printf(m, "\n");
+ seq_putc(m, '\n');
}
seq_printf(m, "%5.5s:", cs->cs_name);
@@ -516,7 +516,7 @@ locks: ...... ...... ...... ...... ...... [...... ...... ...... ...... ......]
atomic_read(&site->cs_pages_state[i]));
seq_printf(m, "]\n");
cache_stats_print(&cl_env_stats, m, 0);
- seq_printf(m, "\n");
+ seq_putc(m, '\n');
return 0;
}
EXPORT_SYMBOL(cl_site_stats_print);
diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
index 2c99717b0aba..3f6fcab5a1fc 100644
--- a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
+++ b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
@@ -878,7 +878,7 @@ int lprocfs_at_hist_helper(struct seq_file *m, struct adaptive_timeout *at)
for (i = 0; i < AT_BINS; i++)
seq_printf(m, "%3u ", at->at_hist[i]);
- seq_printf(m, "\n");
+ seq_putc(m, '\n');
return 0;
}
EXPORT_SYMBOL(lprocfs_at_hist_helper);
@@ -946,7 +946,7 @@ int lprocfs_rd_connect_flags(struct seq_file *m, void *data)
flags = obd->u.cli.cl_import->imp_connect_data.ocd_connect_flags;
seq_printf(m, "flags=%#llx\n", flags);
obd_connect_seq_flags2str(m, flags, "\n");
- seq_printf(m, "\n");
+ seq_putc(m, '\n');
up_read(&obd->u.cli.cl_sem);
return 0;
}
--
2.11.0
next prev parent reply other threads:[~2017-01-01 16:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-01 16:30 [PATCH 0/5] staging-Lustre: Fine-tuning for some function implementations SF Markus Elfring
2017-01-01 16:33 ` [PATCH 1/5] staging/lustre/llite: Use seq_puts() in three functions SF Markus Elfring
2017-01-01 16:35 ` [PATCH 2/5] staging/lustre/mgc: Combine two seq_printf() calls into one call in lprocfs_mgc_rd_ir_state() SF Markus Elfring
2017-01-13 6:58 ` Oleg Drokin
2017-01-13 7:41 ` Greg Kroah-Hartman
2017-01-01 16:37 ` SF Markus Elfring [this message]
2017-01-01 16:38 ` [PATCH 4/5] staging/lustre/obdclass: Combine two seq_printf() calls into one call in lprocfs_rd_state() SF Markus Elfring
2017-01-13 6:59 ` Oleg Drokin
2017-01-01 16:40 ` [PATCH 5/5] staging/lustre/obdclass: Use seq_puts() in three functions SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c88fdadd-bdef-7e7f-7704-487587693838@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=andreas.dilger@intel.com \
--cc=bevans@cray.com \
--cc=bobijam.xu@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=di.wang@intel.com \
--cc=emoly.liu@intel.com \
--cc=fan.yong@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregoire.pichon@bull.net \
--cc=henri.doreau@cea.fr \
--cc=jinshan.xiong@intel.com \
--cc=john.hammond@intel.com \
--cc=jsimmons@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=lai.siyao@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
--cc=sbuisson@ddn.com \
--cc=schamp@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox