From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E9DBC433E1 for ; Fri, 12 Jun 2020 05:31:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DCA92083E for ; Fri, 12 Jun 2020 05:31:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="Cg2p8vyd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726537AbgFLFb2 (ORCPT ); Fri, 12 Jun 2020 01:31:28 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:36726 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725763AbgFLFb1 (ORCPT ); Fri, 12 Jun 2020 01:31:27 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 05C5UxHv105841; Fri, 12 Jun 2020 00:30:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1591939859; bh=CsA12+jay5u2Gva3INtQk/dUmPirKLYO9bGaNjt4rNo=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=Cg2p8vydUTWmNQ2lzOSyDSWmdqOebHooI/vMth+bh7pd/51rQC2ntnVLZH4Lvio5P uVhqDC8T3gST0DBveYMwe83KlQWQo63bBpBzPbyvL5i2bI3vuCswq4fpeMW4N5bP7L gl+ViholWzlFmh9GSDIrvxLutyvzt0Fh6zAaUTlE= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id 05C5UxcF111764; Fri, 12 Jun 2020 00:30:59 -0500 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Fri, 12 Jun 2020 00:30:58 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Fri, 12 Jun 2020 00:30:58 -0500 Received: from [10.250.233.85] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 05C5UsBx060089; Fri, 12 Jun 2020 00:30:54 -0500 Subject: Re: [PATCH v2 01/14] Documentation: PCI: Add specification for the *PCI NTB* function device To: Matthew Wilcox CC: Bjorn Helgaas , Jonathan Corbet , Lorenzo Pieralisi , Arnd Bergmann , Jon Mason , Dave Jiang , Allen Hubbe , Tom Joseph , Rob Herring , Greg Kroah-Hartman , , , , References: <20200611130525.22746-1-kishon@ti.com> <20200611130525.22746-2-kishon@ti.com> <20200611151301.GB8681@bombadil.infradead.org> From: Kishon Vijay Abraham I Message-ID: Date: Fri, 12 Jun 2020 11:00:53 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200611151301.GB8681@bombadil.infradead.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matthew, On 6/11/2020 8:43 PM, Matthew Wilcox wrote: > On Thu, Jun 11, 2020 at 06:35:12PM +0530, Kishon Vijay Abraham I wrote: >> +++ b/Documentation/PCI/endpoint/pci-ntb-function.rst >> @@ -0,0 +1,344 @@ >> +.. SPDX-License-Identifier: GPL-2.0 >> + >> +================= >> +PCI NTB Function >> +================= >> + >> +:Author: Kishon Vijay Abraham I >> + >> +PCI NTB Function allows two different systems (or hosts) to communicate >> +with each other by configurig the endpoint instances in such a way that >> +transactions from one system is routed to the other system. > > At no point in this document do you expand "NTB" into Non-Transparent > Bridge. The above paragraph probably also needs to say something like "By > making each host appear as a device to the other host". Although maybe > that's not entirely accurate? It's been a few years since I last played > with NTBs. > > So how about the following opening paragraph: > > PCI Non Transparent Bridges (NTB) allow two host systems to communicate > with each other by exposing each host as a device to the other host. > NTBs typically support the ability to generate interrupts on the remote > machine, expose memory ranges as BARs and perform DMA. They also support > scratchpads which are areas of memory within the NTB that are accessible > from both machines. > > ... feel free to fix that up if my memory is out of date or corrupted. I think that's accurate. I'll wait for review comments on the rest of the series and I'll fix this one in my next revision. Thanks Kishon