From: Shuah Khan <skhan@linuxfoundation.org>
To: 徐福海 <xufuhai1992@gmail.com>,
shuah@kernel.org, "Thomas Renninger" <trenn@suse.com>
Cc: xufuhai <xufuhai@kuaishou.com>,
lishujin@kuaishou.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v3 1/2] cpupower: Fix amd cpu (family < 0x17) active state issue
Date: Mon, 26 Jul 2021 14:04:14 -0600 [thread overview]
Message-ID: <c8aba22f-c61a-ef98-e3be-2102582dbffe@linuxfoundation.org> (raw)
In-Reply-To: <CAOkq_Bf4NABfLnfVczj3sh5=8EqQxdZZeFc_3rQ24TmBbN365g@mail.gmail.com>
On 7/23/21 12:23 AM, 徐福海 wrote:
> From: xufuhai<xufuhai1992@gmail.com> <mailto:xufuhai@kuaishou.com>
>
> For the old AMD processor (family < 0x17), cpupower will call the
> amd_pci_get_num_boost_states function, but for the non-root user
> pci_read_byte function (implementation comes from the psutil library),
> val will be set to 0xff, indicating that there is no read function
> callback. At this time, the original logic will set the cpupower turbo
> active state to yes. This is an obvious issue~
>
> Reproduce procedure:
> cpupower frequency-info
>
> Reported-by: yangrui<yangrui@kuaishou.com> <mailto:yangrui@kuaishou.com>
> Signed-off-by: xufuhai<xufuhai1992@gmail.com> <mailto:xufuhai@kuaishou.com>
> Signed-off-by: chenguanqiao<chenguanqiao@kuaishou.com> <mailto:chenguanqiao@kuaishou.com>
> Signed-off-by: lishujin<lishujin@kuaishou.com> <mailto:lishujin@kuaishou.com>
Please use your full names for the Signed-off-by - similar to the way you
would sign a legal document.
thanks,
-- Shuah
parent reply other threads:[~2021-07-26 20:04 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CAOkq_Bf4NABfLnfVczj3sh5=8EqQxdZZeFc_3rQ24TmBbN365g@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8aba22f-c61a-ef98-e3be-2102582dbffe@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lishujin@kuaishou.com \
--cc=shuah@kernel.org \
--cc=trenn@suse.com \
--cc=xufuhai1992@gmail.com \
--cc=xufuhai@kuaishou.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox