From: Florian Fainelli <f.fainelli@gmail.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"olteanv@gmail.com" <olteanv@gmail.com>,
"nikolay@nvidia.com" <nikolay@nvidia.com>
Subject: Re: [PATCH net-next v3 1/2] net: dsa: untag the bridge pvid from rx skbs
Date: Wed, 23 Sep 2020 15:06:33 -0700 [thread overview]
Message-ID: <c8ca2861-44b2-4333-d63e-638dfe2f06a0@gmail.com> (raw)
In-Reply-To: <20200923220121.phnctzovjkiw2qiz@skbuf>
On 9/23/20 3:01 PM, Vladimir Oltean wrote:
> On Wed, Sep 23, 2020 at 02:51:09PM -0700, Florian Fainelli wrote:
>> Speaking of that part of the code, I was also wondering whether you
>> wanted this to be netdev_for_each_upper_dev_rcu(br, upper_dev, iter) and
>> catch a bridge device upper as opposed to a switch port upper? Either
>> way is fine and there are possibly use cases for either.
>
> So, yeah, both use cases are valid, and I did in fact mean uppers of the
> bridge, but now that you're raising the point, do we actually support
> properly the use case with an 8021q upper of a bridged port? My
> understanding is that this VLAN-tagged traffic should not be switched on
> RX. So without some ACL rule on ingress that the driver must install, I
> don't see how that can work properly.
Is not this a problem only if the DSA master does VLAN receive filtering
though? In a bridge with vlan_filtering=0 the switch port is supposed to
accept any VLAN tagged frames because it does not do ingress VLAN ID
checking.
Prior to your patch, I would always install a br0.1 upper to pop the
default_pvid and that would work fine because the underlying DSA master
does not do VLAN filtering.
--
Florian
next prev parent reply other threads:[~2020-09-23 22:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 21:40 [PATCH net-next v3 0/2] net: dsa: b53: Configure VLANs while not filtering Florian Fainelli
2020-09-23 21:40 ` [PATCH net-next v3 1/2] net: dsa: untag the bridge pvid from rx skbs Florian Fainelli
2020-09-23 21:48 ` Vladimir Oltean
2020-09-23 21:51 ` Florian Fainelli
2020-09-23 22:01 ` Vladimir Oltean
2020-09-23 22:06 ` Florian Fainelli [this message]
2020-09-23 22:08 ` Florian Fainelli
2020-09-23 22:25 ` Vladimir Oltean
2020-09-23 22:49 ` Florian Fainelli
2020-09-23 22:54 ` Florian Fainelli
2020-09-23 22:58 ` Vladimir Oltean
2020-09-23 22:59 ` Florian Fainelli
2020-09-23 23:08 ` Vladimir Oltean
2020-09-24 4:27 ` Florian Fainelli
2020-09-23 21:40 ` [PATCH net-next v3 2/2] net: dsa: b53: Configure VLANs while not filtering Florian Fainelli
2020-09-24 1:14 ` [PATCH net-next v3 0/2] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8ca2861-44b2-4333-d63e-638dfe2f06a0@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox