From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Michael Straube <straube.linux@gmail.com>, gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove ODM_ConfigRFWithHeaderFile()
Date: Sat, 20 Aug 2022 15:03:08 +0200 [thread overview]
Message-ID: <c8ead88c-853e-c7b6-e2cf-1d210e5ada02@gmail.com> (raw)
In-Reply-To: <20220819182359.24141-1-straube.linux@gmail.com>
On 8/19/22 20:23, Michael Straube wrote:
> The function ODM_ConfigRFWithHeaderFile() is just a wrapper around
> ODM_ReadAndConfig_RadioA_1T_8188E(). Remove the wrapper and call
> ODM_ReadAndConfig_RadioA_1T_8188E() directly.
>
> Signed-off-by: Michael Straube <straube.linux@gmail.com>
> ---
> drivers/staging/r8188eu/hal/odm_HWConfig.c | 5 -----
> drivers/staging/r8188eu/hal/rtl8188e_rf6052.c | 2 +-
> drivers/staging/r8188eu/include/odm_HWConfig.h | 1 -
> 3 files changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/hal/odm_HWConfig.c b/drivers/staging/r8188eu/hal/odm_HWConfig.c
> index 54cc3d7789cd..035d94b3458e 100644
> --- a/drivers/staging/r8188eu/hal/odm_HWConfig.c
> +++ b/drivers/staging/r8188eu/hal/odm_HWConfig.c
> @@ -347,8 +347,3 @@ void ODM_PhyStatusQuery(struct odm_dm_struct *dm_odm,
> odm_RxPhyStatus92CSeries_Parsing(dm_odm, pPhyInfo, pPhyStatus, pPktinfo, adapt);
> odm_Process_RSSIForDM(dm_odm, pPhyInfo, pPktinfo);
> }
> -
> -enum HAL_STATUS ODM_ConfigRFWithHeaderFile(struct odm_dm_struct *dm_odm)
> -{
> - return ODM_ReadAndConfig_RadioA_1T_8188E(dm_odm);
> -}
> diff --git a/drivers/staging/r8188eu/hal/rtl8188e_rf6052.c b/drivers/staging/r8188eu/hal/rtl8188e_rf6052.c
> index d043b7bc4142..237232432f37 100644
> --- a/drivers/staging/r8188eu/hal/rtl8188e_rf6052.c
> +++ b/drivers/staging/r8188eu/hal/rtl8188e_rf6052.c
> @@ -396,7 +396,7 @@ static int phy_RF6052_Config_ParaFile(struct adapter *Adapter)
> udelay(1);/* PlatformStallExecution(1); */
>
> /*----Initialize RF fom connfiguration file----*/
> - if (HAL_STATUS_FAILURE == ODM_ConfigRFWithHeaderFile(&pHalData->odmpriv))
> + if (ODM_ReadAndConfig_RadioA_1T_8188E(&pHalData->odmpriv) == HAL_STATUS_FAILURE)
> rtStatus = _FAIL;
>
> /*----Restore RFENV control type----*/;
> diff --git a/drivers/staging/r8188eu/include/odm_HWConfig.h b/drivers/staging/r8188eu/include/odm_HWConfig.h
> index b37962edb2ed..3f7185780e87 100644
> --- a/drivers/staging/r8188eu/include/odm_HWConfig.h
> +++ b/drivers/staging/r8188eu/include/odm_HWConfig.h
> @@ -66,5 +66,4 @@ void ODM_PhyStatusQuery(struct odm_dm_struct *pDM_Odm,
> struct odm_per_pkt_info *pPktinfo,
> struct adapter *adapt);
>
> -enum HAL_STATUS ODM_ConfigRFWithHeaderFile(struct odm_dm_struct *pDM_Odm);
> #endif
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
prev parent reply other threads:[~2022-08-20 13:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 18:23 [PATCH] staging: r8188eu: remove ODM_ConfigRFWithHeaderFile() Michael Straube
2022-08-20 13:03 ` Philipp Hortmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8ead88c-853e-c7b6-e2cf-1d210e5ada02@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox