Re: [PATCH 1/4] perf probe: Delete an unnecessary check in try_to_find_absolute_address()

Masami Hiramatsu
2017-01-23T22:48:22Z

On Mon, 23 Jan 2017 16:22:22 +0100
SF Markus Elfring <elfring@users.sourceforge.net> wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 23 Jan 2017 14:54:26 +0100
>
> Remove a condition check which is unnecessary at the end
> because this source code place should usually only be reached
> with a non-zero pointer.

Looks good to me :)

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thanks!

>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> tools/perf/util/probe-event.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index d281ae2b54e8..6c7508337fe8 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -2966,10 +2966,8 @@ static int try_to_find_absolute_address(struct perf_probe_event *pev,
> return 1;
>
> errout:
> - if (*tevs) {
> - clear_probe_trace_events(*tevs, 1);
> - *tevs = NULL;
> - }
> + clear_probe_trace_events(*tevs, 1);
> + *tevs = NULL;
> return err;
> }
>
> --
> 2.11.0
>

--
Masami Hiramatsu <mhiramat@kernel.org>