From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1009CC54E8B for ; Tue, 12 May 2020 11:56:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E37FA206CC for ; Tue, 12 May 2020 11:56:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729809AbgELL4y (ORCPT ); Tue, 12 May 2020 07:56:54 -0400 Received: from foss.arm.com ([217.140.110.172]:53370 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726891AbgELL4x (ORCPT ); Tue, 12 May 2020 07:56:53 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0AEAD30E; Tue, 12 May 2020 04:56:53 -0700 (PDT) Received: from [10.37.12.83] (unknown [10.37.12.83]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ECEF53F71E; Tue, 12 May 2020 04:56:50 -0700 (PDT) Subject: Re: [PATCH v2] memory/samsung: reduce unnecessary mutex lock area To: Markus Elfring , Bernard Zhao , linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, opensource.kernel@vivo.com, Krzysztof Kozlowski , Kukjin Kim References: From: Lukasz Luba Message-ID: Date: Tue, 12 May 2020 12:56:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/12/20 12:40 PM, Markus Elfring wrote: >> Maybe dmc->df->lock seems not needed to protect "if (ret) >> & dev_warn" branch. Maybe this change speed up the code a bit. > > I suggest to improve also this commit message. > > * Please reduce uncertainty. > > * An imperative wording is probably preferred, isn't it? > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=152036d1379ffd6985262743dcf6b0f9c75f83a4#n151 > > * Will it be more appropriate to refer to the transformation “Reduce the lock scope”? > > * Would you like to add the tag “Fixes” to the change description? > > Regards, > Markus > Thank you Markus for providing to Bernard helpful suggestions. @Bernard please read the link above and send v3 Something like: 'memory/samsung: reduce protected code area in IRQ handler' for the subject header would be better. Then in the message explain (without 'maybe') that it will speed-up a bit this IRQ processing and there is no need to protect return value or printing. Regards, Lukasz