From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751236AbdARWuE (ORCPT ); Wed, 18 Jan 2017 17:50:04 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:32891 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750932AbdARWt7 (ORCPT ); Wed, 18 Jan 2017 17:49:59 -0500 Subject: Re: [PATCH] ARM: smp: Remove CPU: shutdown notice To: Russell King - ARM Linux References: <20170117230714.6799-1-f.fainelli@gmail.com> <20170117232314.GI27312@n2100.armlinux.org.uk> <20170118223948.GR27312@n2100.armlinux.org.uk> Cc: Petr Mladek , Chris Metcalf , open list , Aaron Tomlin , Andrew Morton , "Paul E. McKenney" , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Kees Cook From: Florian Fainelli Message-ID: Date: Wed, 18 Jan 2017 14:49:55 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170118223948.GR27312@n2100.armlinux.org.uk> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/18/2017 02:39 PM, Russell King - ARM Linux wrote: > On Tue, Jan 17, 2017 at 03:39:45PM -0800, Florian Fainelli wrote: >> Well, for one it's inconsistent, and it also leaves room for subtle >> timing/caching issues with some platforms (OK, maybe not so much). >> Improving the speed and consistency was the primary motive. > > Actually, it's not as inconsistent as you claim. > > c68b0274fb3c ("ARM: reduce "Booted secondary processor" message to debug level") > dropped the corresponding pr_info() in the bringup path to debug level, > so to be consistent, this one should be dropped to debug level too. > > Removing it arguably makes it more inconsistent! OK, fair point, I missed that one. > > So, I'd be willing to accept a patch lowering this to a pr_debug() > to make it more consistent with the bringup path, but otherwise the > consistency argument doesn't really stand. Sounds good, thanks! -- Florian