From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00BB7372 for ; Wed, 2 Oct 2024 12:33:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727872424; cv=none; b=eEtR+zC1ot6LlN98MN80asZwaE0HUrDYwp8Em9KJEclrrVlfZ0YE7rwsWSjvmz8sJPnzylMwkFXZ3hPIQKVpNFQU0HXMMsTMWZWASC5ZMyYxC/O975rk9kNxSmzsqnHfW5H2pcLV65a9pnYgsvaYXt6fglBy3wbqJjQ6pUZTd3Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727872424; c=relaxed/simple; bh=zIs/iH49kPZLrwITSbR6HBc4hbXpB5govKsyLoed3Pg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pRcOsTLHvuwtKj/8uzLF8kvbQoB5ZevgMGCGIlE9Y/Rm/UE9y4Vw68iS7FUPGVsCnWp0ejFjREJg4/0oND7GnOWnxcMna8w34qxY2vpWg8kWfMYKMrcPbw6iJURrfWFn54IZh4QUqV+mMab+Epyr+YQDe6RITushxU05V42Lqaw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i2Uh0brp; arc=none smtp.client-ip=209.85.208.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i2Uh0brp" Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2fad15b3eeeso31049031fa.2 for ; Wed, 02 Oct 2024 05:33:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727872420; x=1728477220; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=q3eaNgBrzJ/qNa+H0z8ILNR1gYh4zkUM6zdMyMyf418=; b=i2Uh0brpJVKuA01JKvqTbafuMPZPkmfehzrOzwKb0Qzt3VfsrP14YzNsLxCugNlxCE JemgaNJdqF8IvgEBATFq6sKjm8mpqhMQZFLkbeP9f9FNgFPxE3M+CwnXHZ6TjjOZeTCH BeK+R+mKgIHqib7Ngc+U99i50SdkzjIKF89ta3wrZSO9P19kjYGrrg6uZ9bfRzdeMwI3 ouoBFiFRaRfEBddgh0lxYUIqNt0d/VDn3xKCpw79QlmrObAhBh5oLtyCEicsKxIpzIwa LCpQkUskYzdiNFhSmcEFdphcywDJMZVTd1qrseqLwbLillNOj3KxXqJl/x348PTqyQsB AxwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727872420; x=1728477220; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=q3eaNgBrzJ/qNa+H0z8ILNR1gYh4zkUM6zdMyMyf418=; b=GQ0kJc7/OzfBbNNalUqSFtPTzbcuBSFU5MyNQDHoMIX6PlHH4oaI2fCbDWRN3dgorj VIZUVUQYUbXnL04kGmtOgjjigMJ96ut7pzx12kMazObjcJghCRljnlcso9ujMoT7TtrA mUFlFcNpVr6etYDKC0w7oImvFThBvJSMkK+x3cCQ8hboCNlqOrJKOLn8DVuFL5yBC2nL YcTkWVAujQavTUO3RI+kaJnJUvTZrVAfGh71MmIWGclnCiZZOkhrYkdW8lZh54YA9cSy suoh/lla7jaYNejF8jKca8G0bus75wkmiGt/75eh9Ur2FjgAxokFZ7D1PyZwbtx9QwHU 0wdQ== X-Gm-Message-State: AOJu0YyvYtYG1Ro/rfoQgTm/Y/xiL9gUcRXGQve3JSADLNiFQYvJdVBg Qe0lQ8u3KJCfcYKaiHzUO1LHhLy7Un3ahAJiZ/xfw0LURWlto65tosde6A== X-Google-Smtp-Source: AGHT+IG4VfGRJzfEL3RBhS2qNdAVbZuifbuMMbpdkNo/OdSrezWS5TXyG8ZB6OpX3CzMLA1TLuOsYA== X-Received: by 2002:a2e:bc1a:0:b0:2fa:bd19:b821 with SMTP id 38308e7fff4ca-2fae1023234mr21636541fa.9.1727872419500; Wed, 02 Oct 2024 05:33:39 -0700 (PDT) Received: from [192.168.2.177] ([207.188.162.240]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c88240569fsm7554286a12.15.2024.10.02.05.33.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Oct 2024 05:33:37 -0700 (PDT) Message-ID: Date: Wed, 2 Oct 2024 14:33:36 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/3] soc: mediatek: mtk-cmdq: Move mask build and append to function To: AngeloGioacchino Del Regno , linux-mediatek@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com References: <20240918100620.103536-1-angelogioacchino.delregno@collabora.com> <20240918100620.103536-2-angelogioacchino.delregno@collabora.com> Content-Language: en-US, ca-ES, es-ES From: Matthias Brugger Autocrypt: addr=matthias.bgg@gmail.com; keydata= xsFNBFP1zgUBEAC21D6hk7//0kOmsUrE3eZ55kjc9DmFPKIz6l4NggqwQjBNRHIMh04BbCMY fL3eT7ZsYV5nur7zctmJ+vbszoOASXUpfq8M+S5hU2w7sBaVk5rpH9yW8CUWz2+ZpQXPJcFa OhLZuSKB1F5JcvLbETRjNzNU7B3TdS2+zkgQQdEyt7Ij2HXGLJ2w+yG2GuR9/iyCJRf10Okq gTh//XESJZ8S6KlOWbLXRE+yfkKDXQx2Jr1XuVvM3zPqH5FMg8reRVFsQ+vI0b+OlyekT/Xe 0Hwvqkev95GG6x7yseJwI+2ydDH6M5O7fPKFW5mzAdDE2g/K9B4e2tYK6/rA7Fq4cqiAw1+u EgO44+eFgv082xtBez5WNkGn18vtw0LW3ESmKh19u6kEGoi0WZwslCNaGFrS4M7OH+aOJeqK fx5dIv2CEbxc6xnHY7dwkcHikTA4QdbdFeUSuj4YhIZ+0QlDVtS1QEXyvZbZky7ur9rHkZvP ZqlUsLJ2nOqsmahMTIQ8Mgx9SLEShWqD4kOF4zNfPJsgEMB49KbS2o9jxbGB+JKupjNddfxZ HlH1KF8QwCMZEYaTNogrVazuEJzx6JdRpR3sFda/0x5qjTadwIW6Cl9tkqe2h391dOGX1eOA 1ntn9O/39KqSrWNGvm+1raHK+Ev1yPtn0Wxn+0oy1tl67TxUjQARAQABzSlNYXR0aGlhcyBC cnVnZ2VyIDxtYXR0aGlhcy5iZ2dAZ21haWwuY29tPsLBkgQTAQIAPAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AWIQTmuZIYwPLDJRwsOhfZFAuyVhMC8QUCWt3scQIZAQAKCRDZFAuy VhMC8WzRD/4onkC+gCxG+dvui5SXCJ7bGLCu0xVtiGC673Kz5Aq3heITsERHBV0BqqctOEBy ZozQQe2Hindu9lasOmwfH8+vfTK+2teCgWesoE3g3XKbrOCB4RSrQmXGC3JYx6rcvMlLV/Ch YMRR3qv04BOchnjkGtvm9aZWH52/6XfChyh7XYndTe5F2bqeTjt+kF/ql+xMc4E6pniqIfkv c0wsH4CkBHqoZl9w5e/b9MspTqsU9NszTEOFhy7p2CYw6JEa/vmzR6YDzGs8AihieIXDOfpT DUr0YUlDrwDSrlm/2MjNIPTmSGHH94ScOqu/XmGW/0q1iar/Yr0leomUOeeEzCqQtunqShtE 4Mn2uEixFL+9jiVtMjujr6mphznwpEqObPCZ3IcWqOFEz77rSL+oqFiEA03A2WBDlMm++Sve 9jpkJBLosJRhAYmQ6ey6MFO6Krylw1LXcq5z1XQQavtFRgZoruHZ3XlhT5wcfLJtAqrtfCe0 aQ0kJW+4zj9/So0uxJDAtGuOpDYnmK26dgFN0tAhVuNInEVhtErtLJHeJzFKJzNyQ4GlCaLw jKcwWcqDJcrx9R7LsCu4l2XpKiyxY6fO4O8DnSleVll9NPfAZFZvf8AIy3EQ8BokUsiuUYHz wUo6pclk55PZRaAsHDX/fNr24uC6Eh5oNQ+v4Pax/gtyyc7BTQRd1TlIARAAm78mTny44Hwd IYNK4ZQH6U5pxcJtU45LLBmSr4DK/7er9chpvJ5pgzCGuI25ceNTEg5FChYcgfNMKqwCAekk V9Iegzi6UK448W1eOp8QeQDS6sHpLSOe8np6/zvmUvhiLokk7tZBhGz+Xs5qQmJPXcag7AMi fuEcf88ZSpChmUB3WflJV2DpxF3sSon5Ew2i53umXLqdRIJEw1Zs2puDJaMqwP3wIyMdrfdI H1ZBBJDIWV/53P52mKtYQ0Khje+/AolpKl96opi6o9VLGeqkpeqrKM2cb1bjo5Zmn4lXl6Nv JRH/ZT68zBtOKUtwhSlOB2bE8IDonQZCOYo2w0opiAgyfpbij8uiI7siBE6bWx2fQpsmi4Jr ZBmhDT6n/uYleGW0DRcZmE2UjeekPWUumN13jaVZuhThV65SnhU05chZT8vU1nATAwirMVeX geZGLwxhscduk3nNb5VSsV95EM/KOtilrH69ZL6Xrnw88f6xaaGPdVyUigBTWc/fcWuw1+nk GJDNqjfSvB7ie114R08Q28aYt8LCJRXYM1WuYloTcIhRSXUohGgHmh7usl469/Ra5CFaMhT3 yCVciuHdZh3u+x+O1sRcOhaFW3BkxKEy+ntxw8J7ZzhgFOgi2HGkOGgM9R03A6ywc0sPwbgk gF7HCLirshP2U/qxWy3C8DkAEQEAAcLBdgQYAQgAIBYhBOa5khjA8sMlHCw6F9kUC7JWEwLx BQJd1TlIAhsMAAoJENkUC7JWEwLxtdcP/jHJ9vI8adFi1HQoWUKCQbZdZ5ZJHayFKIzU9kZE /FHzzzMDZYFgcCTs2kmUVyGloStXpZ0WtdCMMB31jBoQe5x9LtICHEip0irNXm80WsyPCEHU 3wx91QkOmDJftm6T8+F3lqhlc3CwJGpoPY7AVlevzXNJfATZR0+Yh9NhON5Ww4AjsZntqQKx E8rrieLRd+he57ZdRKtRRNGKZOS4wetNhodjfnjhr4Z25BAssD5q+x4uaO8ofGxTjOdrSnRh vhzPCgmP7BKRUZA0wNvFxjboIw8rbTiOFGb1Ebrzuqrrr3WFuK4C1YAF4CyXUBL6Z1Lto//i 44ziQUK9diAgfE/8GhXP0JlMwRUBlXNtErJgItR/XAuFwfO6BOI43P19YwEsuyQq+rubW2Wv rWY2Bj2dXDAKUxS4TuLUf2v/b9Rct36ljzbNxeEWt+Yq4IOY6QHnE+w4xVAkfwjT+Vup8sCp +zFJv9fVUpo/bjePOL4PMP1y+PYrp4PmPmRwoklBpy1ep8m8XURv46fGUHUEIsTwPWs2Q87k 7vjYyrcyAOarX2X5pvMQvpAMADGf2Z3wrCsDdG25w2HztweUNd9QEprtJG8GNNzMOD4cQ82T a7eGvPWPeXauWJDLVR9jHtWT9Ot3BQgmApLxACvwvD1a69jaFKov28SPHxUCQ9Y1Y/Ct In-Reply-To: <20240918100620.103536-2-angelogioacchino.delregno@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 18/09/2024 12:06, AngeloGioacchino Del Regno wrote: > Move the CMDQ_CODE_MASK packet build and append logic to a new > cmdq_pkt_mask() function; this reduces code duplication by 4x. > > Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Matthias Brugger > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 31 ++++++++++++-------------- > 1 file changed, 14 insertions(+), 17 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > index a8fccedba83f..620c371fd1fc 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -180,6 +180,15 @@ static int cmdq_pkt_append_command(struct cmdq_pkt *pkt, > return 0; > } > > +static int cmdq_pkt_mask(struct cmdq_pkt *pkt, u32 mask) > +{ > + struct cmdq_instruction inst = { > + .op = CMDQ_CODE_MASK, > + .mask = ~mask > + }; > + return cmdq_pkt_append_command(pkt, inst); > +} > + > int cmdq_pkt_write(struct cmdq_pkt *pkt, u8 subsys, u16 offset, u32 value) > { > struct cmdq_instruction inst; > @@ -196,14 +205,11 @@ EXPORT_SYMBOL(cmdq_pkt_write); > int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u8 subsys, > u16 offset, u32 value, u32 mask) > { > - struct cmdq_instruction inst = { {0} }; > u16 offset_mask = offset; > int err; > > if (mask != 0xffffffff) { > - inst.op = CMDQ_CODE_MASK; > - inst.mask = ~mask; > - err = cmdq_pkt_append_command(pkt, inst); > + err = cmdq_pkt_mask(pkt, mask); > if (err < 0) > return err; > > @@ -251,9 +257,7 @@ int cmdq_pkt_write_s_mask(struct cmdq_pkt *pkt, u16 high_addr_reg_idx, > struct cmdq_instruction inst = {}; > int err; > > - inst.op = CMDQ_CODE_MASK; > - inst.mask = ~mask; > - err = cmdq_pkt_append_command(pkt, inst); > + err = cmdq_pkt_mask(pkt, mask); > if (err < 0) > return err; > > @@ -288,9 +292,7 @@ int cmdq_pkt_write_s_mask_value(struct cmdq_pkt *pkt, u8 high_addr_reg_idx, > struct cmdq_instruction inst = {}; > int err; > > - inst.op = CMDQ_CODE_MASK; > - inst.mask = ~mask; > - err = cmdq_pkt_append_command(pkt, inst); > + err = cmdq_pkt_mask(pkt, mask); > if (err < 0) > return err; > > @@ -409,12 +411,9 @@ EXPORT_SYMBOL(cmdq_pkt_poll); > int cmdq_pkt_poll_mask(struct cmdq_pkt *pkt, u8 subsys, > u16 offset, u32 value, u32 mask) > { > - struct cmdq_instruction inst = { {0} }; > int err; > > - inst.op = CMDQ_CODE_MASK; > - inst.mask = ~mask; > - err = cmdq_pkt_append_command(pkt, inst); > + err = cmdq_pkt_mask(pkt, mask); > if (err < 0) > return err; > > @@ -436,9 +435,7 @@ int cmdq_pkt_poll_addr(struct cmdq_pkt *pkt, dma_addr_t addr, u32 value, u32 mas > * which enables use_mask bit. > */ > if (mask != GENMASK(31, 0)) { > - inst.op = CMDQ_CODE_MASK; > - inst.mask = ~mask; > - ret = cmdq_pkt_append_command(pkt, inst); > + ret = cmdq_pkt_mask(pkt, mask); > if (ret < 0) > return ret; > use_mask = CMDQ_POLL_ENABLE_MASK;