From: Guenter Roeck <linux@roeck-us.net>
To: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>,
patrick@stwcx.xyz, joel@jms.id.au, andrew@codeconstruct.com.au,
wim@linux-watchdog.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-watchdog@vger.kernel.org
Cc: Peter.Yin@quantatw.com, Patrick_NC_Lin@wiwynn.com,
Bonnie_Lo@wiwynn.com, DELPHINE_CHIU@wiwynn.com,
bmc-sw@aspeedtech.com, chnguyen@amperecomputing.com
Subject: Re: [PATCH v4 2/3] watchdog: aspeed: Change aspeed_wdt_config struct name to aspeed_wdt_data
Date: Fri, 1 Nov 2024 15:19:37 -0700 [thread overview]
Message-ID: <c91f8b3c-ae3f-4d35-8b7f-2fb2b7cebebd@roeck-us.net> (raw)
In-Reply-To: <20241101121201.2464091-3-chin-ting_kuo@aspeedtech.com>
On 11/1/24 05:12, Chin-Ting Kuo wrote:
> aspeed_wdt_config struct is used to store some HW configuration
> information. Changing its naming to a more generic one,
> aspeed_wdt_data, in order to contain more platform specific
> inforamtion or SW callback functions.
>
> Signed-off-by: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
I fail to see the point of this patch. It is just unnecessary churn.
Just like drivers should not be renamed because of an extended scope
or because someone doesn't like the old name, renaming variables should
be avoided as well. Such renames just make future bug fixes (which may
need to be backported) more difficult.
Guenter
next prev parent reply other threads:[~2024-11-01 22:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 12:11 [PATCH v4 0/3] Update ASPEED WDT bootstatus Chin-Ting Kuo
2024-11-01 12:11 ` [PATCH v4 1/3] watchdog: aspeed: Update bootstatus handling Chin-Ting Kuo
2024-11-01 18:21 ` Patrick Williams
2024-11-04 0:01 ` Andrew Jeffery
2024-11-07 5:35 ` Chin-Ting Kuo
2024-11-07 23:49 ` Andrew Jeffery
2024-11-08 5:42 ` Chin-Ting Kuo
2024-11-08 14:07 ` Guenter Roeck
2024-11-18 12:46 ` Chin-Ting Kuo
2024-11-18 20:50 ` Guenter Roeck
2024-11-18 23:00 ` Andrew Jeffery
2024-11-19 1:27 ` Guenter Roeck
2024-11-20 4:54 ` Andrew Jeffery
2024-12-17 2:15 ` Chin-Ting Kuo
2024-11-07 5:34 ` Chin-Ting Kuo
2024-11-01 22:16 ` Guenter Roeck
2024-11-07 5:35 ` Chin-Ting Kuo
2024-11-01 12:12 ` [PATCH v4 2/3] watchdog: aspeed: Change aspeed_wdt_config struct name to aspeed_wdt_data Chin-Ting Kuo
2024-11-01 22:19 ` Guenter Roeck [this message]
2024-11-01 12:12 ` [PATCH v4 3/3] watchdog: aspeed: Update restart implementations Chin-Ting Kuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c91f8b3c-ae3f-4d35-8b7f-2fb2b7cebebd@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Bonnie_Lo@wiwynn.com \
--cc=DELPHINE_CHIU@wiwynn.com \
--cc=Patrick_NC_Lin@wiwynn.com \
--cc=Peter.Yin@quantatw.com \
--cc=andrew@codeconstruct.com.au \
--cc=bmc-sw@aspeedtech.com \
--cc=chin-ting_kuo@aspeedtech.com \
--cc=chnguyen@amperecomputing.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=patrick@stwcx.xyz \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox