Re: [PATCH 3/4] ASoC: dt-bindings: qcom,sm8250: Add msm8953/msm8976-qdsp6-sndcard

Krzysztof Kozlowski
2024-07-23T08:19:09Z

On 22/07/2024 11:51, Adam Skladowski wrote:
> Document MSM8953/MSM8976 QDSP6 cards.
>
> Signed-off-by: Adam Skladowski <a39.skl@gmail.com>

...

> + then:
> properties:
> - reg: false
> - reg-names: false
> + reg:
> + items:
> + - description: Microphone I/O mux register address
> + - description: Speaker I/O mux register address
> + - description: Quinary Mi2S I/O mux register address
> + reg-names:
> + items:
> + - const: mic-iomux
> + - const: spkr-iomux
> + - const: quin-iomux
> + required:
> + - compatible
> + - model

Don't duplicate. It's already required.

> + - reg
> + - reg-names

And what happened with all other variants? Why do you affect them?

>
> additionalProperties: false
>

Best regards,
Krzysztof